From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#31138: Native json slower than json.el Date: Thu, 25 Apr 2019 17:27:25 +0300 Message-ID: <7ff13b50-f728-1e6e-d56d-fc9b5e306b10@yandex.ru> References: <87sh806xwa.fsf@chapu.is> <83ftqa8qsg.fsf@gnu.org> <83muki6y6r.fsf@gnu.org> <4b8c6799-e845-768b-749c-f2a883ab89f8@yandex.ru> <83h8aq6v6a.fsf@gnu.org> <834l6q6ozn.fsf@gnu.org> <83zhoi59ao.fsf@gnu.org> <83wojm57sl.fsf@gnu.org> <83ftq96azk.fsf@gnu.org> <83wojk534g.fsf@gnu.org> <6308ceff-479b-2ce7-2072-41e683978c7c@yandex.ru> <83h8ao4vl0.fsf@gnu.org> <835zr32x2m.fsf@gnu.org> <8f3318e9-25bd-c7af-20dd-ed78d2a92efd@yandex.ru> <831s1r2uzx.fsf@gnu.org> <83wojj1ep8.fsf@gnu.org> <429a19a3-52aa-02d1-0bd0-77c27c6811d7@yandex.ru> <83lfzyz7np.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="169691"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: sebastien@chapu.is, yyoncho@gmail.com, 31138@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 25 16:28:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hJfMC-000i06-SI for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Apr 2019 16:28:12 +0200 Original-Received: from localhost ([127.0.0.1]:58556 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJfMB-0003K2-L1 for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Apr 2019 10:28:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51015) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJfM2-0003Jl-Sc for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2019 10:28:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJfM1-0007sg-TJ for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2019 10:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45542) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJfM1-0007sT-OG for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2019 10:28:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hJfM1-0004m9-JO for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2019 10:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Apr 2019 14:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31138 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 31138-submit@debbugs.gnu.org id=B31138.155620245718319 (code B ref 31138); Thu, 25 Apr 2019 14:28:01 +0000 Original-Received: (at 31138) by debbugs.gnu.org; 25 Apr 2019 14:27:37 +0000 Original-Received: from localhost ([127.0.0.1]:59084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJfLd-0004lP-Kn for submit@debbugs.gnu.org; Thu, 25 Apr 2019 10:27:37 -0400 Original-Received: from mail-wm1-f48.google.com ([209.85.128.48]:35763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJfLb-0004lA-2K for 31138@debbugs.gnu.org; Thu, 25 Apr 2019 10:27:36 -0400 Original-Received: by mail-wm1-f48.google.com with SMTP id y197so10918764wmd.0 for <31138@debbugs.gnu.org>; Thu, 25 Apr 2019 07:27:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kpCwkRr09y6sZk+RK6dBOtX7H2MvB5lGTkttuqk19ds=; b=Pcs/IMKjahF70up3vfI84BfkEEOCvsKcyGA8Q7TzPL2raNjmYlkLYxG8BpU2P6oXoo 0gIPx8IaSVUORQX7gsj2pBzNznpbdannhnsqf3C6PqWo3TAgpP2AlWi+5/JZZrJY3svO qpLCmFgZfsOMhoSCSaV5KigEvXAkUHtzb3jve3HhuxeIQOM5PhToqByrrIKRWBDM+kWM Geyl6XFDhUfmWQa6dkZ+yybfrHhj4YecYEQ9lZzTvANgSDYUzAYNLVYDTaCRhLrZk7S1 yl4n6pZSfbE0LU5w/+3TCh7e942Aa48oBOHfQCt1W67/cSEMUF/I163rPufEzKpq6RRc 73aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kpCwkRr09y6sZk+RK6dBOtX7H2MvB5lGTkttuqk19ds=; b=KfIjwcChWo4gY0Nxscj7M3ANe5NVFqxadYLU2E6GICKTHzwJi65uSXdeANhiu8n9SH pWdtUDbgYQzJUZ85KcNo29lzyBVKyVe5ry1VBLgWGAQLi0hArYJ/44izpHEhyrbmWya9 5axmIlbS10fjwG01XAQc/zdtghckgif/TVlBYYUkWkrY3qvN02hLQu0u6MgT79f9x+dv tryXdUxeVtHSfACqXkIlCa7PjZijN/5TUxqjbqafjzjPRUwTjtXOUmB2gwctWqHeUvGY q2Hjn3zK677x0hPDN/+A443DJBrP1Q2r2efClQXqGzMk1HxjkN2l6zw55LmhSM99T+jB fwcw== X-Gm-Message-State: APjAAAWvonx/0F+srucJpD1yYUHDuFgX5XesQSuCDljrg+u+Ab7ElwNA SiiFn7sB7wlKpel71SOCbtTYQlma X-Google-Smtp-Source: APXvYqyCg9Y0eG+Y7pmvuu+uTD5Mp5C8RGhwjFKO038LXEBgRHL5H7voJ6emW9PKuEczdqv01D0DhA== X-Received: by 2002:a1c:a953:: with SMTP id s80mr3820828wme.50.1556202448881; Thu, 25 Apr 2019 07:27:28 -0700 (PDT) Original-Received: from [192.168.0.195] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id w10sm6391985wmi.43.2019.04.25.07.27.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Apr 2019 07:27:27 -0700 (PDT) In-Reply-To: <83lfzyz7np.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158251 Archived-At: On 25.04.2019 13:44, Eli Zaretskii wrote: >>> Why faster? >> >> Because the library will perform its validation anyway, during normal >> execution. > > But if we validate the string before even calling the library, that > will be even faster, no? Only if the string is invalid. There's not much point in optimizing for that situation, I think. >> Any extra validation work Emacs performs, will take time on >> top of that (of course, I don't know how much time). > > Didn't we just establish that it's almost negligible? Especially for > short strings? Probably. But I can't say for sure without seeing the code. >>> And more importantly, will the error indication be useful enough to >>> the Lisp program that triggered it? If we signal an error, we can >>> make sure of that. >> >> We still signal errors if the library returns an error code. > > But we need to guess the reason. I think I've addressed that in the part of the reply you cut out: "we also perform additional validation ourselves if something goes wrong". That can be extended, if you like.