From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#52293: 29.0.50; [PATCH] Prevent further cases of duplicated separators in context menus Date: Sun, 5 Dec 2021 20:07:56 -0800 Message-ID: <7f710476-7531-f913-7c2f-65d617dcd498@gmail.com> References: <864k7n9xt5.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13563"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52293@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 06 05:09:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mu5JR-0003Q7-8z for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Dec 2021 05:09:13 +0100 Original-Received: from localhost ([::1]:36118 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mu5JP-0005Kl-OU for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Dec 2021 23:09:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mu5JG-0005KN-Go for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 23:09:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48648) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mu5JG-00047n-9B for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 23:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mu5JF-0003je-RW for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2021 23:09:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Dec 2021 04:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163876368414265 (code B ref 52293); Mon, 06 Dec 2021 04:09:01 +0000 Original-Received: (at 52293) by debbugs.gnu.org; 6 Dec 2021 04:08:04 +0000 Original-Received: from localhost ([127.0.0.1]:60194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mu5IK-0003i0-L8 for submit@debbugs.gnu.org; Sun, 05 Dec 2021 23:08:04 -0500 Original-Received: from mail-pg1-f179.google.com ([209.85.215.179]:37863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mu5II-0003hU-OB for 52293@debbugs.gnu.org; Sun, 05 Dec 2021 23:08:03 -0500 Original-Received: by mail-pg1-f179.google.com with SMTP id 71so9250457pgb.4 for <52293@debbugs.gnu.org>; Sun, 05 Dec 2021 20:08:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Epp+y+b6yVQZu6Db7yNszF0aQxakdG0QizTv/yGB3qs=; b=oodpexATZg7eyQN+q3hfSeV2Ni9X6rCAfkOvdWdm/b4vvSdfgr9p0z0tIhdXoULn4c DrObY3cpVRmIzCgBpjairxMHmJ4/lWhZgKaJrnxZ3Jium+gyTlN/8cwEx9uBV6U/9Z96 VdLcSkc2hs7fXz3Rkb1mBaLQhEz93rp5RZxQUchEtAcqTFRNP2007BnjMBBwGopTrt7s ZG3XkQstaQZpWvxf6lOZr32lnrcHxmX8MRAn2mz3bufKWrGmdK5HqUP/Aj35qCfHbC+J CC/XZYHbuxMJWgHj1dzU2m1C7TLPhjGtG3QzskEQFGhDGBWrVo/NoyAkics1ND4wRBV0 +Ziw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Epp+y+b6yVQZu6Db7yNszF0aQxakdG0QizTv/yGB3qs=; b=2ms/rKRGL9cknDSjxqB9cIyAkhxAUjGlPtFUuzFRRDLrETt2oTDiM2buyO4vLxZSUk BG59RLWegJD6cF9abD8iSIqidW9KQRODtU9+jsj8uhVtCsKRRQb9gd0Lpt3MVfS3qZUs EyBh6zF0b0itgRoOJzSrHVUb4cv8Khu+VTquP7QpjUQ41kciAaLwzjAIyb4wqBWQTjDH 6s7oYXjfEfIi46sWmSOlUcYWTlraqhat59T+l8npslWUDi5BJep7tBJRqtWX+qZ0Lvp5 nbVkQGamVarFyiZbL3mtEVV/mHDop3gPpAIo7lly9yOOt+tzTIRZLJgJ1Sea2wNHD/nV sHLQ== X-Gm-Message-State: AOAM532BCuAtUggqyW+GpYBjFVhXyq2/Je5ph1hY9R83416yh8QNUEMz Qxgmkf1hlRx9FacpcQo5ptlUDKgk9PM= X-Google-Smtp-Source: ABdhPJxSnveMkN3FvRi9/QBiWBYXeCarl344AAVwfxNFp0Tz0tBYJcZlde4V+bu/Jc+lEVq33SoRhA== X-Received: by 2002:a05:6a00:9a3:b0:49f:bf9b:3192 with SMTP id u35-20020a056a0009a300b0049fbf9b3192mr34080418pfg.44.1638763676878; Sun, 05 Dec 2021 20:07:56 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id n16sm8430517pja.46.2021.12.05.20.07.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Dec 2021 20:07:56 -0800 (PST) In-Reply-To: <864k7n9xt5.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221706 Archived-At: On 12/5/2021 1:39 AM, Juri Linkov wrote: >> Attached is a patch to fix this based on the discussion in bug#52237. > > Thanks for the patch. > >> One slightly odd thing is that for context menu functions that put their items >> at the top, they place their separator *below* the items. Other functions >> place the separator *above* the items. > > There is some logic in this: when the menu doesn't contain a separator > at the top, then it is necessary to add a separator below the added items, > e.g. by modifying such a menu: > > - existing menu item 1 > - existing menu item 2 > > to > > - new item 1 > - new item 2 > - new separator > - existing menu item 1 > - existing menu item 2 Right, makes sense. (I was originally thinking that we could put items above `top-separator', and that then there'd be a separator below the items. That's not right though, since we'd use `define-key-after', putting the items *below* `top-separator'. There's no `define-key-before', so I just had the logic backwards in my head.)