From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep' Date: Sat, 10 Apr 2021 04:40:49 +0300 Message-ID: <7f1b570f-ea1b-5524-59fa-83bb5eaa9abd@yandex.ru> References: <87pmz8lc17.fsf@mail.linkov.net> <9453a08f-5014-b4bc-8472-a4c2ff44c687@yandex.ru> <87o8eo38q9.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15875"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 Cc: 47566-done@debbugs.gnu.org, Ramesh Nedunchezian To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 10 03:41:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lV2cf-00041g-0o for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Apr 2021 03:41:17 +0200 Original-Received: from localhost ([::1]:54932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lV2cd-0000Bb-OW for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Apr 2021 21:41:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lV2cQ-0000BJ-Sr for bug-gnu-emacs@gnu.org; Fri, 09 Apr 2021 21:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39645) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lV2cQ-0001cI-M0 for bug-gnu-emacs@gnu.org; Fri, 09 Apr 2021 21:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lV2cQ-0003pC-JS for bug-gnu-emacs@gnu.org; Fri, 09 Apr 2021 21:41:02 -0400 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Apr 2021 01:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 47566 X-GNU-PR-Package: emacs Mail-Followup-To: 47566@debbugs.gnu.org, dgutov@yandex.ru, rameshnedunchezian@outlook.com Original-Received: via spool by 47566-done@debbugs.gnu.org id=D47566.161801885814681 (code D ref 47566); Sat, 10 Apr 2021 01:41:02 +0000 Original-Received: (at 47566-done) by debbugs.gnu.org; 10 Apr 2021 01:40:58 +0000 Original-Received: from localhost ([127.0.0.1]:51191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lV2cM-0003oj-Lu for submit@debbugs.gnu.org; Fri, 09 Apr 2021 21:40:58 -0400 Original-Received: from mail-wr1-f46.google.com ([209.85.221.46]:38672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lV2cL-0003oX-FC for 47566-done@debbugs.gnu.org; Fri, 09 Apr 2021 21:40:57 -0400 Original-Received: by mail-wr1-f46.google.com with SMTP id w4so3532912wrt.5 for <47566-done@debbugs.gnu.org>; Fri, 09 Apr 2021 18:40:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PMA+2R/b8CKw1LzMqGxTXDaa73CT7T2QKTRh5d3HxbI=; b=gbcjMv9PBEpsk15HJ/sbPxeiHKX87w5UQRz2D5mxUFhj0EeN6dhcPVvnbVnd+0K8r8 jeTN7ypsenQFJE1WnMzyMr+8U5fv74bLL+ky1eXgt6tCMPxaxuXGY0F9SNSjD7usOMJo X/832qn7IMnc7+mIHXcE5dHxG/OjLFtN2yiNVDxbSnr2hq8NVdUg1ZdDVvv+h8Hsk9h1 GkSP8OAqHESpHXgqOIcrwEL2Zhmql4n3TrrG+VDKuBcqfqQmcTgMzCdX8dITLvZGZ1gL kWsGx9ypdVRTZez1piOQ+flJYVf++f0TQDw0iqeBBU1/2WOuw0SKRlkEZhZVjS2TTXU8 qDKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PMA+2R/b8CKw1LzMqGxTXDaa73CT7T2QKTRh5d3HxbI=; b=d57sM47hJjpvF4G6spAxfZzaa/4sDG61LA1FlrxRsGUAxM2092JbMxKxvq30uiGweP dLBJ8T12O4YVTy684PvlLoAoysu9vtu5DNWeidp7go+i8RcUWgZ5GJpM3wNjAJEtGUEF qGF7QXs8s7omgfUhQGD8Jaujb0EX26trGWxjInIuwsb/BnR+j713iGboMdoDlZgr3C6y Qz5gLrG6f70f9tKjV3tM5wpNJzUUfyIzchYpNuawVkT6eWTY2rw8wehOq3DCYBj8h+8O 6V3dZMnu+VhPbGNdCl9osLW/9b5AV9V5gT9aEqTUQkvTbfKJLzO9vhyGHqTdTzjrGvR0 HzvQ== X-Gm-Message-State: AOAM532eRbVHE1Kj8YmxS9aiaSX+W73y1nGDbDdnzE9mcIAgeiGaAC9N lpn4IfY3JcwQ9Xo9iiOmmsPdk4fLTmQ= X-Google-Smtp-Source: ABdhPJzGVgABTCIE6jYXDKMvjYIXJJpEi3OsUvhouuAcmkApbC8RYq2Ol8BBQKh1o9R8cXYU0TZuAQ== X-Received: by 2002:a5d:4751:: with SMTP id o17mr19878684wrs.219.1618018851554; Fri, 09 Apr 2021 18:40:51 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id g84sm5874220wmf.30.2021.04.09.18.40.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Apr 2021 18:40:51 -0700 (PDT) In-Reply-To: <87o8eo38q9.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203779 Archived-At: On 08.04.2021 21:57, Juri Linkov wrote: > Thanks for the detailed test case. Now it's fixed in 580c4c6510. Thanks! repeat-mode is looking good now (*). I've added integration for it to diff-hl master, and with that we can close this issue. Thanks all. (*) Though the first impression, in comparison, was that it is too chatty. The hints are definitely helpful for discovery at first, though. Maybe something like this would be an improvement? Experimental code warning. diff --git a/lisp/repeat.el b/lisp/repeat.el index b3c58f2f81..e704e4da56 100644 --- a/lisp/repeat.el +++ b/lisp/repeat.el @@ -404,7 +404,7 @@ repeat-post-hook (key-description repeat-exit-key)) "")))) (if (current-message) - (message "%s [%s]" (current-message) mess) + (message #("%s [%s]" 3 7 (face deemphasized)) (current-message) mess) (message mess)))) ;; Adding an exit key