From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#60376: 29.0.60; Standardize csharp-ts-mode's font-lock features Date: Sat, 31 Dec 2022 10:53:54 +0100 Message-ID: <7e522fe6-2e5a-5bca-10b1-5a19862dcea2@secure.kjonigsen.net> References: <83v8ls6gvb.fsf@gnu.org> <07332CE6-C6A9-469A-9C41-B47841D8798D@secure.kjonigsen.net> <87r0wgpu3g.fsf@thornhill.no> Reply-To: jostein@kjonigsen.net Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26704"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Cc: 60376@debbugs.gnu.org, casouri@gmail.com To: Theodor Thornhill , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 31 10:55:28 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pBYaM-0006mG-90 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Dec 2022 10:55:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pBYa5-00089m-Cc; Sat, 31 Dec 2022 04:55:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBYZz-000862-3E for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2022 04:55:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pBYZy-0004YX-Jw for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2022 04:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pBYZy-0006yF-Ea for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2022 04:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Dec 2022 09:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60376 X-GNU-PR-Package: emacs Original-Received: via spool by 60376-submit@debbugs.gnu.org id=B60376.167248044926699 (code B ref 60376); Sat, 31 Dec 2022 09:55:02 +0000 Original-Received: (at 60376) by debbugs.gnu.org; 31 Dec 2022 09:54:09 +0000 Original-Received: from localhost ([127.0.0.1]:36575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBYZ6-0006wZ-GV for submit@debbugs.gnu.org; Sat, 31 Dec 2022 04:54:08 -0500 Original-Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:54933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBYZ4-0006vv-Aj for 60376@debbugs.gnu.org; Sat, 31 Dec 2022 04:54:07 -0500 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 68BCB3200A79; Sat, 31 Dec 2022 04:54:00 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 31 Dec 2022 04:54:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:reply-to:sender :subject:subject:to:to; s=fm1; t=1672480440; x=1672566840; bh=Q0 1GutfwAb6vd4bNpuW2sTDekh7JMz9z3CSn+a7tXXQ=; b=GHE+XWaEAAWk9eHVmP iouifrunNng8S75dkT0wZXSpxI/jH5iwkisiKXbBv4bxzCL87LHAoYVc0AwYDI0f Y2ol2NgnaoLJkym7dEMhfi58s+hmeQmew40hXtUyu8Anpcz6XRHPQNw0ofy8kYK8 31PZRrAzY4dBU9n4ccnYD1U4cPN9T3pGXGBuZHnduZnno5dgR461v/ZgFjJDHezv 0cb0pt/drlyBqmgFqPeK+X6gVP6F9B3VBmfDRSFraFdoolqkotoVmcfOdvd/svww UGZvXlmfD4xablwlhaPhM61tPtURp+O72mP86G+QwxskY538IyLxn2Kt7tspr0d0 WmKA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1672480440; x=1672566840; bh=Q01GutfwAb6vd4bNpuW2sTDekh7JMz9z3CS n+a7tXXQ=; b=XofByjmawS6PwFLQEL9UAqp3Nzs1R3Bw7SJ+zaSGbzhh9t19q4J YrmsWaEgORMWLwWIcCF5eiQU8fKbLHapzVOm3loKomi+UsKsnoPEvBX2A4olvDdI JAV4YDozMpVJeJoFEJ8wgoNpq6MOOgoi4TZAE2Mtut16oF7x8H5wja/K59baulAT EVBtOOHHyOK4BauIH4eTEXHJFViMCRDy2bBCpRL74BRG2QojJYjwDwpcM/07mQLv GdSTO8yfJ7jfJIzJlIdu9yhaHGkLAKTjMb6YPkutgl8Dbi+9EZMzhstTuw8SrFGQ 0EtjaAZ8dStf8ZiX/QNZEDNLnqGvwd8xQ6w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrieekgddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfghruffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeflohhs thgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonh highhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpedtfedtkedtffeukedvvddvkeeu veduvdeitdfffffggfegledtkeehgfdtjeekveenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhn ihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 31 Dec 2022 04:53:58 -0500 (EST) Content-Language: en-GB, nb-NO In-Reply-To: <87r0wgpu3g.fsf@thornhill.no> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252179 Archived-At: On 30.12.2022 20:30, Theodor Thornhill wrote: > Jostein Kjønigsen writes: > >>> On 30 Dec 2022, at 16:46, Eli Zaretskii wrote: >>> >>>  >>>> Date: Fri, 30 Dec 2022 15:39:20 +0100 >>>> Cc: casouri@gmail.com, 60376@debbugs.gnu.org, theo@thornhill.no >>>> From: Jostein Kjønigsen >>>> >>>> To be clear: I think csharp-ts-mode works well beyond 85% (it's what I >>>> use as my daily driver), but the syntax-highlighting at level 3 may be >>>> more excessive than some people (like Stefan) prefer. >>>> >>>> If we instead for these "major" changes suggested by Yuan, instead aim >>>> for just moving some "smaller" implementation-detail >>>> (function-invocations and property-highlighting) to level 4, I think we >>>> she be able to get something which is mostly what Stefan would expect >>>> and prefer, and it would be a much smaller change. >>>> >>>> Then we can take a look at those bigger changes (standardized features, >>>> enabling/disabling them individually, as end-users, etc) for Emacs-30. >>>> >>>> I think that's a more realistic plan. Does that sound OK? >>> Yes, it does. And I urge you to submit patches to that effect. >>> >>> Thanks. >> Theo has offered to come up with some patches and I’ll do my best to battle-test them. >> >> Hopefully we can get this done quickly enough to suit your taste ;) >> > Let's start here! > > If you're satisfied, Jostein, report back, then you install, Yuan? > > Then rinse repeat :-) > > Theo I've tested it, and I can't say I see any regressions. Two things though: - Method-invocations are still getting fontified on level 3. I believe Stefan wanted this to be on level 4? - I see we've missed fontification of method-invocations on self-methods (this.DoSomething()) entirely. If we fix the first thing, I guess the second one is also doable? :) -- Jostein