From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#46859: 28.0.50; [PATCH]: Add option to truncate long lines in xref.el Date: Sat, 06 Mar 2021 23:24:39 +0000 Message-ID: <7de1aeec5237788b3d98@heytings.org> References: <4119ea30557ef84ca190@heytings.org> <7eb7ee0f-7dba-c90d-cb58-af42c3828643@yandex.ru> <4119ea30554b406efbbf@heytings.org> <4119ea30558f1e4145b0@heytings.org> <4119ea30555e80bdcf7e@heytings.org> <1c82e582-8b90-f3c5-5391-1e88ca4e7ab2@yandex.ru> <4119ea30553e3f90ab8c@heytings.org> <87y2f42ex5.fsf@mail.linkov.net> <4119ea30552873ab9870@heytings.org> <83eegvk2u0.fsf@gnu.org> <9cff0f8894658f3b50c8@heytings.org> <83y2f3huz2.fsf@gnu.org> <9cff0f88942d4103c685@heytings.org> <83mtvjhrzj.fsf@gnu.org> <9cff0f889435d8d03313@heytings.org> <834khq266r.fsf@gnu.org> <9cff0f8894ab45713d12@heytings.org> <16ac41d4-5718-0cec-a68b-4abcc736ee4a@yandex.ru> <109276c6-30fb-b1ca-cafa-48a15710099b@yandex.ru> <7de1aeec520f4204be5b@heytings.org> <7de1aeec52841199faed@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17602"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46859@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 07 00:25:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIgIO-0004RZ-UF for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Mar 2021 00:25:16 +0100 Original-Received: from localhost ([::1]:37186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIgIN-00025L-V7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Mar 2021 18:25:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIgIB-000246-A2 for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 18:25:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55214) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lIgIB-000728-2Z for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 18:25:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lIgIA-0005Rk-Vk for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 18:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Mar 2021 23:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46859 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46859-submit@debbugs.gnu.org id=B46859.161507308320896 (code B ref 46859); Sat, 06 Mar 2021 23:25:02 +0000 Original-Received: (at 46859) by debbugs.gnu.org; 6 Mar 2021 23:24:43 +0000 Original-Received: from localhost ([127.0.0.1]:38526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIgHq-0005Qy-QX for submit@debbugs.gnu.org; Sat, 06 Mar 2021 18:24:43 -0500 Original-Received: from heytings.org ([95.142.160.155]:46146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIgHp-0005Qp-BR for 46859@debbugs.gnu.org; Sat, 06 Mar 2021 18:24:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1615073079; bh=wzP8p9v2sINtZlztms0dNkRp+wQ6IsV10IugooNMCqM=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=tvBTsfKs60KQudf4CVeo77HSpoHm8mq00z0bdm+VrG+wg7SwLPZ5Nu9smEzS31BU+ HYjB0rBD5BiXqfRWoApqmh52GMevgP7ucpX0g+V7m3PwNLJCvnRIKdFJRxd5ToV19I 29ZrAFxMTEilVo20ZRTYtbo5N+nkC6bFL9//cgkK7ZjSLSFYswQtpykZtJVYUhURZ5 5v7frICafgegAg23eihHcCbNEtpe74BUlNF9lifPMvVFZW80n/OyNgfyutPANJTr4O 9L9Up6PkFWP646DLkgSSTtye5juICf/zIc96k4IgFAFfnrKWBBx1TTNzlgQc+mNMdO GJcEtw9PYqGlA== In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201698 Archived-At: > > 'find' is rarely the fastest way to list all the files in the project. > Have you timed it alone? > > 'git ls-files' is usually much faster, and that's what 'project-files' > uses under the covers. > I don't see a big difference: find takes 0.006 s, git ls-files 0.002 s. Okay, that's three times slower, but those four milliseconds are not the bottleneck here. I just ran some of the timing tests again, and they are about ten milliseconds faster with git ls-files, which is not a huge difference. (Of course I do not object to the use of git ls-files.) > > So if you redo your test with 'project-find-regexp' as I suggested, you > might discover a different slowdown multiplier. > I wanted to first time these things outside of Emacs, it seems to me that it's a more objective comparison.