From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#46859: 28.0.50; [PATCH]: Add option to truncate long lines in xref.el Date: Sat, 06 Mar 2021 12:54:40 +0000 Message-ID: <7de1aeec520f4204be5b@heytings.org> References: <878s74fv27.fsf@mail.linkov.net> <4119ea3055ef8f306fc0@heytings.org> <4119ea30557ef84ca190@heytings.org> <7eb7ee0f-7dba-c90d-cb58-af42c3828643@yandex.ru> <4119ea30554b406efbbf@heytings.org> <4119ea30558f1e4145b0@heytings.org> <4119ea30555e80bdcf7e@heytings.org> <1c82e582-8b90-f3c5-5391-1e88ca4e7ab2@yandex.ru> <4119ea30553e3f90ab8c@heytings.org> <87y2f42ex5.fsf@mail.linkov.net> <4119ea30552873ab9870@heytings.org> <83eegvk2u0.fsf@gnu.org> <9cff0f8894658f3b50c8@heytings.org> <83y2f3huz2.fsf@gnu.org> <9cff0f88942d4103c685@heytings.org> <83mtvjhrzj.fsf@gnu.org> <9cff0f889435d8d03313@heytings.org> <834khq266r.fsf@gnu.org> <9cff0f8894ab45713d12@heytings.org> <16ac41d4-5718-0cec-a68b-4abcc736ee4a@yandex.ru> <109276c6-30fb-b1ca-cafa-48a15710099b@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36140"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46859@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 06 13:55:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIWSc-0009IC-IR for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Mar 2021 13:55:10 +0100 Original-Received: from localhost ([::1]:54700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIWSb-0002vH-Ja for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Mar 2021 07:55:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIWSU-0002uy-Au for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 07:55:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52903) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lIWSU-0006fg-3p for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 07:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lIWSU-0000BK-1T for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 07:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Mar 2021 12:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46859 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46859-submit@debbugs.gnu.org id=B46859.1615035283669 (code B ref 46859); Sat, 06 Mar 2021 12:55:01 +0000 Original-Received: (at 46859) by debbugs.gnu.org; 6 Mar 2021 12:54:43 +0000 Original-Received: from localhost ([127.0.0.1]:36216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIWSB-0000Aj-0u for submit@debbugs.gnu.org; Sat, 06 Mar 2021 07:54:43 -0500 Original-Received: from heytings.org ([95.142.160.155]:45472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIWS9-0000AY-Ba for 46859@debbugs.gnu.org; Sat, 06 Mar 2021 07:54:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1615035280; bh=raaNAvR/I0txbYXFMWdFRcmL28hZD49gO8hDY2bdCsA=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=lcj/oM7C1BeQ6PIMb/jfyL2n+2IvQHR/AHrMbVGyBqtV8BSaxgr+fqjL0BuO+k3Zg jSQ97T2Q0fA+UUyp6tsgkgsqtJR0nWtu0SxHy0tGnzdu4wXahz0bs+E+KuIlDbyDTc jENf+mCjTP8X96cpci55XiSeT5f5iKmZV1dx9rgtBEmUdw1pzhaDHQMuoPytfilSem 9TLP5ZmddQPppV+CUyXmAZELwz9FJv36o1QHJLz2iIz83yiUcAaoSpT6AnZf2z/yS5 7XUC6vAGqyk4GPwLEG0mbmX9K6xds1G0UeidvygJvVBLa9tyKFBfzbyHqTkuD50p9I fl4P6pXg0c87Q== In-Reply-To: <109276c6-30fb-b1ca-cafa-48a15710099b@yandex.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201622 Archived-At: > > Except, um, we still need to fill in the "summary" attribute for all > matches, so that there is something to display in the Xref buffer (the > line contents around the match), and the -o flag strips those. > That's the purpose of the '.{0,100}' context. In typical cases (souce code files with lines that do not have more than 80 colums) you don't even see the difference in the result buffer: you see the whole line. > > And if we were to use the '.{0,100}file.{0,100}' trick, it messes up the > location of the match, the reported byte offset become unreliable. > That's a problem to solve, indeed. At first sight it doesn't seem unsolvable. > > Also: grepping for that kind of regexp is noticeably slower than > grepping for 'file'. Or even '.file'. Like 85ms vs 7ms slower. > Well, the bug report mentioned delays of 3-4 seconds on files with very long lines, so I'd guess that 85 ms is a pretty reasonable speed...