From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#51215: Add a navigation feature to vc and diff mode: diff-goto-line Date: Tue, 19 Oct 2021 03:54:42 +0300 Message-ID: <7dc92f6f-0e66-398a-cf2c-941d16026b66@yandex.ru> References: <87k0ifpcc2.fsf@mat.ucm.es> <9618968c-f3f4-da4f-4dba-e34a88036ced@yandex.ru> <87k0iag5vr.fsf@mat.ucm.es> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29313"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 To: 51215@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 19 02:55:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcdPJ-0007QP-Jr for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 02:55:09 +0200 Original-Received: from localhost ([::1]:35522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcdPH-0003dB-UV for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Oct 2021 20:55:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcdPC-0003d3-C4 for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 20:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37353) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mcdPC-0007Eu-3B for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 20:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mcdPC-0007gh-03 for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 20:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Oct 2021 00:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51215 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51215-submit@debbugs.gnu.org id=B51215.163460489129532 (code B ref 51215); Tue, 19 Oct 2021 00:55:01 +0000 Original-Received: (at 51215) by debbugs.gnu.org; 19 Oct 2021 00:54:51 +0000 Original-Received: from localhost ([127.0.0.1]:48899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcdP1-0007gF-1W for submit@debbugs.gnu.org; Mon, 18 Oct 2021 20:54:51 -0400 Original-Received: from mail-lj1-f173.google.com ([209.85.208.173]:37549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcdOz-0007g1-9G for 51215@debbugs.gnu.org; Mon, 18 Oct 2021 20:54:49 -0400 Original-Received: by mail-lj1-f173.google.com with SMTP id g8so2944008ljn.4 for <51215@debbugs.gnu.org>; Mon, 18 Oct 2021 17:54:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WNmkuYgwvpMV45T6sTJ2B6/ZJL/rVTMmH/4Yb+q6oCM=; b=lB/EfxlQEl6eMgiK6WBYavA0FP7Tki3BZbRZoEECDrGVn53ywc6g8BrN5CuoIkDw/N k6PZ4YFIGNRM5xIuBLGGJ5cj8bWLMwku0VROlWTFKncoM2ueOeqAnT7JPUdvwYBTv8Ee kBsJD2meLZtXiPZ2aiOes0SInt88g6V5vgW3LTtaaIvrZI9mJtEKjc0smU9rGvTQg/Zn QizfmKwJvwq8N7g2iGRcvWmw+WhdcoFxVvQFye/aOLkp/VBdIcjGhE46hLtqlbLj60uU jtyq9GEHDYitWHUkatVQqhvHiYQc95lrYvlUFwtKmKQyI8c0eRvh0hQyEirGM03PBGP9 BK6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WNmkuYgwvpMV45T6sTJ2B6/ZJL/rVTMmH/4Yb+q6oCM=; b=30M0Vy9qYBHkrfDIHKs1Riu8FK64gLttZfZSE629X0DJ5qbzaqaPZKy990Q4vEmYYH cquYVAn+pvWHwuydPvdh2v//2kAJSPY9s5o/qNet71twcWAqiZfhGdBp2zY2A8RZwah0 1S8yQDagmC/fX7nVilLkD2AcnVUxl7l5Y9rSfvxJ24qKL5+JHhe3xDPc05G5RRMmSrtn Vokvr/gMwu/KBVZR1asF8hGKZDsxtBOYAZIaTL6+oh+7Dn1jxLRU/vxbvVR6ejI9+vct PySJzCFpi6dvEUfA1EpuyC+k+yEgupzC5Oy94vWIJ+aP0gGpTt7ZW+61+kCeY554og5d DPrw== X-Gm-Message-State: AOAM5300UoX744/ybm1bCbsw4S+vGPgMR/ScBdn/WRe4vGaZ6HsCPo4x /WVy2YDRPcgjkUtFDkWFpekhpJ/Pb0M= X-Google-Smtp-Source: ABdhPJxrQY59u8JeRygHL8LDH8qzsRbwTbbC6Tky7uB0DlB68VP7H/pjPh2lqtsSyeqjxy6BzfrqlQ== X-Received: by 2002:a2e:b4ba:: with SMTP id q26mr3426081ljm.39.1634604883141; Mon, 18 Oct 2021 17:54:43 -0700 (PDT) Original-Received: from [192.168.0.103] ([5.18.248.29]) by smtp.googlemail.com with ESMTPSA id d17sm1445475lfg.122.2021.10.18.17.54.42 for <51215@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Oct 2021 17:54:42 -0700 (PDT) In-Reply-To: <87k0iag5vr.fsf@mat.ucm.es> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217531 Archived-At: Hi Uwe, On 18.10.2021 10:16, Uwe Brauer wrote: >> The most recent discussion regarding it can be found in bug#36526. > > I am not that used to that interface I jumped to > https://lists.gnu.org/archive/html/emacs-bug-tracker/2020-08/msg00633.html You can read the discussion starting from https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36526#53. >> To sum up: the patch(es) have merit, and they're waiting for someone >> to champion their inclusion: test them for bugs, compare the different >> available implementations of the "skip to" functionality, and >> generally examine how the new functionality affects the existing >> workflows (e.g. whether it should be enabled on root diffs). > > Forgive me my ignorance (maybe because I am a mercurial user 😇) > the documentation vc-root-diff talks about tree revision > > So if I understand that correctly this is for the case I want really > consider the diff of the repository? > > That is the same effect as if: I change 3 files in the repository and would run > git diff > or > hg diff > from the command line? vc-root-diff, yes. 'C-x v D'. > If that is the case I would say, disable the feature for that sort of > diffs for the moment. The patch is more useful for > one-file-basis. > At least that is how I used it for a year. OK, thanks for the feedback. But we should consider both changes in the proposal, ideally. Not just the one you happened to have been using for a period of time. Would somebody else like to chime in? > So what is the best strategy? How can I test the patch concerning > bug#36526? > > The message talks about emacs 26, I am running a 2 month old > git master emacs (still 28). > So can that patch be tested in version I use? That's a part of championing the change: try to see whether the patch still applies. If not, maybe try updating it yourself.