From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Mathias Dahl" Newsgroups: gmane.emacs.bugs Subject: Re: image-dired does not rotate the original image Date: Sun, 22 Jul 2007 15:52:16 +0200 Message-ID: <7dbe73ed0707220652w3d440b41m98a24248341486d@mail.gmail.com> References: <7dbe73ed0707220550k6cdc800asd2474266bcd6f1ed@mail.gmail.com> <874pjwpnoz.fsf@debby.local.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1185120653 783 80.91.229.12 (22 Jul 2007 16:10:53 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 22 Jul 2007 16:10:53 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org To: "Dieter Wilhelm" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 22 18:10:52 2007 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ICe1C-0007NF-4u for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Jul 2007 18:10:50 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ICe1B-00012d-KW for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Jul 2007 12:10:49 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ICbrB-0004qU-O0 for bug-gnu-emacs@gnu.org; Sun, 22 Jul 2007 09:52:21 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ICbrA-0004p0-1N for bug-gnu-emacs@gnu.org; Sun, 22 Jul 2007 09:52:21 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ICbr9-0004ot-TL for bug-gnu-emacs@gnu.org; Sun, 22 Jul 2007 09:52:19 -0400 Original-Received: from mu-out-0910.google.com ([209.85.134.191]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ICbr9-0002wL-Gg for bug-gnu-emacs@gnu.org; Sun, 22 Jul 2007 09:52:19 -0400 Original-Received: by mu-out-0910.google.com with SMTP id g7so1676293muf for ; Sun, 22 Jul 2007 06:52:17 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Y4XCiucqQOZoV00gBOgZyTTEafh/A3Y4eemVDGwt+uwlMV+sJSQ/7y6VkpfvRFzxlzT5noRmlfI8++qxTjp8Z3Y3apwBwITaOKzurrJLN6eUyuwbURBjQI4k1YCzbsIXD9sQ1WvD9nfIflmZvpfipc2cMwJgeVe49udUkC6Pic0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=HZm/MQd30UOhqOy/DOGxkO2mQq6ixdBiKp8V2uvVDg/X+BFTC6Gb43EmrkR/0QJmqhzfgW9qsUGHPBRdjVtOUUmYlWXVppMf79QuzbvxgbAJw+mjguA2nIvRd7A+7ZhI1snsiY3ZoN16iSd7eVZtEjp+WCg/k2WBBAzg4LaFuOg= Original-Received: by 10.82.183.19 with SMTP id g19mr1470225buf.1185112336746; Sun, 22 Jul 2007 06:52:16 -0700 (PDT) Original-Received: by 10.82.117.9 with HTTP; Sun, 22 Jul 2007 06:52:16 -0700 (PDT) In-Reply-To: <874pjwpnoz.fsf@debby.local.net> Content-Disposition: inline X-detected-kernel: Linux 2.6 (newer, 2) X-Mailman-Approved-At: Sun, 22 Jul 2007 12:10:40 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:16200 Archived-At: > Why can't you just use convert? It's needed for the image-dired > thumbs anyway, is it too slow? As I mentioned earlier, jpegtran does lossless rotation, something `convert' cannot do (or could not the last time I checked). The point of the R and L commands are to rotate the original file, it was not intended for rotating the displayed image. The only such command that exist yet is the rotation of the thumbnails. > OK, installed libjpeg-progs and it works now, thanks. But its a bit > awkward since I'm constantly asked whether I'd like to change the > original file and when I decline the rotated display is again > reverted. That is because I designed that command to rotate the original, it was not intended for rotate of the displayed image, for view purposes. That is why you get the confirmation, because it will overwrite the original file. Maybe this was not the best design decision but it was what I wanted/needed when I implemented it. Feel free to write a new command if you like, the code for rotating is there for thumbnails already. > Does it make sense to check the existence of the needed image-magick > and jpegtran executables with the Emacs configure script? `image-dired.el' should make more sanity checks in this area, that is what is missing. I was too lazy to add them... /Mathias