From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#60712: 28.2; customize-set-variable won't let you change the type of a choice Date: Sun, 16 Jul 2023 10:27:39 -0300 Message-ID: <7daa5402-fb93-c6ba-dbd0-829eb1c4caa4@gmail.com> References: <8d7ea0a1-0847-3643-fa8e-7bfe1e066706@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------xNW0CSm05ibMk0btXVoglvDO" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19544"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Omar =?UTF-8?Q?Antol=C3=ADn?= Camarena To: 60712@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 16 15:28:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qL1nJ-0004wx-UF for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jul 2023 15:28:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qL1nA-0000XT-SD; Sun, 16 Jul 2023 09:28:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qL1n9-0000XD-2I for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 09:28:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qL1n8-000619-GS for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 09:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qL1n8-0002oe-77 for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 09:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jul 2023 13:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60712 X-GNU-PR-Package: emacs Original-Received: via spool by 60712-submit@debbugs.gnu.org id=B60712.168951407310801 (code B ref 60712); Sun, 16 Jul 2023 13:28:02 +0000 Original-Received: (at 60712) by debbugs.gnu.org; 16 Jul 2023 13:27:53 +0000 Original-Received: from localhost ([127.0.0.1]:47065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL1my-0002o9-OU for submit@debbugs.gnu.org; Sun, 16 Jul 2023 09:27:53 -0400 Original-Received: from mail-ot1-x334.google.com ([2607:f8b0:4864:20::334]:62692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL1mv-0002no-FZ for 60712@debbugs.gnu.org; Sun, 16 Jul 2023 09:27:50 -0400 Original-Received: by mail-ot1-x334.google.com with SMTP id 46e09a7af769-6b867acbf6dso2851252a34.0 for <60712@debbugs.gnu.org>; Sun, 16 Jul 2023 06:27:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689514063; x=1692106063; h=in-reply-to:references:cc:to:from:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=FGLCGIm7NvalouP37V4Y/5d0+Wh5dEIqje/3aoZJrrc=; b=D1+buyp4MoNQEQK4esePoqKTmGztnOSGF7G4VmvGLhhF+AX6THu6XdEj0iXFGHCSc7 875i+ZJGCYAfwco8njspgKQ3rHy5TA9k5UtOgjEFqYO1IZb/ghwI3jPMphea9AgCVhDP C+gTUKxImF1CKtBhxWajZpCJmWzdfJycFqyvIpZNACkg6lNL74DufGHONX4SqehIIMmg 6rN5Jo/xerWuPAODPnfpN1uSHejeuG+mpHYFwE31Twp10xu5/zGEoFhF65fTtGPdz62F KIMeEF8uYhFlD3pKELOPQu2gRl/q7auuU1zsCOWgiVKEobqlEHP0Wh0n0ZNU/3/4uoJ3 TEQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689514063; x=1692106063; h=in-reply-to:references:cc:to:from:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=FGLCGIm7NvalouP37V4Y/5d0+Wh5dEIqje/3aoZJrrc=; b=UtYaWGtr0xZrMwcTpWdrJDSqyrOJL33F212Mz9r5AVBoNKqgDJf+BfcjbDVB/MY1uq bPnPGVI1G0lIXZQd7zJKi1wGrESvvYAuDGUzr0zXcpYbxNshATKy2W1ouB3TxpSAuV4H d/HniJhoy1rT0k4L++zZau9Edgs5dJtah864t2nSve6O2tTr5xZAsPOv2Nc8DItQxKKL voZbjtWAqVUqMPPYP0xEsgnFEd6r67mZdxUkO39yYb9h6RwmgBkOrzUMoa+eJKKDVULY 7jZcrIoYi6Ss8EAjZXn913sb5KPXhtzcHac2oOCkLD8wsC9o8yMbOo3WQC4Ju5lq4mLQ LfAw== X-Gm-Message-State: ABy/qLb8DHvE98xFAGv7CWUfTsSkm6rZP4iE8kjfhKkVJvn5L6+j+kL1 njb4lv+DqawJ9/S1e3RWxr88m12ffLirPY4/ X-Google-Smtp-Source: APBJJlEwgODfnuvJ7A36sNnMEOXL+saCKcPyJsnfXRTZkiztTQ+EmSzfYLFn7s3clfD2HSTT6QqsmA== X-Received: by 2002:a05:6870:f625:b0:1b7:8957:bfe0 with SMTP id ek37-20020a056870f62500b001b78957bfe0mr4699798oab.20.1689514063350; Sun, 16 Jul 2023 06:27:43 -0700 (PDT) Original-Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id zh27-20020a0568716b9b00b001a663e49523sm6091586oab.36.2023.07.16.06.27.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Jul 2023 06:27:42 -0700 (PDT) Content-Language: en-US In-Reply-To: <8d7ea0a1-0847-3643-fa8e-7bfe1e066706@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265330 Archived-At: This is a multi-part message in MIME format. --------------xNW0CSm05ibMk0btXVoglvDO Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Mauro Aranda writes: > We have this condition in widget-choice-prompt-value: > ((and (= (length args) 2) >       (memq old args)) >  (if (eq old (nth 0 args)) >      (nth 1 args) >    (nth 0 args))) > > ARGS holds the choices available in the choice widget and OLD has > the choice that matches the current value of the choice widget, before > the user enters a new one.  This branch has been in the code since like > forever, but I can't explain why it's good to have it. So, we should respect the value of widget-choice-toggle also when prompting, of course.  I attach a patch to fix it. --------------xNW0CSm05ibMk0btXVoglvDO Content-Type: text/x-patch; charset=UTF-8; name="0001-Don-t-always-toggle-a-choice-when-prompting.patch" Content-Disposition: attachment; filename="0001-Don-t-always-toggle-a-choice-when-prompting.patch" Content-Transfer-Encoding: base64 RnJvbSAxYzk2YzU2ZDYyZDk1MzVkNTBmYWI2NmJiN2I5MTdiZDU2ZTgyM2EzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IFN1biwgMTYgSnVsIDIwMjMgMDk6MjI6MTEgLTAzMDAKU3ViamVjdDog W1BBVENIXSBEb24ndCBhbHdheXMgdG9nZ2xlIGEgY2hvaWNlIHdoZW4gcHJvbXB0aW5nCgoq IGxpc3Avd2lkLWVkaXQuZWwgKHdpZGdldC1jaG9pY2UtcHJvbXB0LXZhbHVlKTogUmVzcGVj dCB0aGUgdmFsdWUKb2Ygd2lkZ2V0LWNob2ljZS10b2dnbGUuICAoQnVnIzYwNzEyKQotLS0K IGxpc3Avd2lkLWVkaXQuZWwgfCAzICsrLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9u cygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3Avd2lkLWVkaXQuZWwgYi9s aXNwL3dpZC1lZGl0LmVsCmluZGV4IDIzNGYzZDliNzRkLi45NmRmZjY5ZTJkZiAxMDA2NDQK LS0tIGEvbGlzcC93aWQtZWRpdC5lbAorKysgYi9saXNwL3dpZC1lZGl0LmVsCkBAIC0zOTg1 LDcgKzM5ODUsOCBAQCB3aWRnZXQtY2hvaWNlLXByb21wdC12YWx1ZQogCQkgbmlsKQogCQko KD0gKGxlbmd0aCBhcmdzKSAxKQogCQkgKG50aCAwIGFyZ3MpKQotCQkoKGFuZCAoPSAobGVu Z3RoIGFyZ3MpIDIpCisgICAgICAgICAgICAgICAgKChhbmQgd2lkZ2V0LWNob2ljZS10b2dn bGUKKyAgICAgICAgICAgICAgICAgICAgICAoPSAobGVuZ3RoIGFyZ3MpIDIpCiAJCSAgICAg IChtZW1xIG9sZCBhcmdzKSkKIAkJIChpZiAoZXEgb2xkIChudGggMCBhcmdzKSkKIAkJICAg ICAobnRoIDEgYXJncykKLS0gCjIuMzQuMQoK --------------xNW0CSm05ibMk0btXVoglvDO--