From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alexander Shukaev Newsgroups: gmane.emacs.bugs Subject: bug#39015: `isearch-complete1' should use `completion-at-point' or `completion-in-region' Date: Tue, 7 Jan 2020 17:19:29 +0100 Message-ID: <7da1738e-1e8a-3c12-31bf-741ee171db5c@Alexander.Shukaev.name> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="48033"; mail-complaints-to="usenet@blaine.gmane.org" To: 39015@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 07 17:20:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ioraW-0008tt-Io for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Jan 2020 17:20:12 +0100 Original-Received: from localhost ([::1]:52460 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ioraV-0006qF-9B for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Jan 2020 11:20:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41070) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ioraN-0006gs-2c for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2020 11:20:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ioraL-0007Vf-UT for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2020 11:20:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43127) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ioraL-0007VV-R9 for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2020 11:20:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ioraL-0002iI-Mq for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2020 11:20:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alexander Shukaev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jan 2020 16:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 39015 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.157841397810392 (code B ref -1); Tue, 07 Jan 2020 16:20:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Jan 2020 16:19:38 +0000 Original-Received: from localhost ([127.0.0.1]:49100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iorZy-0002hY-Kf for submit@debbugs.gnu.org; Tue, 07 Jan 2020 11:19:38 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:54458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iorZw-0002hR-T0 for submit@debbugs.gnu.org; Tue, 07 Jan 2020 11:19:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40785) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iorZv-0005lV-RB for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2020 11:19:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iorZu-0007Ej-Lz for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2020 11:19:35 -0500 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:46995) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iorZu-0007DN-GA for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2020 11:19:34 -0500 X-Originating-IP: 79.134.79.103 Original-Received: from [192.168.0.110] (unknown [79.134.79.103]) (Authenticated sender: forum@alexander.shukaev.name) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id CAAD12000D for ; Tue, 7 Jan 2020 16:19:30 +0000 (UTC) Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:174314 Archived-At: Not sure why in the first place `isearch-complete1' uses some custom auto-completion implementation that is different from a conventional solution, perhaps historical reasons. Thus, I believe that reusing either `completion-at-point' or `completion-in-region' to implement that functionality is much better in the long run. This would also allow packages, which customize completion behavior, to hook into `isearch' auto-completion as well. See also [1] for example. [1] https://github.com/abo-abo/swiper/issues/1882