From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73734: [PATCH] Fix tmm menu layout Date: Fri, 11 Oct 2024 09:29:45 +0200 Message-ID: <7d0904ee-90db-4dcd-b918-cf9d7821923f@gmx.at> References: <87cyk812uv.fsf@ledu-giraud.fr> <86iku00wbz.fsf@gnu.org> Reply-To: martin rudalics Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5362"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 73734@debbugs.gnu.org To: Eli Zaretskii , Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 11 09:31:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1szA7J-000183-Ec for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Oct 2024 09:31:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1szA75-00027Q-E4; Fri, 11 Oct 2024 03:31:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szA6s-00026d-98 for bug-gnu-emacs@gnu.org; Fri, 11 Oct 2024 03:30:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1szA6r-0006Zy-UQ for bug-gnu-emacs@gnu.org; Fri, 11 Oct 2024 03:30:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=KO94jI/pSUh8AsXUFaW+HMunOkWI1COQV7XWhSt5Vf8=; b=qUGtD4JQrS8HEG7N0HB/PlDulMQVcuqs9uuGyBbZI3DXc4F8+H0W9hREmSOt5VFTIErq+tcE1WLRJwVcor/f6KHykfSkA387Ob18iqzLo6cxgy9gRNMi4H8/Pjv38Z+PbIm1ois0HNWb8BGZOfjkGEBPLnitd6D6s0hs0YoQNlANkxGpCf3kLopnj8bnwlgy86vODwNZz4ALPX63z4KVhRL+p7YFeqRs8ZC2fCfUgpyEhUK2BrTM9fI1QDCzfJfkPPdIX/CCWhDj11Rs234Od32ZdQbK5BG75HDFKSsxYqC6zSmWx/ap9Qc3fsW4mFX5uriI0Xu5Vb9QKOgSt0kbMQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1szA74-0000Fn-2V for bug-gnu-emacs@gnu.org; Fri, 11 Oct 2024 03:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Oct 2024 07:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73734 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73734-submit@debbugs.gnu.org id=B73734.1728631817495 (code B ref 73734); Fri, 11 Oct 2024 07:31:02 +0000 Original-Received: (at 73734) by debbugs.gnu.org; 11 Oct 2024 07:30:17 +0000 Original-Received: from localhost ([127.0.0.1]:33281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szA6L-00007f-Ar for submit@debbugs.gnu.org; Fri, 11 Oct 2024 03:30:17 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:49735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szA6F-0008WU-NQ for 73734@debbugs.gnu.org; Fri, 11 Oct 2024 03:30:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1728631792; x=1729236592; i=rudalics@gmx.at; bh=KO94jI/pSUh8AsXUFaW+HMunOkWI1COQV7XWhSt5Vf8=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=FUlmqZjZ/XdI1Xza7Ogl0EOXxCwGbpGjrj6ySfNxzQ7WparTBblDwb0nf7XPQlv+ wvSjR2L4z2JKw0TE8C4THGWrGSGcYXlopf13xyDSUFv5qafhXa1f9dStVZFjPcg+S jo1yHCCjWMr1FOpYm5R1c3Mkw3/LS04LRrLG56UDpeNZ24YjVp/wGWO52krgQMmAP 1WGJ9EVSbFycSWOzwQbdWFpnkRkVGB4c2sH1v6wDqSx4smslbFnWM4qQIIDEzkzyi WyCTA2k6Hzy1mrw0QFfSHxqz4zSpeWUo5nx5uYuf6dbaHS+m6XK8c8GB1b2/1Pu9J DlTW41/vPxu6rWJK5w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from [192.168.31.113] ([46.125.249.110]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N7zFj-1u3mzr1gYN-00zgbM; Fri, 11 Oct 2024 09:29:52 +0200 Content-Language: en-US In-Reply-To: <86iku00wbz.fsf@gnu.org> X-Provags-ID: V03:K1:4lb4V00NBd62rWi8EBg5OOVffMPBHyPTymqLPSBSBIueGR0TzIQ +jzZvSljjLL6k/DfQuL/BFOUD0LgHgQEjzOwnqlY+gME3SznXSK3h3/jBIKhZNRhCNencEJ DgDQiT3/beEWNPqkXTBT0G7cNDfu4ajLilt9vLGOehvDITI2nyQh0m7QfvppBj2p8S7nhuZ CK1vSBbsMAbUAz3q8RYcg== UI-OutboundReport: notjunk:1;M01:P0:7JyTzjEqRLA=;4M6lL5wMZTdPO1TwW0dWBraCClo NdYhDcL09mmy++A5eMccQlsPlPoqsRD5rwN4aFdh3ESjiAFIf8M1i9H/uoLtLZOcHTfoG6+HH xyBIpZMPJZMBDKKTVRA07oYmfFYzwuvVIKIQjixslSUqWaEuXAxIMmEBdf1O63It4YD2dPbw1 seFg+LHvPeyERBGQ9oLPL+OeTesaaIh493dS4r60gXmJlCIiIznA4nS0w5di+VWgnY4lyw6I2 RSEk4WjNozlwjvCTJP0CwUhx7V1Ej//2JHY4I4EkdrJ9H9dzkBRj67kpo1y2I6/ZhZzLpmL9m Tk0l63lRdYLoEN1a75/667GDb+kCGlWX3Q6StEBANm6sq+foa1W7xa+EAg3D8pS1PCtF1FruG R1g7hmQldoXbOsref6VZECC6vvFX53MMJrQW5RFlw55iApJWgI/16QfnNDkhNIV5ZpUkXQF9O EiZvmCOEsrK62LBDh0jLCcnjQxf70J/NKzw6IzWFVZjQ3uDdc7weEXj1NNBr6WpV/CfksL+hF DqVl1EkK6yhu/1fMPu8HnHxAs3sAvXrn4lF1sy/4kqaHyLsYQNKKBnm2i2UEWZcGYWD3pypuC MWmFM3uTOzWRgB+l/S3JP8PLeYma8iKrpWMfJZF3QxUVi7dydIXuQHPozMjQdFmFurTLsYLRM mn3BDRaRG0fFfGkFrPSt1Fq5guufImsszm64X60hheDZieuqkAb5wSFErow+TOogpkXIaj9Ez PythheY1roGFV6HX7O6e6Bq5iE+CwyaKU7a52krBoc6mROJbUxNaUDtucLV/UdbN8cBKrmQ+ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293340 Archived-At: >> Here, how I justify the modification of `colwidth': >> >> - I don't think we need the "(min 30)" part since, if the frame is >> wide enough, we always get a colwidth of 30. >> >> - I don't think "(window-width)" is what we need since, by >> default, the *Completions* buffer will use the full frame width. > > Martin, is that guaranteed? I don't think so. At least we should check whether the buffer window of the *Completions* buffer satisfies the 'window-full-width-p' predicate. But (window-width) which, as Manuel later remarks, returns the width of the selected window, does look like a bad choice here. I'm not familiar with tmm.el but would (window-width (get-buffer-window "*Completions*")) be wrong here? martin