From: martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>, Manuel Giraud <manuel@ledu-giraud.fr>
Cc: 73734@debbugs.gnu.org
Subject: bug#73734: [PATCH] Fix tmm menu layout
Date: Fri, 11 Oct 2024 09:29:45 +0200 [thread overview]
Message-ID: <7d0904ee-90db-4dcd-b918-cf9d7821923f@gmx.at> (raw)
In-Reply-To: <86iku00wbz.fsf@gnu.org>
>> Here, how I justify the modification of `colwidth':
>>
>> - I don't think we need the "(min 30)" part since, if the frame is
>> wide enough, we always get a colwidth of 30.
>>
>> - I don't think "(window-width)" is what we need since, by
>> default, the *Completions* buffer will use the full frame width.
>
> Martin, is that guaranteed?
I don't think so. At least we should check whether the buffer window of
the *Completions* buffer satisfies the 'window-full-width-p' predicate.
But (window-width) which, as Manuel later remarks, returns the width of
the selected window, does look like a bad choice here. I'm not familiar
with tmm.el but would
(window-width (get-buffer-window "*Completions*"))
be wrong here?
martin
next prev parent reply other threads:[~2024-10-11 7:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 13:53 bug#73734: [PATCH] Fix tmm menu layout Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-10 16:14 ` Eli Zaretskii
2024-10-10 18:00 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-10 18:29 ` Eli Zaretskii
2024-10-11 6:37 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 6:51 ` Eli Zaretskii
2024-10-11 7:45 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 8:10 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 9:26 ` Eli Zaretskii
2024-10-11 10:45 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 16:44 ` Eli Zaretskii
2024-10-12 14:10 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-12 14:44 ` Eli Zaretskii
2024-10-12 15:56 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-12 16:26 ` Eli Zaretskii
2024-10-12 16:40 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-15 8:37 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-15 9:46 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 7:29 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-10-11 7:48 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 8:15 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-11 9:19 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d0904ee-90db-4dcd-b918-cf9d7821923f@gmx.at \
--to=bug-gnu-emacs@gnu.org \
--cc=73734@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=manuel@ledu-giraud.fr \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).