From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#13521: `sort-lines' on the empty region Date: Sat, 5 Sep 2020 08:22:58 -0700 (PDT) Message-ID: <7cfc062e-05b2-43f1-8714-19ebd955b88c@default> References: <<<20130122085354.75ced82538551655e724e0ea@gmail.com>>> <<>> <<>> <<>> <<>> <<<83mu2objro.fsf@gnu.org>>> <<>> <<<83imdcbgc5.fsf@gnu.org>>> <<>> <<<83imcspim8.fsf@gnu.org>>> <<3aad96d8-2503-40e8-b684-8ed18a089083@default>> <<83a6y4p98g.fsf@gnu.org>> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23301"; mail-complaints-to="usenet@ciao.gmane.io" Cc: xfq.free@gmail.com, rgm@gnu.org, stefan@marxist.se, monnier@iro.umontreal.ca, 13521@debbugs.gnu.org To: Eli Zaretskii , Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 05 17:26:23 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEa58-0005v9-6q for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 17:26:22 +0200 Original-Received: from localhost ([::1]:49482 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEa57-0001Xr-6m for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 11:26:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43534) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEa4o-0001Wt-LM for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 11:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60550) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEa4o-0003Q8-Cj for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 11:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEa4o-0004UP-4V for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 11:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Sep 2020 15:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13521 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13521-submit@debbugs.gnu.org id=B13521.159931951017197 (code B ref 13521); Sat, 05 Sep 2020 15:26:02 +0000 Original-Received: (at 13521) by debbugs.gnu.org; 5 Sep 2020 15:25:10 +0000 Original-Received: from localhost ([127.0.0.1]:43863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEa3y-0004TJ-Dp for submit@debbugs.gnu.org; Sat, 05 Sep 2020 11:25:10 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:54644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEa3w-0004T1-EC for 13521@debbugs.gnu.org; Sat, 05 Sep 2020 11:25:08 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 085FOlXB078403; Sat, 5 Sep 2020 15:25:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=jDm1e5/DV5JLWnSPrjm1q1JOqTl/s6yxJdfEBKqIFDw=; b=v6NupHPR9TRsjDnHXvGPBvBKR8I6vJ7epYD3J/tuhYNPFpExMETf7CSKvZKLViG0bNdJ x1FOx+uB2YvPfD6DLKdcC+yGX4XjsW1rMIGTwzHyHLeK+28Q0JWsCMaNwb6kn4qr4Buj aQH/6m+0QPM9IWNPXyFQKAGfik8m/iqy8Jh09QImkyg4tTA5o1rqitFsH5QzpxIXJyEa gr8qD7orzIzS7PCRmJuWXq48ZDlkIvpCjpsEgfIrb6zADlsAnasD1lSiGArfqQfQbK3k CiS2N0aH8uTLWOIRjCyZLrPMTHEQi3VLr96XlpUhhphRRhC91neRWkg1HKlLFJh1lt4B rQ== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 33c2mkhccc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 05 Sep 2020 15:25:02 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 085FG1l6116005; Sat, 5 Sep 2020 15:23:01 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 33bysqu5te-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 05 Sep 2020 15:23:01 +0000 Original-Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 085FMxZV018615; Sat, 5 Sep 2020 15:23:00 GMT In-Reply-To: <<83a6y4p98g.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5044.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9735 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 mlxscore=0 bulkscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009050148 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9735 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 priorityscore=1501 phishscore=0 adultscore=0 bulkscore=0 clxscore=1015 mlxlogscore=999 malwarescore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009050149 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187262 Archived-At: > > I doubt that someone who has `transient-mark-mode' off > > would ever want commands such as `flush-lines' and > > `sort-lines' to act on the region. And if they did, I > > expect they'd just narrow to it. >=20 > Please don't doubt, and please don't impose unnecessary commands on > users who have transient-mark-mode off. Please don't claim that I imposed any commands on anyone. The region is nearly always present and usually nonempty. A user with `transient-mark-mode' off would typically (IMHO) be bothered if `flush-lines' started always acting on the region (it would be almost always: whenever there's a mark in the buffer and the region is nonempty).=20 Do you disagree? > > Anything that works on "the active region" is something > > that makes sense only when `transient-mark-mode' is on > > (IMHO). >=20 > The important point here is that sort-lines worked on the region, even > if inactive, before the proposed changes, so restricting it now only > to active regions would be a backward-incompatible change of behavior. Yes, sorry; I agree about `sort-lines'. That is not the case for `flush-lines' and `keep-lines'. And I think "the important point here" is that a command that behaves differently when the region is active should NOT act on the region when `transient-mark-mode' is off. Why? Because the notion of "active region" applies only when `transient-mark-mode' is on. Any special behavior provided only when the region is active is, well, only for when the region is active. And that's never the case when `transient-mark-mode' is on. This was not the case for `sort-lines', as you point out. It did NOT, and does not, behave differently when the region is active from when it is inactive.