From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#72824: Eglot highlights matches incorrectly wrt case sensitivity Date: Wed, 28 Aug 2024 01:57:21 +0300 Message-ID: <7cf49afe-e52f-471c-942d-72a0a39d0905@gutov.dev> References: <05924929-997f-4d37-ba3b-a4620a687c03@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38802"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 72824@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 28 00:58:34 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sj58x-0009sX-O2 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Aug 2024 00:58:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sj58d-0004mq-5q; Tue, 27 Aug 2024 18:58:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sj58b-0004mf-IK for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2024 18:58:09 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sj58b-0006zT-95 for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2024 18:58:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=8VaaWtikJo6YKUyQSPUJpLnA8KfjX7QAWG1HPZCu/oc=; b=uFRbNxuOC0G0vNq4JZoHrwy1iTSE7fP571VikfUBaHqU5T4HWwYX2yQyZWKUmMbZpDn446cDw0yc+edu58vmN2nDveSlXtv55vevOEHDb36oH33pqbaktiWpeWjMFDBkROmu6DyCYTUq6S4ghjVvPG88P1+5CPte0kB/35mN/fPdw7GBeQH5pyCiikBkyu4CuD6ns2uu4Mk1Nld58fOGsnnXizS/4uACUf4fZtL56Q2a16d9p9KLPRzXOta9jptvZCMp+c51dnNbz8PODLt+OZMVa6xU1jE9nA9fOr7jlLvVhFoOVuJn8U6GtnXB5HKUKC3YTCXQ+j+xvdlWsJ1sEQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sj59S-0004Qm-0b for bug-gnu-emacs@gnu.org; Tue, 27 Aug 2024 18:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Aug 2024 22:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72824 X-GNU-PR-Package: emacs Original-Received: via spool by 72824-submit@debbugs.gnu.org id=B72824.172479950816969 (code B ref 72824); Tue, 27 Aug 2024 22:59:01 +0000 Original-Received: (at 72824) by debbugs.gnu.org; 27 Aug 2024 22:58:28 +0000 Original-Received: from localhost ([127.0.0.1]:47745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sj58u-0004Pc-1d for submit@debbugs.gnu.org; Tue, 27 Aug 2024 18:58:28 -0400 Original-Received: from fhigh6-smtp.messagingengine.com ([103.168.172.157]:48985) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sj58r-0004PK-Kj for 72824@debbugs.gnu.org; Tue, 27 Aug 2024 18:58:27 -0400 Original-Received: from phl-compute-06.internal (phl-compute-06.nyi.internal [10.202.2.46]) by mailfhigh.nyi.internal (Postfix) with ESMTP id EC8BB1151A5E; Tue, 27 Aug 2024 18:57:26 -0400 (EDT) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Tue, 27 Aug 2024 18:57:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1724799446; x=1724885846; bh=8VaaWtikJo6YKUyQSPUJpLnA8KfjX7QAWG1HPZCu/oc=; b= WhKfze7HQWFRMeUVFubeltG0xve5wn4+q2thxD+hpApfUqER8GB1SNSvpQBcsQCy Hl2VXV379fM6eh7tAuXNLZpaH85Z0aFtSqoZ+/ZTDsxBaDP4+thsqtjRLX+/WIrH 41yeM9iB04KB1T+S+L6whodvx0hzpkcssIM19g9eO5ByAS1/IOUmFhlTfp0trw5b eupI8HsObqPc21o3+4FCXX7ir8AUPf6DWoE8zwuuSo+Ce4Q38MlKZ/rRoMliE0I8 xcvGXj7l9IfVhBZdX+J/DmT+8EC+Wut4ainBoePRkdXitTlT8S2dbDaENLG6yZdH HXVgBSsA9Tn2P/2SvX+BEw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1724799446; x= 1724885846; bh=8VaaWtikJo6YKUyQSPUJpLnA8KfjX7QAWG1HPZCu/oc=; b=L Fj8n7loEPvrW9ZV3Pbb50VU6excza37xUxA7bga2MtvAYpkEpRY/R61lC1aNUlb8 QcTI869XXWjsEe0BZUcBi4jAmPtp26eJGsioiv/GJ54vkp7O5I9V2SnJn+cmzBAo QDFD3E+fDQheLpKqt6kOjRJSkklzA3xDTfqSS4FdwUB4LkEbdVel7y2y2Id+FYBC w3Iag0cWjyUeoE/wmiO4iVjKBPS9csbDTZxK/gv5CbQkbkz4Dem6XpXmh4ziSFNV yfkNSs64JgU0Z4j3FTLkce5mE6mySvvKaWz9FKJc4hUvm1PywlnI4RaGfFFum+hj E8z4OPstWyBujjPA6U02w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudefuddgudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtvdej necuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdrug gvvheqnecuggftrfgrthhtvghrnhepgeelfeetkefghfdvhfdtgeevveevteetgeetveeg tedthefhudekteehffeukeeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghvpdhnsggprhgtphhtthho pedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehjohgrohhtrghvohhrrgesgh hmrghilhdrtghomhdprhgtphhtthhopeejvdekvdegseguvggssghughhsrdhgnhhurdho rhhg X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 27 Aug 2024 18:57:24 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290842 Archived-At: On 27/08/2024 17:38, João Távora wrote: > Also, btw, completion highlighting is naturally borked too. There is > no guarantee that that naive flex algorithm is what the server used > to select those completions. True. For example, tn this scenario the server uses case-insensitive matching, whereas we (by default) match case-sensitively in the completion style. This change should help eliminate the inconsistency between parts of the current completion style, but for the next release we might migrate to a more "passthrough" one. Or not, you know. I've seen users request prefix-only matching instead of the fuzzy one provided by the language servers, and I'm sure there will be ones who prefer to match case-sensitively only too.