From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric?= Giquel via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60467: New problem introduced Date: Thu, 22 Jun 2023 21:28:44 +0200 Message-ID: <7ccb0e8131f84ca2ea0f0c0aed11dc197b578a64.camel@laposte.net> References: <87o7ri74qv.fsf@localhost> Reply-To: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric?= Giquel Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6395"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.48.2-1 To: 60467@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 22 21:29:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qCPzl-0001Vy-B8 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Jun 2023 21:29:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qCPzN-00052J-RL; Thu, 22 Jun 2023 15:29:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCPzK-00051u-8i for bug-gnu-emacs@gnu.org; Thu, 22 Jun 2023 15:29:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qCPzJ-0007EB-WD for bug-gnu-emacs@gnu.org; Thu, 22 Jun 2023 15:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qCPzJ-0003PT-Sl for bug-gnu-emacs@gnu.org; Thu, 22 Jun 2023 15:29:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87o7ri74qv.fsf@localhost> Resent-From: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric?= Giquel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Jun 2023 19:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60467 X-GNU-PR-Package: emacs Original-Received: via spool by 60467-submit@debbugs.gnu.org id=B60467.168746213513094 (code B ref 60467); Thu, 22 Jun 2023 19:29:01 +0000 Original-Received: (at 60467) by debbugs.gnu.org; 22 Jun 2023 19:28:55 +0000 Original-Received: from localhost ([127.0.0.1]:36793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCPzD-0003P8-Hm for submit@debbugs.gnu.org; Thu, 22 Jun 2023 15:28:55 -0400 Original-Received: from smtp-outgoing-1902.laposte.net ([160.92.124.106]:52227) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCPzB-0003Ou-J5 for 60467@debbugs.gnu.org; Thu, 22 Jun 2023 15:28:54 -0400 X-mail-filterd: {"version":"1.7.1","queueID":"4Qn9Qh66bwzjWvm","contextId": "5939c14b-053a-4a89-af1b-90f5ab87de82"} Original-Received: from outgoing-mail.laposte.net (localhost.localdomain [127.0.0.1]) by mlpnf0116.laposte.net (SMTP Server) with ESMTP id 4Qn9Qh66bwzjWvm for <60467@debbugs.gnu.org>; Thu, 22 Jun 2023 21:28:44 +0200 (CEST) X-mail-filterd: {"version":"1.7.1","queueID":"4Qn9Qh5MHSzjWvW","contextId": "ed85b675-c5ab-4a9b-8f89-e2cacc288935"} X-lpn-mailing: LEGIT X-lpn-spamrating: 40 X-lpn-spamlevel: not-spam Original-Received: from [192.168.29.56] (82-64-20-182.subs.proxad.net [82.64.20.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mlpnf0116.laposte.net (SMTP Server) with ESMTPSA id 4Qn9Qh5MHSzjWvW for <60467@debbugs.gnu.org>; Thu, 22 Jun 2023 21:28:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=laposte.net; s=lpn-wlmd; t=1687462127; bh=apRc0TnfKyc4XT4gGHbgl3TTy7kQcZOV6i0AzgWnt5U=; h=Message-ID:Subject:From:To:Date:Content-Type:Content-Transfer-Encoding:MIME-Version; b=ebNR2/DrIsiWpr5bFan7ZiLfLQuhs1QAbD9EphXgz9RbR/84eT16vzia0I5eHjkiwg/ysOMbNyZyXfSQYESoBQh0qlDmHbwi9hlzdjWdP1eG1L7yAqszVQ31Hj2Mk6yfPAMDNjQYVAjrY70sjbQartN+x1/qBjYF9AUjlLokysnDOvlDLXwnc3UYS5N7kYqKi7Lli1ySg3a9vKPQc664gMbqzt9igwXPMYqzkfoa5+DsuNOPzim5CWf7AL/Qx88FA0nZx9MEEUaa02+ysvZbb1vbTqD4xF8PDMruAoGrapYE7gdyN9uRBnGAT0lqKRIDt/Id3hqEJp5d4I+CEQoutw==; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263917 Archived-At: Hi all, I'm reopening this bug because the fix has introduced a new problem. This can be highlighted with the following procedure (verified with Emacs 29.0.92) : 1. Open a file: emacs -Q 2. Move point to a line you can comment 3. M-x comment-line 4. M-x undo 5. Check buffer modification status in modeline or use (buffer- modified-p) Without the patched version of combine-change-calls-1, the buffer status is "not modified since last save". Same result if you use another command, for example kill-line, at step 2. With new version of combine-change-calls-1, the buffer is seen as modified. I'm not sure but I imagine it has something to do with the lack of timestamp in buffer-undo-list created by combine-change-calls-1.