From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#39185: [PATCH] Don't include section "Recent messages" in bug reports Date: Sat, 18 Jan 2020 18:21:05 -0800 (PST) Message-ID: <7c4de596-6e2e-48e9-a187-e16a36c59176@default> References: <87y2u4uxk5.fsf@marxist.se> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="38193"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Kangas , 39185@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 19 03:22:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1it0E7-0009nG-3U for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Jan 2020 03:22:11 +0100 Original-Received: from localhost ([::1]:46880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1it0E5-0006dm-Q5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Jan 2020 21:22:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53141) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1it0Dz-0006YB-Ah for bug-gnu-emacs@gnu.org; Sat, 18 Jan 2020 21:22:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1it0Dy-0002bn-2G for bug-gnu-emacs@gnu.org; Sat, 18 Jan 2020 21:22:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36575) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1it0Dx-0002bW-Ul for bug-gnu-emacs@gnu.org; Sat, 18 Jan 2020 21:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1it0Dx-0004lx-Pm for bug-gnu-emacs@gnu.org; Sat, 18 Jan 2020 21:22:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Jan 2020 02:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39185 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39185-submit@debbugs.gnu.org id=B39185.157940047618292 (code B ref 39185); Sun, 19 Jan 2020 02:22:01 +0000 Original-Received: (at 39185) by debbugs.gnu.org; 19 Jan 2020 02:21:16 +0000 Original-Received: from localhost ([127.0.0.1]:42548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1it0DE-0004kw-0U for submit@debbugs.gnu.org; Sat, 18 Jan 2020 21:21:16 -0500 Original-Received: from userp2120.oracle.com ([156.151.31.85]:38392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1it0DB-0004ki-Ia for 39185@debbugs.gnu.org; Sat, 18 Jan 2020 21:21:14 -0500 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00J2KT1l002934; Sun, 19 Jan 2020 02:21:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=mrtLpbGlBf0J/DN/SivMlZVyKG+Bgl1ZISr5feEIQgE=; b=UyE0ySpW7YgcRJU6xTccDKMcwI3+WAro/kyJaAOeLDS/LH4coyQizMd33SGUnR5qbYct mhRf1Dtp8yTFMiz14UeISnLKCkK0nT2FlbovvHTLzgKFggyked7O5t8mMDo3AC+CX6VA z6wNlZiCRnOFaKJwhjVy+T4nNuholMKA780wHgqLhHJu03BOE398cdhk6gSr5OaUnM4O /8K9STcUKsx8pVmfuDoUo2OD0t7N/LlpHOysdti3Z7ncZGY3bmhX78wXITGr8hZ9A7mE HXGf+Lno6y1Un85wS4j4YaqteYE3J0pdoFbtEXjpDRqNRMpOXeqQmAC21KuMnmwF3g40 rQ== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2xktnqt5en-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 19 Jan 2020 02:21:07 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00J2JAaD145118; Sun, 19 Jan 2020 02:21:07 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 2xmbg65118-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 19 Jan 2020 02:21:07 +0000 Original-Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 00J2L6AM001225; Sun, 19 Jan 2020 02:21:06 GMT In-Reply-To: <87y2u4uxk5.fsf@marxist.se> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4954.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9504 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001190016 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9504 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001190016 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174850 Archived-At: > Does anyone object to installing the below patch on master? I do. What if a user wants to include that info in a particular bug report, e.g., where it's relevant? Why not make it easy for a user to include it, even if by default it's excluded? As I made clear in the thread you cite: It's not just about "Recent messages". It's about anything we automatically insert into the report, which a user might not pay attention to, or even if she does, which she might not want to send. Let users decide. A simple option takes care of this. And separating the parts of the code that insert each different part of the automatic info means that we can also give users commands to insert any of them as one-offs, to override their chosen default preferred behavior. I see no reason why we wouldn't want to let users decide, in this regard - whether it's about privacy or any other reason a user might have for her preference. What's the difficulty or downside to doing this? I agree with not including recent messages by default. My suggestion is to make it easy for a user to: 1. Include/exclude any of the various parts that we currently exclude, by setting their own preferred default behavior. 2. Make it easy for a user to include/exclude any such parts for any given bug report, i.e., to include/exclude something different from what they choose as their default preference. Anything you do in a hard-coded way makes it more difficult for users. It's good for Emacs to remove recent messages _by default_. It's better to go further and make it easy for users to get the behavior they want - generally and for any given message. And it's simple to do. And it makes the Emacs code more modular - separate pieces handled separately. I don't see a downside, and AFAICT none was shown. I don't claim that the code I use for this, or what I suggest as the approach, is the only good one. I do think we can easily, and should, do better than just remove recent messages.