unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Stefan Kangas <stefan@marxist.se>, 39185@debbugs.gnu.org
Subject: bug#39185: [PATCH] Don't include section "Recent messages" in bug reports
Date: Sat, 18 Jan 2020 18:21:05 -0800 (PST)	[thread overview]
Message-ID: <7c4de596-6e2e-48e9-a187-e16a36c59176@default> (raw)
In-Reply-To: <87y2u4uxk5.fsf@marxist.se>

> Does anyone object to installing the below patch on master?

I do.  What if a user wants to include that info in a
particular bug report, e.g., where it's relevant?
Why not make it easy for a user to include it, even
if by default it's excluded?

As I made clear in the thread you cite:

 It's not just about "Recent messages".  It's about
 anything we automatically insert into the report,
 which a user might not pay attention to, or even if
 she does, which she might not want to send.

 Let users decide.  A simple option takes care of
 this.  And separating the parts of the code that
 insert each different part of the automatic info
 means that we can also give users commands to
 insert any of them as one-offs, to override their
 chosen default preferred behavior.

 I see no reason why we wouldn't want to let users
 decide, in this regard - whether it's about privacy
 or any other reason a user might have for her
 preference.

 What's the difficulty or downside to doing this?

I agree with not including recent messages by
default.  My suggestion is to make it easy for a
user to:

1. Include/exclude any of the various parts that
   we currently exclude, by setting their own
   preferred default behavior.

2. Make it easy for a user to include/exclude any
   such parts for any given bug report, i.e., to
   include/exclude something different from what
   they choose as their default preference.

Anything you do in a hard-coded way makes it more
difficult for users.  It's good for Emacs to remove
recent messages _by default_.  It's better to go
further and make it easy for users to get the
behavior they want - generally and for any given
message.

And it's simple to do.  And it makes the Emacs code
more modular - separate pieces handled separately.

I don't see a downside, and AFAICT none was shown.

I don't claim that the code I use for this, or
what I suggest as the approach, is the only good
one.  I do think we can easily, and should, do
better than just remove recent messages.





  reply	other threads:[~2020-01-19  2:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-18 23:58 bug#39185: [PATCH] Don't include section "Recent messages" in bug reports Stefan Kangas
2020-01-19  2:21 ` Drew Adams [this message]
2020-01-19  2:39   ` Stefan Kangas
2020-01-19 15:13     ` Eli Zaretskii
2020-01-19 15:27       ` Stefan Kangas
2020-01-19 15:49         ` Eli Zaretskii
2020-01-19 16:07           ` Lars Ingebrigtsen
2020-01-19 16:43             ` Eli Zaretskii
2020-01-19 16:47               ` Lars Ingebrigtsen
2020-01-19 17:10                 ` Stefan Kangas
2020-01-19 19:20                   ` Drew Adams
2020-01-20 12:33               ` Dmitry Gutov
2020-08-18 16:11           ` Lars Ingebrigtsen
2020-08-18 16:31             ` Eli Zaretskii
2020-08-18 18:16               ` Lars Ingebrigtsen
2020-01-19 19:24     ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c4de596-6e2e-48e9-a187-e16a36c59176@default \
    --to=drew.adams@oracle.com \
    --cc=39185@debbugs.gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).