From: Dmitry Gutov <dmitry@gutov.dev>
To: Federico Beffa <federico.beffa@fbengineering.ch>,
73500-done@debbugs.gnu.org
Subject: bug#73500: eglot: diagnostic location not always shown
Date: Tue, 1 Oct 2024 23:39:24 +0300 [thread overview]
Message-ID: <7c42a6a8-37e0-443c-b6ef-e1e321c1cb2b@gutov.dev> (raw)
In-Reply-To: <8f4a5079-4f29-450b-97b0-fde41dfa052d@fbengineering.ch>
On 01/10/2024 23:18, Federico Beffa wrote:
> On 01/10/2024 21:48, Dmitry Gutov wrote:
>> That one is using the face eglot-diagnostic-tag-unnecessary-face,
>> which you can customize to add an underline or any other decorations.
>>
>> It was added in commit 0f44d338f17bd4, see the description here
>> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=0f44d338f17bd4
>>
>> The choice of using 'shadow' is explained with a reference to the
>> protocol, which says:
>>
>> /**
>> * Unused or unnecessary code.
>> *
>> * Clients are allowed to render diagnostics with this tag faded out
>> * instead of having an error squiggle.
>> */
>>
>> https://microsoft.github.io/language-server-protocol/specifications/
>> lsp/3.17/specification/#diagnosticTag
>>
>
> OK, I see, the shadow is so similar the normal font that, before you
> mentioned it, it was unnoticeable to me. But if it's customizable,
> that's great.
Yep. I suggest customizing 'shadow' itself then, if it's not noticeable
enough on your system/theme/etc.
>> > Here a screenshot
>>
>> Same look on my machine.
>>
>> Should we remove the exclamation point instead, to avoid the semantic
>> conflict? I'm not sure, probably not.
>
> Is the exclamation mark used with all warnings? If yes, I'd keep it.
> Even if the warning has a tag equal to 1, it's still a warning.
It is. Sure.
> Thanks for your help!
No problem! Guess we're finished here, so I'm closing the report.
prev parent reply other threads:[~2024-10-01 20:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 13:49 bug#73500: eglot: diagnostic location not always shown Federico Beffa via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-28 11:16 ` Eli Zaretskii
2024-09-28 11:47 ` João Távora
2024-09-28 15:23 ` Federico Beffa via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-28 21:18 ` João Távora
[not found] ` <452a24b1-14e8-40a6-b921-a26522278a82@fbengineering.ch>
2024-09-29 17:20 ` João Távora
2024-09-29 18:59 ` Federico Beffa via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-29 21:18 ` João Távora
2024-09-30 9:19 ` Federico Beffa via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-30 9:41 ` João Távora
[not found] ` <bee5efd8-c015-43d1-b37d-392d4ffc08d7@fbengineering.ch>
[not found] ` <CALDnm501CMXD8x_9s6Hm0fD5_+K4wmH58t7wXf5buKDuU+=vGg@mail.gmail.com>
2024-09-30 12:08 ` Federico Beffa via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-30 15:32 ` João Távora
2024-09-30 15:45 ` Federico Beffa
2024-10-01 16:08 ` Dmitry Gutov
2024-10-01 16:32 ` Federico Beffa via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-01 19:48 ` Dmitry Gutov
2024-10-01 20:18 ` Federico Beffa via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-01 20:39 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c42a6a8-37e0-443c-b6ef-e1e321c1cb2b@gutov.dev \
--to=dmitry@gutov.dev \
--cc=73500-done@debbugs.gnu.org \
--cc=federico.beffa@fbengineering.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).