From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#51062: Customizable window resizing Date: Tue, 4 Jan 2022 11:27:11 +0100 Message-ID: <7c39d839-3405-dad3-4e45-90152744e48f@gmx.at> References: <87zgrm2h6v.fsf@mail.linkov.net> <63433373-a57b-a68a-8ccc-6d4a9192d9a4@gmx.at> <871r4oahjx.fsf@mail.linkov.net> <87wnmfk40w.fsf@mail.linkov.net> <87a6jbil4d.fsf@mail.linkov.net> <87o87mmjth.fsf@mail.linkov.net> <377a69a2-7694-bd7a-ac63-409e5064e5c9@gmx.at> <86czlf1fv8.fsf@mail.linkov.net> <3c447b7e-7ce3-14fe-03d5-63cb7f75d783@gmx.at> <86bl0rgas3.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28848"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51062@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 04 11:28:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n4h36-0007MC-Jp for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Jan 2022 11:28:12 +0100 Original-Received: from localhost ([::1]:36370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n4h35-0003aB-KN for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Jan 2022 05:28:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50412) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4h2w-0003XW-Jj for bug-gnu-emacs@gnu.org; Tue, 04 Jan 2022 05:28:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53739) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n4h2w-000135-9N for bug-gnu-emacs@gnu.org; Tue, 04 Jan 2022 05:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n4h2w-0002Og-6Y for bug-gnu-emacs@gnu.org; Tue, 04 Jan 2022 05:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Jan 2022 10:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51062-submit@debbugs.gnu.org id=B51062.16412920429146 (code B ref 51062); Tue, 04 Jan 2022 10:28:02 +0000 Original-Received: (at 51062) by debbugs.gnu.org; 4 Jan 2022 10:27:22 +0000 Original-Received: from localhost ([127.0.0.1]:37049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4h2I-0002NS-3M for submit@debbugs.gnu.org; Tue, 04 Jan 2022 05:27:22 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:38215) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4h2E-0002ND-N3 for 51062@debbugs.gnu.org; Tue, 04 Jan 2022 05:27:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1641292032; bh=7XKF8gvBFgTcs2mcwL5h4jzZbs5vemAr5/Z/cr1LZHo=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Hhl18c/D8LCWByW1cWvepNZKEbpQJil68cNT8J0ZN0KVpoJwnlQIQVkweqzA8YWay vbVLc+qbDBFZ1o3Od8bNi50JO5dbV9oKzjmKixUdIcQol0e4AyOYN2jg3xmwyUaeDD kd15Q3oRrUolpkkL5m1DP17BmSTTWGWcmTz95SdU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.101] ([212.95.5.171]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M1Ygt-1n7jAp1wXj-00376S; Tue, 04 Jan 2022 11:27:12 +0100 In-Reply-To: <86bl0rgas3.fsf@mail.linkov.net> Content-Language: en-US X-Provags-ID: V03:K1:SnKYaBid2eLIXaep9u97kil0Y1AnVQ9K2bqpdOrZDIimPQQwTk0 ME8Yaj7M0fSzONAuy+V4qW2Gum8oOP+OE/QOxAKoR5obPaJBWfEjGgZGm65ujnuFXDo3Yd3 wwgiAm+DTrlfK5hto3X7vKS7JvG/bmSBpKln55TtxF7kE54E9qLbx/QlOrixTWRihUoLRNi tD7nWBS7C8wmrc1kHoo1g== X-UI-Out-Filterresults: notjunk:1;V03:K0:/YYQlxPveRI=:PXykWRQE4/4OJC5X6Bc/MK PEAAdGd7xOo06/q1mRfunhzPk3Oko+FLPSh7nK5uHf/Lh5LTggM5Ua/F5DA7L5Y+kFcCgiHJU DNhw8QiPusXAM7rxO5phAHo4NqVfP0zX18gjBrUMA1p6aNJPP7nL+zIft17zaN9e6TMmsTeYD RIctu6lz0tW7286Gx09lS4YxU8VYZywEpx9bgyHrm8FFu8SRlFIKp6KFWij8Jz6pZIXE1vQJd IdNnaj7czAk43ydrStrziYwKeQfAJryDfuGEEx+/EMiFqoTudg6O/q3nJa4agz9UurwrPWvog faruW6O/T11yIxNeI1aec9IFlZ9U743SfGYD5/GClateHbmH2dxXLJ+h3vQDrpPmDUQ+iN8bz dKixMgZ9tNDEtaeMC2kWBx0aNqyIcltJf5x9PaZ1dSPla5zKzcVcNBPoddWjeKPrqKlwOEkU7 2R86Y9hwfBPrnbVve+UqKmM9yqIP/cYzdrk2qxjGS98uRsyR+Dm/sbL9JXznt0XHgavY7qC3L TtUQIHSFR/QRaCKWje7C1c3S38kWX/qxkdg6qAeyKDHOFo326rK+EM79LUbI2tb/I7eVVng46 WlbDoNS2X/KKFb7P2m3FJljpCquewzzcYfOa8ONgyozBYrNbjPy8Qhm9zCcu3iI+59Fv11zrk GzN22GjVUF20mjchdylyT7KOFEIioVkWcjJXBSQU4fzyIQuD/6Qm7ofahfBMdBuOJc5tbB911 rNg5IL2Bcg0TFQnCy72LmAgnJhiZkiwgTa1d3s2eVzDrvLIaYITEhYwdCz3dCLC+QfvUeAO9 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223637 Archived-At: >> "shrink-buffer-if-larger-than-buffer"? Maybe this should become >> 'shrink-buffer-window-if-larger-than-buffer' then. > > Should such a function be added to window.el? Maybe. But we could also rename the first argument of 'shrink-window-if-larger-than-buffer' to WINDOW-OR-BUFFER. >> With the usual problem what to do when there are two windows showing >> that buffer. > > It's understandable why vc-diff-internal and vc-diff-finish > use get-buffer-window to get a window: > > vc-diff-internal: > (pop-to-buffer (current-buffer)) > (let ((buf (current-buffer))) > (vc-run-delayed (vc-diff-finish buf ... > > vc-diff-finish: > (let ((window (get-buffer-window buffer t))) > (with-current-buffer buffer > ... > (when window > (shrink-window-if-larger-than-buffer window)))) > > This is needed to handle the case when the window was deleted > before the vc command finished. > > But why vc-log-internal-common doesn't so the same? > > vc-log-internal-common: > (pop-to-buffer buffer) > (vc-run-delayed > ... > (shrink-window-if-larger-than-buffer) > > So I posted a patch in bug#52855 to use the same function > that relies on get-buffer-window in both cases. > > But it seems you propose to remember the window with e.g. > > (setq window (pop-to-buffer (current-buffer))) > > then to use it in: > > (run-hook-with-args 'vc-diff-finish-functions window) > > where the defalut value of 'vc-diff-finish-functions' is: > > '(shrink-window-if-larger-than-buffer) > > Then 'shrink-buffer-window-if-larger-than-buffer' is not needed. Personally I dislike abusing hooks like that. But I probably do not use vc-... much either. So do whatever you like more. martin