From: "Charl P. Botha" <cpbotha@vxlabs.com>
To: "Yuan Fu" <casouri@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 59945@debbugs.gnu.org
Subject: bug#59945: [PATCH] Fix empty pairs in js tree-sitter imenu alist
Date: Tue, 13 Dec 2022 09:48:02 +0200 [thread overview]
Message-ID: <7c331556-090e-4e44-a337-6f506e81d811@app.fastmail.com> (raw)
In-Reply-To: <2CD18C33-060B-4BC1-860E-1EB097EA7F0C@gmail.com>
Dear Yuan Fu, dear Eli,
On Tue, Dec 13, 2022, at 00:28, Yuan Fu wrote:
> "Charl P. Botha" <cpbotha@vxlabs.com> writes:
>
>> The current js--treesit-imenu, used by the JavaScript, TypeScript and
>> TSX tree-sitter modes, would return empty pairs in the imenu alist if
>> there were none of that type of symbol.
>>
>> This would break both the built in imenu and also packages like
>> consult-imenu.
>>
>> See https://github.com/minad/consult/issues/697 for the discussion
>> there.
>
> Thank you very much! Sorry for the inconvenience it caused. Have you
> signed the copyright assignment? I’m asking because this change is on
> the verge of 15 lines. Eli, WDYT?
Emacs is (and always has been) a positive force in my life, thank you for all the energy that you pour into it!
I have not yet signed the copyright assignment, I would gladly do so.
Hopefully we can do this digitally? I live in South Africa, but I'm a Dutch citizen, in case that matters. I also have a PGP key [1] that's fairly well connected and can be verified on keybase (FWIW) [2]
Kind regards,
Charl
[1] http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x384435C7E77A4564
[2] https://keybase.io/cpbotha
next prev parent reply other threads:[~2022-12-13 7:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-10 17:17 bug#59945: [PATCH] Fix empty pairs in js tree-sitter imenu alist Charl P. Botha
2022-12-12 22:28 ` Yuan Fu
2022-12-13 7:48 ` Charl P. Botha [this message]
2022-12-13 12:40 ` Eli Zaretskii
2022-12-13 12:03 ` Eli Zaretskii
2022-12-15 9:13 ` Charl P. Botha
2022-12-15 10:41 ` Eli Zaretskii
2022-12-16 1:40 ` Yuan Fu
2022-12-16 5:58 ` Charl P. Botha
2022-12-16 14:11 ` Robert Pluim
2022-12-16 17:52 ` Charl P. Botha
2022-12-21 4:48 ` Yuan Fu
2022-12-21 10:15 ` Charl P. Botha
2022-12-21 17:25 ` Robert Pluim
2022-12-22 8:10 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c331556-090e-4e44-a337-6f506e81d811@app.fastmail.com \
--to=cpbotha@vxlabs.com \
--cc=59945@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).