From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#52209: 28.0.60; [PATCH] date-to-time fails on pure dates Date: Sat, 4 Dec 2021 10:58:37 -0800 Organization: UCLA Computer Science Department Message-ID: <7c22f300-eedb-da65-db02-e82025ec2f48@cs.ucla.edu> References: <24998.36813.449798.684270@orion.rgrjr.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------EKJu01G3R0StBJ9IYEUQj3R5" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1582"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Cc: Bob Rogers , Katsumi Yamaoka , 52209@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 04 19:59:08 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtaFY-0000E1-JN for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Dec 2021 19:59:08 +0100 Original-Received: from localhost ([::1]:36058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mtaFX-0003ri-LY for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Dec 2021 13:59:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtaFS-0003ra-32 for bug-gnu-emacs@gnu.org; Sat, 04 Dec 2021 13:59:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43390) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mtaFR-0005vx-S7 for bug-gnu-emacs@gnu.org; Sat, 04 Dec 2021 13:59:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mtaFR-00024N-RR for bug-gnu-emacs@gnu.org; Sat, 04 Dec 2021 13:59:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <24998.36813.449798.684270@orion.rgrjr.com> Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Dec 2021 18:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52209 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52209-submit@debbugs.gnu.org id=B52209.16386443307937 (code B ref 52209); Sat, 04 Dec 2021 18:59:01 +0000 Original-Received: (at 52209) by debbugs.gnu.org; 4 Dec 2021 18:58:50 +0000 Original-Received: from localhost ([127.0.0.1]:54936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtaFF-00023x-U3 for submit@debbugs.gnu.org; Sat, 04 Dec 2021 13:58:50 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:45360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtaFC-00023h-H9 for 52209@debbugs.gnu.org; Sat, 04 Dec 2021 13:58:48 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 05B55160108; Sat, 4 Dec 2021 10:58:40 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id CD_X5_gmvA21; Sat, 4 Dec 2021 10:58:38 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 92651160107; Sat, 4 Dec 2021 10:58:38 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0IPXiTrn6wRH; Sat, 4 Dec 2021 10:58:38 -0800 (PST) Original-Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 5C0E6160106; Sat, 4 Dec 2021 10:58:38 -0800 (PST) Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221479 Archived-At: This is a multi-part message in MIME format. --------------EKJu01G3R0StBJ9IYEUQj3R5 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Unfortunately the latest change to time-date.el reintroduced Bug#52209. I installed the attached patch to fix this, and to add some test cases mentioned in this bug report to help prevent the problem recurring. Also, this patch documents the new feature, and avoids overenthusiastically guessing the year to be 1970 when the date string lacks a year. > (These functions were never really intended to support parsing dates > like that -- only strict RFC822 date strings were originally supported, > but it's become more DWIM as time has passed. Yes, date-to-time has definitely ... evolved. My understanding is that date-to-time's RFC822 parsing is present only for backward compatibility, and that we shouldn't attempt to enhance it (here, the enhancement would be pointless as the RFC822 parsing fills in the blanks anyway). So the patch I just installed adds the new feature only for the normal path taken, when not doing the RFC822 hack. PS. Internet RFC 822 has been obsolete since 2001, and the Emacs code should be talking about RFC 5322 everywhere except when Emacs is explicitly supporting the obsolete standard instead of the current standard. And we should rename functions like rfc822-goto-eoh to rfc-email-goto-eoh, to help avoid confusion or further function renaming. But I digress.... --------------EKJu01G3R0StBJ9IYEUQj3R5 Content-Type: text/x-patch; charset=UTF-8; name="0001-Fix-date-to-time-2021-12-04.patch" Content-Disposition: attachment; filename="0001-Fix-date-to-time-2021-12-04.patch" Content-Transfer-Encoding: base64 RnJvbSBjYjBmNGYwMGIzMjhhNTYxZTQ5NTM4YmJmMGY5MDA1MGVhYzFiYTIwIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBTYXQsIDQgRGVjIDIwMjEgMTA6MzM6MzIgLTA4MDAKU3ViamVjdDogW1BBVENI XSBGaXggKGRhdGUtdG8tdGltZSAiMjAyMS0xMi0wNCIpCgpUaGlzIHNob3VsZCBjb21wbGV0 ZSB0aGUgZml4IGZvciBCdWcjNTIyMDkuCiogbGlzcC9jYWxlbmRhci90aW1lLWRhdGUuZWwg KGRhdGUtdG8tdGltZSk6IEFwcGx5CmRlY29kZWQtdGltZS1zZXQtZGVmYXVsdHMgb25seSB0 byB0aGUgb3V0cHV0IG9mIChwYXJzZS10aW1lLXN0cmluZwpkYXRlKSwgYW5kIG9ubHkgd2hl biB0aGUgb3V0cHV0IGhhcyBhIHllYXIgKHRvIGF2b2lkIGNvbmZ1c2lvbgp3aGVuIGRhdGVz IGxhY2sgeWVhcnMpLiAgVGhlcmUgaXMgbm8gcG9pbnQgYXBwbHlpbmcgaXQgYWZ0ZXIKdGlt ZXpvbmUtbWFrZS1kYXRlLWFycGEtc3RhbmRhcmQgc2luY2UgdGhlIGxhdHRlciBmaWxscyBp biBhbGwgdGhlCmJsYW5rcy4gIEFuZCB0aGUgZm9ybWVyIGNvZGUgbWlzdGFrZW5seSBjYWxs ZWQgZW5jb2RlLXRpbWUgb24gYW4KYWxyZWFkeS1lbmNvZGVkIHRpbWUuICBUaGlzIGdvZXMg YmFjayB0byB0aGUgY29kZSBhIGNvdXBsZSBvZiBkYXlzCmFnbywgZXhjZXB0IHdpdGggY2hh bmdlZCBiZWhhdmlvciAodG8gZml4IEJ1ZyM1MjIwOSkgb25seSB3aGVuCnRpbWV6b25lLW1h a2UtZGF0ZS1hcnBhLXN0YW5kYXJkIGlzIG5vdCBjYWxsZWQuCiogdGVzdC9saXNwL2NhbGVu ZGFyL3RpbWUtZGF0ZS10ZXN0cy5lbCAodGVzdC1kYXRlLXRvLXRpbWUpCih0ZXN0LWRheXMt YmV0d2Vlbik6IE5ldyB0ZXN0cy4KLS0tCiBkb2MvbGlzcHJlZi9vcy50ZXhpICAgICAgICAg ICAgICAgICAgIHwgIDMgKystCiBldGMvTkVXUyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHwgIDQgKysrCiBsaXNwL2NhbGVuZGFyL3RpbWUtZGF0ZS5lbCAgICAgICAgICAgIHwg MzggKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tCiB0ZXN0L2xpc3AvY2FsZW5kYXIvdGlt ZS1kYXRlLXRlc3RzLmVsIHwgIDcgKysrKysKIDQgZmlsZXMgY2hhbmdlZCwgMjkgaW5zZXJ0 aW9ucygrKSwgMjMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL2xpc3ByZWYvb3Mu dGV4aSBiL2RvYy9saXNwcmVmL29zLnRleGkKaW5kZXggZTQyMDY0NGNkOC4uYjRlZmM0NGIw MyAxMDA2NDQKLS0tIGEvZG9jL2xpc3ByZWYvb3MudGV4aQorKysgYi9kb2MvbGlzcHJlZi9v cy50ZXhpCkBAIC0xNzI0LDcgKzE3MjQsOCBAQCBUaW1lIFBhcnNpbmcKIGNvcnJlc3BvbmRp bmcgTGlzcCB0aW1lc3RhbXAuICBUaGUgYXJndW1lbnQgQHZhcntzdHJpbmd9IHNob3VsZCBy ZXByZXNlbnQKIGEgZGF0ZS10aW1lLCBhbmQgc2hvdWxkIGJlIGluIG9uZSBvZiB0aGUgZm9y bXMgcmVjb2duaXplZCBieQogQGNvZGV7cGFyc2UtdGltZS1zdHJpbmd9IChzZWUgYmVsb3cp LiAgVGhpcyBmdW5jdGlvbiBhc3N1bWVzIFVuaXZlcnNhbAotVGltZSBpZiBAdmFye3N0cmlu Z30gbGFja3MgZXhwbGljaXQgdGltZSB6b25lIGluZm9ybWF0aW9uLgorVGltZSBpZiBAdmFy e3N0cmluZ30gbGFja3MgZXhwbGljaXQgdGltZSB6b25lIGluZm9ybWF0aW9uLAorYW5kIGFz c3VtZXMgZWFybGllc3QgdmFsdWVzIGlmIEB2YXJ7c3RyaW5nfSBsYWNrcyBtb250aCwgZGF5 LCBvciB0aW1lLgogVGhlIG9wZXJhdGluZyBzeXN0ZW0gbGltaXRzIHRoZSByYW5nZSBvZiB0 aW1lIGFuZCB6b25lIHZhbHVlcy4KIEBlbmQgZGVmdW4KIApkaWZmIC0tZ2l0IGEvZXRjL05F V1MgYi9ldGMvTkVXUwppbmRleCBhYzE3ODdkN2Y4Li4yYjRlYWFmOGExIDEwMDY0NAotLS0g YS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtMTA4NCw2ICsxMDg0LDEwIEBAIGNvb2tp ZXMgc2V0IGJ5IHdlYiBwYWdlcyBvbiBkaXNrLgogKiogTmV3IHZhcmlhYmxlICdoZWxwLWJ1 ZmZlci11bmRlci1wcmVwYXJhdGlvbicuCiBUaGlzIHZhcmlhYmxlIGlzIGJvdW5kIHRvIHQg ZHVyaW5nIHRoZSBwcmVwYXJhdGlvbiBvZiBhICIqSGVscCoiIGJ1ZmZlci4KIAorKysrCisq KiAnZGF0ZS10by10aW1lJyBub3cgYXNzdW1lcyBlYXJsaWVzdCB2YWx1ZXMgaWYgaXRzIGFy Z3VtZW50IGxhY2tzCittb250aCwgZGF5LCBvciB0aW1lLiAgRm9yIGV4YW1wbGUsIChkYXRl LXRvLXRpbWUgIjIwMjEtMTItMDQiKSBub3cKK2Fzc3VtZXMgYSB0aW1lIG9mIDAwOjAwIGlu c3RlYWQgb2Ygc2lnbmFsaW5nIGFuIGVycm9yLgogDAogKiBDaGFuZ2VzIGluIEVtYWNzIDI5 LjEgb24gTm9uLUZyZWUgT3BlcmF0aW5nIFN5c3RlbXMKIApkaWZmIC0tZ2l0IGEvbGlzcC9j YWxlbmRhci90aW1lLWRhdGUuZWwgYi9saXNwL2NhbGVuZGFyL3RpbWUtZGF0ZS5lbAppbmRl eCA4YTZlZTBmMjcwLi4zN2ExNmQzYjk4IDEwMDY0NAotLS0gYS9saXNwL2NhbGVuZGFyL3Rp bWUtZGF0ZS5lbAorKysgYi9saXNwL2NhbGVuZGFyL3RpbWUtZGF0ZS5lbApAQCAtMTUzLDI4 ICsxNTMsMjIgQEAgZGF0ZS10by10aW1lCiAgICJQYXJzZSBhIHN0cmluZyBEQVRFIHRoYXQg cmVwcmVzZW50cyBhIGRhdGUtdGltZSBhbmQgcmV0dXJuIGEgdGltZSB2YWx1ZS4KIERBVEUg c2hvdWxkIGJlIGluIG9uZSBvZiB0aGUgZm9ybXMgcmVjb2duaXplZCBieSBgcGFyc2UtdGlt ZS1zdHJpbmcnLgogSWYgREFURSBsYWNrcyB0aW1lem9uZSBpbmZvcm1hdGlvbiwgR01UIGlz IGFzc3VtZWQuIgotICA7OyBQYXNzIHRoZSByZXN1bHQgb2YgcGFyc2luZyB0aHJvdWdoIGRl Y29kZWQtdGltZS1zZXQtZGVmYXVsdHMKLSAgOzsgYmVjYXVzZSBlbmNvZGUtdGltZSBzaWdu YWxzIGlmIEhIOk1NOlNTIGFyZSBub3QgZmlsbGVkIGluLgotICAoZW5jb2RlLXRpbWUKLSAg ICAoZGVjb2RlZC10aW1lLXNldC1kZWZhdWx0cwotICAgICAgKGNvbmRpdGlvbi1jYXNlIGVy cgotICAgICAgICAgIChsZXQgKCh0aW1lIChwYXJzZS10aW1lLXN0cmluZyBkYXRlKSkpCi0g ICAgICAgICAgICAocHJvZzEgdGltZQotICAgICAgICAgICAgICA7OyBDYXVzZSBhbiBlcnJv ciBpZiBkYXRhIGBwYXJzZS10aW1lLXN0cmluZycgcmV0dXJucyBpcyBpbnZhbGlkLgotICAg ICAgICAgICAgICAoc2V0cSB0aW1lIChlbmNvZGUtdGltZSB0aW1lKSkpKQotICAgICAgICAo ZXJyb3IKLSAgICAgICAgIChsZXQgKChvdmVyZmxvdy1lcnJvciAnKGVycm9yICJTcGVjaWZp ZWQgdGltZSBpcyBub3QgcmVwcmVzZW50YWJsZSIpKSkKLSAgICAgICAgICAgKGlmIChvciAo ZXF1YWwgZXJyIG92ZXJmbG93LWVycm9yKQotICAgICAgICAgICAgICAgICAgIDs7IHRpbWV6 b25lLW1ha2UtZGF0ZS1hcnBhLXN0YW5kYXJkIG1pc2JlaGF2ZXMgaWYKLSAgICAgICAgICAg ICAgICAgICA7OyBub3QgZ2l2ZW4gYXQgbGVhc3QgSEg6TU0gYXMgcGFydCBvZiB0aGUgZGF0 ZS4KLSAgICAgICAgICAgICAgICAgICAobm90IChzdHJpbmctbWF0Y2ggIjoiIGRhdGUpKSkK LSAgICAgICAgICAgICAgIChzaWduYWwgKGNhciBlcnIpIChjZHIgZXJyKSkKLSAgICAgICAg ICAgICAoY29uZGl0aW9uLWNhc2UgZXJyCi0gICAgICAgICAgICAgICAgIChwYXJzZS10aW1l LXN0cmluZyAodGltZXpvbmUtbWFrZS1kYXRlLWFycGEtc3RhbmRhcmQgZGF0ZSkpCi0gICAg ICAgICAgICAgICAoZXJyb3IKLSAgICAgICAgICAgICAgICAoaWYgKGVxdWFsIGVyciBvdmVy Zmxvdy1lcnJvcikKLSAgICAgICAgICAgICAgICAgICAgKHNpZ25hbCAoY2FyIGVycikgKGNk ciBlcnIpKQotICAgICAgICAgICAgICAgICAgKGVycm9yICJJbnZhbGlkIGRhdGU6ICVzIiBk YXRlKSkpKSkpKSkpKSkKKyAgKGNvbmRpdGlvbi1jYXNlIGVycgorICAgICAgKGxldCAoKHBh cnNlZCAocGFyc2UtdGltZS1zdHJpbmcgZGF0ZSkpKQorCSh3aGVuIChkZWNvZGVkLXRpbWUt eWVhciBwYXJzZWQpCisJICAoZGVjb2RlZC10aW1lLXNldC1kZWZhdWx0cyBwYXJzZWQpKQor CShlbmNvZGUtdGltZSBwYXJzZWQpKQorICAgIChlcnJvcgorICAgICAobGV0ICgob3ZlcmZs b3ctZXJyb3IgJyhlcnJvciAiU3BlY2lmaWVkIHRpbWUgaXMgbm90IHJlcHJlc2VudGFibGUi KSkpCisgICAgICAgKGlmIChlcXVhbCBlcnIgb3ZlcmZsb3ctZXJyb3IpCisJICAgKHNpZ25h bCAoY2FyIGVycikgKGNkciBlcnIpKQorCSAoY29uZGl0aW9uLWNhc2UgZXJyCisJICAgICAo ZW5jb2RlLXRpbWUgKHBhcnNlLXRpbWUtc3RyaW5nCisJCQkgICAodGltZXpvbmUtbWFrZS1k YXRlLWFycGEtc3RhbmRhcmQgZGF0ZSkpKQorCSAgIChlcnJvcgorCSAgICAoaWYgKGVxdWFs IGVyciBvdmVyZmxvdy1lcnJvcikKKwkJKHNpZ25hbCAoY2FyIGVycikgKGNkciBlcnIpKQor CSAgICAgIChlcnJvciAiSW52YWxpZCBkYXRlOiAlcyIgZGF0ZSkpKSkpKSkpKQogCiA7Ozsj IyNhdXRvbG9hZAogKGRlZmFsaWFzICd0aW1lLXRvLXNlY29uZHMgJ2Zsb2F0LXRpbWUpCmRp ZmYgLS1naXQgYS90ZXN0L2xpc3AvY2FsZW5kYXIvdGltZS1kYXRlLXRlc3RzLmVsIGIvdGVz dC9saXNwL2NhbGVuZGFyL3RpbWUtZGF0ZS10ZXN0cy5lbAppbmRleCA0NTY4OTQ3YzBiLi5k NTI2OTgwNGFkIDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvY2FsZW5kYXIvdGltZS1kYXRlLXRl c3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9jYWxlbmRhci90aW1lLWRhdGUtdGVzdHMuZWwKQEAg LTQxLDYgKzQxLDEzIEBAIHRlc3Qtb2Jzb2xldGUtZW5jb2RlLXRpbWUtdmFsdWUKICAgICAg ICAgICAgICAgICAgICAoZW5jb2RlLXRpbWUtdmFsdWUgMSAyIDMgNCAzKSkKICAgICAgICAg ICAgICAgICAgJygxIDIgMyA0KSkpKQogCisoZXJ0LWRlZnRlc3QgdGVzdC1kYXRlLXRvLXRp bWUgKCkKKyAgKHNob3VsZCAoZXF1YWwgKGZvcm1hdC10aW1lLXN0cmluZyAiJUYgJVQiIChk YXRlLXRvLXRpbWUgIjIwMjEtMTItMDQiKSkKKyAgICAgICAgICAgICAgICAgIjIwMjEtMTIt MDQgMDA6MDA6MDAiKSkpCisKKyhlcnQtZGVmdGVzdCB0ZXN0LWRheXMtYmV0d2VlbiAoKQor ICAoc2hvdWxkIChlcXVhbCAoZGF5cy1iZXR3ZWVuICIyMDIxLTEwLTIyIiAiMjAyMC0wOS0y OSIpIDM4OCkpKQorCiAoZXJ0LWRlZnRlc3QgdGVzdC1sZWFwLXllYXIgKCkKICAgKHNob3Vs ZC1ub3QgKGRhdGUtbGVhcC15ZWFyLXAgMTk5OSkpCiAgIChzaG91bGQtbm90IChkYXRlLWxl YXAteWVhci1wIDE5MDApKQotLSAKMi4zMi4wCgo= --------------EKJu01G3R0StBJ9IYEUQj3R5--