bug#22189: 25.1.50; [PATCH] Add `global-goto-address-mode' and `global-goto-address-prog-mode'

bug#22189: 25.1.50; [PATCH] Add `global-goto-address-mode' and `global-goto-address-prog-mode'

[Vaidheeswaran C]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-Add-global-goto-address-mode-and-global-goto-address.patch --]
[-- Type: text/x-diff, Size: 1039 bytes --]

From 137e8b559e0e8aaf9f82120ec83c86e377684e94 Mon Sep 17 00:00:00 2001
From: Vaidheeswaran C <vaidheeswaran.chinnaraju@gmail.com>
Date: Wed, 16 Dec 2015 19:41:23 +0530
Subject: [PATCH] Add `global-goto-address-mode' and
 `global-goto-address-prog-mode'

* lisp/net/goto-addr.el(global-goto-address-mode)
(global-goto-address-prog-mode): Add these.
---
 lisp/net/goto-addr.el | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/lisp/net/goto-addr.el b/lisp/net/goto-addr.el
index 51d8ed1..fa3ed26 100644
--- a/lisp/net/goto-addr.el
+++ b/lisp/net/goto-addr.el
@@ -301,6 +301,14 @@ goto-address-prog-mode
       (widen)
       (goto-address-unfontify (point-min) (point-max)))))
 
+;;;###autoload
+(define-globalized-minor-mode global-goto-address-mode
+  goto-address-mode goto-address-mode :group 'goto-address)
+
+;;;###autoload
+(define-globalized-minor-mode global-goto-address-prog-mode
+  goto-address-prog-mode goto-address-prog-mode :group 'goto-address)
+
 (provide 'goto-addr)
 
 ;;; goto-addr.el ends here
-- 
2.1.4

bug#22189: 25.1.50; [PATCH] Add `global-goto-address-mode' and `global-goto-address-prog-mode'

[Eli Zaretskii]

> From: Vaidheeswaran C <vaidheeswaran.chinnaraju@gmail.com>
> Date: Wed, 16 Dec 2015 19:45:19 +0530
> 
> >From 137e8b559e0e8aaf9f82120ec83c86e377684e94 Mon Sep 17 00:00:00 2001
> From: Vaidheeswaran C <vaidheeswaran.chinnaraju@gmail.com>
> Date: Wed, 16 Dec 2015 19:41:23 +0530
> Subject: [PATCH] Add `global-goto-address-mode' and
>  `global-goto-address-prog-mode'

Any rationale for adding these?

Thanks.

bug#22189: 25.1.50; [PATCH] Add `global-goto-address-mode' and `global-goto-address-prog-mode'

[Vaidheeswaran C]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Vaidheeswaran C <vaidheeswaran.chinnaraju@gmail.com>
>> Date: Wed, 16 Dec 2015 19:45:19 +0530
>> 
>> >From 137e8b559e0e8aaf9f82120ec83c86e377684e94 Mon Sep 17 00:00:00 2001
>> From: Vaidheeswaran C <vaidheeswaran.chinnaraju@gmail.com>
>> Date: Wed, 16 Dec 2015 19:41:23 +0530
>> Subject: [PATCH] Add `global-goto-address-mode' and
>>  `global-goto-address-prog-mode'
>
> Any rationale for adding these?

Any rationale for NOT adding these?

bug#22189: 25.1.50; [PATCH] Add `global-goto-address-mode' and `global-goto-address-prog-mode'

[Eli Zaretskii]

> From: Vaidheeswaran C <vaidheeswaran.chinnaraju@gmail.com>
> Cc: 22189@debbugs.gnu.org
> Date: Fri, 18 Dec 2015 08:20:42 +0530
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> From: Vaidheeswaran C <vaidheeswaran.chinnaraju@gmail.com>
> >> Date: Wed, 16 Dec 2015 19:45:19 +0530
> >> 
> >> >From 137e8b559e0e8aaf9f82120ec83c86e377684e94 Mon Sep 17 00:00:00 2001
> >> From: Vaidheeswaran C <vaidheeswaran.chinnaraju@gmail.com>
> >> Date: Wed, 16 Dec 2015 19:41:23 +0530
> >> Subject: [PATCH] Add `global-goto-address-mode' and
> >>  `global-goto-address-prog-mode'
> >
> > Any rationale for adding these?
> 
> Any rationale for NOT adding these?

Yes: bloat.

bug#22189: 25.1.50; [PATCH] Add `global-goto-address-mode' and `global-goto-address-prog-mode'

[Vaidheeswaran C]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Vaidheeswaran C <vaidheeswaran.chinnaraju@gmail.com>
>> Cc: 22189@debbugs.gnu.org
>> Date: Fri, 18 Dec 2015 08:20:42 +0530
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> >> From: Vaidheeswaran C <vaidheeswaran.chinnaraju@gmail.com>
>> >> Date: Wed, 16 Dec 2015 19:45:19 +0530
>> >> 
>> >> >From 137e8b559e0e8aaf9f82120ec83c86e377684e94 Mon Sep 17 00:00:00 2001
>> >> From: Vaidheeswaran C <vaidheeswaran.chinnaraju@gmail.com>
>> >> Date: Wed, 16 Dec 2015 19:41:23 +0530
>> >> Subject: [PATCH] Add `global-goto-address-mode' and
>> >>  `global-goto-address-prog-mode'
>> >
>> > Any rationale for adding these?
>> 
>> Any rationale for NOT adding these?
>
> Yes: bloat.

No: Useful.

bug#22189: 25.1.50; [PATCH] Add `global-goto-address-mode' and `global-goto-address-prog-mode'

[Eli Zaretskii]

> From: Vaidheeswaran C <vaidheeswaran.chinnaraju@gmail.com>
> Cc: 22189@debbugs.gnu.org
> Date: Fri, 18 Dec 2015 12:46:32 +0530
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> From: Vaidheeswaran C <vaidheeswaran.chinnaraju@gmail.com>
> >> Cc: 22189@debbugs.gnu.org
> >> Date: Fri, 18 Dec 2015 08:20:42 +0530
> >> 
> >> Eli Zaretskii <eliz@gnu.org> writes:
> >> 
> >> >> From: Vaidheeswaran C <vaidheeswaran.chinnaraju@gmail.com>
> >> >> Date: Wed, 16 Dec 2015 19:45:19 +0530
> >> >> 
> >> >> >From 137e8b559e0e8aaf9f82120ec83c86e377684e94 Mon Sep 17 00:00:00 2001
> >> >> From: Vaidheeswaran C <vaidheeswaran.chinnaraju@gmail.com>
> >> >> Date: Wed, 16 Dec 2015 19:41:23 +0530
> >> >> Subject: [PATCH] Add `global-goto-address-mode' and
> >> >>  `global-goto-address-prog-mode'
> >> >
> >> > Any rationale for adding these?
> >> 
> >> Any rationale for NOT adding these?
> >
> > Yes: bloat.
> 
> No: Useful.

Please elaborate.

I'm serious: we don't have any rule that says each minor mode should
have a corresponding globalized minor mode.  Users can trivially do in
their ~/.emacs what you do in your patch, so we should have some
rationale for having such a global mode as part of Emacs.  Please show
such a rationale.

bug#22189: 25.1.50; [PATCH] Add `global-goto-address-mode' and `global-goto-address-prog-mode'

[Vaidheeswaran C]

Eli Zaretskii <eliz@gnu.org> writes:

> I'm serious: we don't have any rule that says each minor mode should
> have a corresponding globalized minor mode.  Users can trivially do in
> their ~/.emacs what you do in your patch, so we should have some
> rationale for having such a global mode as part of Emacs.  

Of all the minor modes, what criteria do the minor modes below all share
so that they are global?  Once we such a set of rules, we can see
whether patch I submitted makes through the gate.

./progmodes/cwarn.el:339: global-cwarn-mode
./progmodes/prog-mode.el:285: global-prettify-symbols-mode
./linum.el:112: global-linum-mode linum-mode
./simple.el:6563: global-visual-line-mode
./hilit-chg.el:971: global-highlight-changes-mode
./font-core.el:268: global-font-lock-mode
./hi-lock.el:399: global-hi-lock-mode

Your definition of "bloat" (as I see it) is this: If it can be in
.emacs, it can be a bloat.  Given your definition of bloat, cannot the
above lines also reside in .emacs?  Shouldn't this alone make the above
lines a bloat?

> Please show such a rationale.

Usefulnesss is the only rationale.  Of course, do not forget the
ubiquity of URLs in buffers.

bug#22189: 25.1.50; [PATCH] Add `global-goto-address-mode' and `global-goto-address-prog-mode'

[Eli Zaretskii]

> From: Vaidheeswaran C <vaidheeswaran.chinnaraju@gmail.com>
> Cc: 22189@debbugs.gnu.org
> Date: Sat, 19 Dec 2015 09:06:38 +0530
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > I'm serious: we don't have any rule that says each minor mode should
> > have a corresponding globalized minor mode.  Users can trivially do in
> > their ~/.emacs what you do in your patch, so we should have some
> > rationale for having such a global mode as part of Emacs.  
> 
> Of all the minor modes, what criteria do the minor modes below all share
> so that they are global?  Once we such a set of rules, we can see
> whether patch I submitted makes through the gate.

I don't know.  I didn't make those decisions (most of them were made
many years ago).

In any case, what is already in Emacs is already there, and is not
subject to this discussion.  If you think some of those should be
removed, feel free to start a separate discussion about that.  Here we
are talking about adding these two specific globalized modes.

> Your definition of "bloat" (as I see it) is this: If it can be in
> .emacs, it can be a bloat.  Given your definition of bloat, cannot the
> above lines also reside in .emacs?  Shouldn't this alone make the above
> lines a bloat?

Perhaps.  But that's not the issue at hand.  It would be impractical
to convert a discussion about every change into a much broader
discussion about consistency of rules and past decisions.

> > Please show such a rationale.
> 
> Usefulnesss is the only rationale.

I was asking for more details about the usefulness part.  Please humor
me, it's important for me to hear the arguments in favor of including
your submission.

Thanks.

bug#22189: 25.1.50; [PATCH] Add `global-goto-address-mode' and `global-goto-address-prog-mode'

[Vaidheeswaran C]

Eli Zaretskii <eliz@gnu.org> writes:

>> Usefulnesss is the only rationale.
>
> I was asking for more details about the usefulness part.  Please humor
> me, it's important for me to hear the arguments in favor of including
> your submission.

I want the URL (wherever and whenever they occour) in buffers clickable.
`global-goto-address-mode' does just that.  (I can live without
`global-goto-address-prog-mode').

A simple `rgrep' on the lisp files gives me 971 hits for the `http://'
URLs.  This is a number AFTER flushing out the lines that match
`http://www.gnu.org/licenses/'.

I would like to hear what alternatives you have to offer for
`global-goto-address-mode' that matches it SIMPLICITY.

Btw, if the change I propose moves to my .emacs, it cannot be used by a
Random Joe out there.  When I submitted the patch, I went with "If it is
useful for me, it is useful for atleast someother person out there".

If the real concern is bloat, it would be useful to think along the
lines of what mis-feature it might bring AFTER THE FACT.  (Think
`hi-lock-exclude-modes').

bug#22189: 25.1.50; [PATCH] Add `global-goto-address-mode' and `global-goto-address-prog-mode'

[Glenn Morris]

I would be wary of getting too involved in this discussion.

FYI, this is (fairly obviously) the guy who cancelled his previous
copyright assignment (and closed all his bug reports). Showing up under
a pseudonym, making no acknowledgement of or apology for previous
behaviour, and carrying on with the same contentious style, doesn't
incline me to pay any attention to him. Nor do I put any trust in any
copyright assignment. There are thousands more reports to deal with from
people who haven't gone out of their way to be disruptive.

Ref: http://lists.gnu.org/archive/html/emacs-devel/2015-05/msg00499.html

(if the posting style doesn't give it away)

(The above is all IMO.)

bug#22189: 25.1.50; [PATCH] Add `global-goto-address-mode' and `global-goto-address-prog-mode'

[Vaidheeswaran C]

Glenn

Glenn Morris <rgm@gnu.org> writes:

> I would be wary of getting too involved in this discussion.

Thanks for your opinions.  You seem to think that Eli deserves some
advice from you.  Presumptuous I say ...

Jambunathan K.

bug#22189: 25.1.50; [PATCH] Add `global-goto-address-mode' and `global-goto-address-prog-mode'

[Lars Ingebrigtsen]

Glenn Morris <rgm@gnu.org> writes:

> FYI, this is (fairly obviously) the guy who cancelled his previous
> copyright assignment (and closed all his bug reports). Showing up under
> a pseudonym, making no acknowledgement of or apology for previous
> behaviour, and carrying on with the same contentious style, doesn't
> incline me to pay any attention to him. Nor do I put any trust in any
> copyright assignment.

Yes, that sounds pretty dicey.  I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#22189: 25.1.50; [PATCH] Add `global-goto-address-mode' and `global-goto-address-prog-mode'

[John Wiegley]

>>>>> Eli Zaretskii <eliz@gnu.org> writes:

> Any rationale for adding these?

I don't see a reason not to accept this patch on master. Unless I'm not seeing
a reason *not* to want `goto-address-mode' easily enabled globally.

To Vaidheeswaran: Patches are accepted at the whim of the maintainers, so if
we ask you for clarification, please do not be short or glib with us. All you
need to say is, "I believe it would be useful for users to be able to easily
enable goto-address-mode in all buffers".

That said, we don't operate in a mode of doing whatever is possible, but
rather what we wish to maintain. This change alone is harmless, but a hundred
such changes could cause much annoyance. This is why we ask for rationale,
when it may seem pointless to do so.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

bug#22189: 25.1.50; [PATCH] Add `global-goto-address-mode' and `global-goto-address-prog-mode'

[Eli Zaretskii]

> From: John Wiegley <jwiegley@gmail.com>
> Cc: Vaidheeswaran C <vaidheeswaran.chinnaraju@gmail.com>,  22189@debbugs.gnu.org
> Date: Sun, 20 Dec 2015 14:37:59 -0800
> 
> >>>>> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Any rationale for adding these?
> 
> I don't see a reason not to accept this patch on master. Unless I'm not seeing
> a reason *not* to want `goto-address-mode' easily enabled globally.

No such reason, IMO.  My doubts were exclusively about whether this is
important enough to make it part of Emacs (as opposed to something
users should do in their customizations).