From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#12689: 24.2; Eshell ${cmd} substitution Date: Mon, 2 May 2022 20:52:03 -0700 Message-ID: <7af5ed95-30ec-43ab-4264-8e1d8a01cab2@gmail.com> References: <87wqyl1sa6.fsf@dimension8.tehua.net> <87czjwo12i.fsf@gnus.org> <25243bc1-06d5-59d5-14f9-d13aad818227@gmail.com> <871r0bhk9c.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8406"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 12689@debbugs.gnu.org, Aidan Gauland To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 03 05:54:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nljcA-00025C-0U for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 May 2022 05:54:18 +0200 Original-Received: from localhost ([::1]:57218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nljc8-0006Kt-E3 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 May 2022 23:54:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nljaw-0005W2-2I for bug-gnu-emacs@gnu.org; Mon, 02 May 2022 23:53:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44494) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nljav-00010A-Pp for bug-gnu-emacs@gnu.org; Mon, 02 May 2022 23:53:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nljav-0001Pv-PU for bug-gnu-emacs@gnu.org; Mon, 02 May 2022 23:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 May 2022 03:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12689 X-GNU-PR-Package: emacs Original-Received: via spool by 12689-submit@debbugs.gnu.org id=B12689.16515499305390 (code B ref 12689); Tue, 03 May 2022 03:53:01 +0000 Original-Received: (at 12689) by debbugs.gnu.org; 3 May 2022 03:52:10 +0000 Original-Received: from localhost ([127.0.0.1]:38391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlja6-0001Or-FR for submit@debbugs.gnu.org; Mon, 02 May 2022 23:52:10 -0400 Original-Received: from mail-pj1-f52.google.com ([209.85.216.52]:45840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlja5-0001Og-RB for 12689@debbugs.gnu.org; Mon, 02 May 2022 23:52:10 -0400 Original-Received: by mail-pj1-f52.google.com with SMTP id w17-20020a17090a529100b001db302efed6so1005721pjh.4 for <12689@debbugs.gnu.org>; Mon, 02 May 2022 20:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=PSaaqL08RqLsACY7ggurPFU3uvrMbL82V1edcmV2XHI=; b=heKR51UjwB5MKwB8OwQ5JiTWH6q99h0KpDWki0vt9/Mm+gi9f7mPPe+yPZfpPcDurf KlNqFKohruJ1xbou4D8zfHx7aVm+Y9baGmA6Hy7Mpmb+Bc9XR/xFhysH0V2nhy/++fao W9ydkToMeKWb9B3jwRRuhhWU1J7kaKs7+Ck14lcaPvNVrGWbiblg4/BHfweaJbLOtXpW It2ChdMVApNkuEzcdrhfKRcMWGXvVGGhjlg9Aqc6SlqJLq5Y7ZIeH8yeVX7nwoVu7gVX NfqqNTXKQKLXP1/gIqoe9MEe85sAExAARA2qUB1cbvH837PaeX3NS75DBgZtZrjM0/jQ 707w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PSaaqL08RqLsACY7ggurPFU3uvrMbL82V1edcmV2XHI=; b=dvw/V0Gznx2fyW+BSIV81A2ayNbeA3SQBPZ82shRORleP2VxH3NnKTLiU6L+OD3qjz 4WlgBWoWFqBbUHd4JToL/fKYhaMbWe9phz5cwu5SDLMumh+LKnhXVq6ITRdsX2H6MnND RgZRJg0YIptRy8cyMjqyErrEBIOr4CowTAoAIf4ZjgZD8x1p2eCvNPqSuLJqo0XqAyQC QhjIuJC1I85n0fbHSxSdbh5ErAGtQyGhCvBfuc6aGBikgmILxv7Ul/SJr3UzaX1fIZs+ HOeOWuk98URZOLJO3S63yV953TDtqwoIPTFzkJcKr7VPFxZ8ANFEEnyjfCGWrEJejylw P2Tg== X-Gm-Message-State: AOAM532EUb7MIYavxtLB4OGowYctY0We5qHwvCBbubTR/INVa6PFj2f+ +bKrtyBc9mf1l8nfCkE+EZY= X-Google-Smtp-Source: ABdhPJylE2UfMxfvHoX+P6kMA+7Kf+dkrOhUOfx8s2YNZa8WMTlAe9a5dNAIPh76MO4gbb0CScIRuQ== X-Received: by 2002:a17:90a:e517:b0:1da:3d42:7fb8 with SMTP id t23-20020a17090ae51700b001da3d427fb8mr2677841pjy.194.1651549924059; Mon, 02 May 2022 20:52:04 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id s6-20020a170902ea0600b0015e8d4eb1f0sm445112plg.58.2022.05.02.20.52.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 May 2022 20:52:03 -0700 (PDT) In-Reply-To: <871r0bhk9c.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231297 Archived-At: On 2/9/2022 12:12 PM, Lars Ingebrigtsen wrote: > OK; I'm reopening this bug report, then. I filed bug#55236 to fix some wider issues I encountered with Eshell expansions, which may also fix this bug. I think it depends on what exactly we want for the behavior here. With my patches in that bug, this is the behavior I get: Default: ~ $ echo ${/bin/echo -e "foo\nbar"} ("foo" "bar") ~ $ echo ${/bin/echo -e "foo\nbar"}-baz ("foo" "bar-baz") ~ $ /bin/echo ${/bin/echo -e "foo\nbar"} foo bar ~ $ /bin/echo ${/bin/echo -e "foo\nbar"}-baz foo bar-baz With `eshell-plain-echo-behavior' == t: ~ $ echo ${*echo -e "foo\nbar"} foo bar ~ $ echo ${*echo -e "foo\nbar"}-baz foo bar-baz ~ $ /bin/echo ${/bin/echo -e "foo\nbar"} foo bar ~ $ /bin/echo ${/bin/echo -e "foo\nbar"}-baz foo bar-baz I think the "plain" echo behavior is what the original report expected, so maybe we can consider this fixed then. However, maybe we should consider whether the default, non-"plain" behavior should be changed. I don't have a strong opinion here, although I'm hesitant to make any big changes to the default behavior of Eshell's echo builtin, since I feel like it could break a lot of things really easily...