From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression Date: Fri, 2 Dec 2022 22:28:36 +0100 Message-ID: <7ac55edd-3887-7e38-7d89-4902f0b61416@secure.kjonigsen.net> References: <831qpklejb.fsf@gnu.org> <83mt88jul4.fsf@gnu.org> <0A18F996-F3BB-4A7D-A0BE-76C8374DE517@thornhill.no> <8335a0jofb.fsf@gnu.org> <7BE15945-C463-448A-8593-E3B5D0E374FB@thornhill.no> <871qpj1x2k.fsf@thornhill.no> <83fsdzin4e.fsf@gnu.org> <87v8mvzgmt.fsf@thornhill.no> <838rjrigmq.fsf@gnu.org> <87k03bz99r.fsf@thornhill.no> <835yeviats.fsf@gnu.org> <87v8mt7dnb.fsf@thornhill.no> Reply-To: jostein@kjonigsen.net Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35168"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Cc: 59691@debbugs.gnu.org, jostein@kjonigsen.net To: Theodor Thornhill , Yuan Fu , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 02 22:29:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p1Dar-0008oP-BG for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Dec 2022 22:29:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1Dai-0000vF-2H; Fri, 02 Dec 2022 16:29:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1Dag-0000v5-CW for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 16:29:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1Dag-0004Kg-4c for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 16:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p1Daf-0001WL-Lw for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2022 16:29:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Dec 2022 21:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59691 X-GNU-PR-Package: emacs Original-Received: via spool by 59691-submit@debbugs.gnu.org id=B59691.16700165295838 (code B ref 59691); Fri, 02 Dec 2022 21:29:01 +0000 Original-Received: (at 59691) by debbugs.gnu.org; 2 Dec 2022 21:28:49 +0000 Original-Received: from localhost ([127.0.0.1]:48991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1DaT-0001W6-3u for submit@debbugs.gnu.org; Fri, 02 Dec 2022 16:28:49 -0500 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]:40917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1DaO-0001W0-TK for 59691@debbugs.gnu.org; Fri, 02 Dec 2022 16:28:47 -0500 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id B9F135C00B5; Fri, 2 Dec 2022 16:28:39 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 02 Dec 2022 16:28:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:reply-to:sender :subject:subject:to:to; s=fm3; t=1670016519; x=1670102919; bh=w+ ZdXaw0qz7IYiIg3NTSJWXrM5sR0AqZQmCxeAWn/Y0=; b=K0wOxLm79CsN0VaJZU oG46PzzozFiyKY4Vo+nx2/MC7Rw/KzujPdVX85rZEoy/N2eG6fDYLfubDt+Wjt14 6gUApWzZuPOjM1cxMLPojaeJpNvwWJPM0hSywpT73Er1a5bsXWEan7WUPRL+ixOp Zf4OcM0A635dcrJy6jQwtj2dqjaad3iSnKw6z6KSCQjjIRcwJlwPxfd53ZR4iw/d CeUR13AvdrN6/Q94LaaDNhtt/TIQ7O+A0X9WOfkESmgvgIW64axtGeD5Wb8Ror0D +FP09JCrzgF22RxVBTaYnTRvle42kjz484pLroCLoC6PwRCACycUf1V3EUu2KmLg hruw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1670016519; x=1670102919; bh=w+ZdXaw0qz7IYiIg3NTSJWXrM5sR0AqZQmC xeAWn/Y0=; b=mGgIqoWaWM/gfE91jVL7CakrCdiQuWoI5vJbK95356zXVzLiy+M m1IFfRQcUw8SRxSQe7+IABdPqp+xUIjo0yjqOi/JEwWp+6XdKxppRkfQYrXJM2+3 cEFgrnwetyhLV13//6O1daboCIMdbget5Uj95Lw7be/X+iJRUVy4KL8rGPVcDcwI Ygp4OodlUS3K/nXEfJ4UnfO3P8VefgiTP5cXrhIUSNpAa9+ZOP3xBxvabwGEXAK2 xj2gW2jUugxceqBWBvjFLotr5FHnvLfOHrESPE1bHmu3E6lr5PCoVk93XvfYMJeF fHg7E+zuuoi2aJdONXXur7Ehvu5KsuxFjkQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrtdekgdduvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfrhfuvfevfhfhjggtgfesthekredttdefjeenucfhrhhomheplfho shhtvghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjoh hnihhgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnheptdeftdektdffueekvddvvdek ueevuddviedtffffgffggeeltdekhefgtdejkeevnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhho nhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Dec 2022 16:28:38 -0500 (EST) Content-Language: nb-NO, en-GB In-Reply-To: <87v8mt7dnb.fsf@thornhill.no> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249788 Archived-At: >> Cool. I applied the patch, thanks Theo! I changed >> typescript-ts-mode—base-mode to typescript-ts-base-mode, since I >> don’t think anyone has strong opinions about its naming, and >> typescript-ts-base-mode is more consistent with other tree-sitter >> base modes. >> Yuan > Thanks! I believe this can be closed. What do you think, Jostein? > > Theo Hey guys. Amazing work! Sorry for being somewhat slow wrt to testing. I had to rebuild some tree-sitter libraries, and the build-code in admin/notes/tree-sitter/ seemingly didn't work out of the box for both plain typescript and tsx. Yadda, yadda, yadda. I've modified the scripts to also build for typescript/tsx. Do you wan't me to send in a patch for that, Yuan? Back to the point: Either way, I've tested both TS-code and TSX-code now, and it seems to work much better. I still see some errors in TSX-code I can't recall seing in the old mode (and I might report those issues, once I have time to collect more accurate data on them), but for now I definitely think what we have here warrants marking this particular bug as closed. :) -- Jostein