unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Po Lu <luangruo@yahoo.com>
Cc: 54382-done@debbugs.gnu.org,
	Torsten Bronger <bronger@physik.rwth-aachen.de>
Subject: bug#54382: 28.0.92; --with-x-toolkit=no leads to "FALLTHROUGH undefined" in Activate.c
Date: Mon, 14 Mar 2022 13:17:18 -0700	[thread overview]
Message-ID: <7a957d8d-4988-d682-00c1-0550d578b6d0@cs.ucla.edu> (raw)
In-Reply-To: <87wngwn9nl.fsf@gnus.org>

[-- Attachment #1: Type: text/plain, Size: 79 bytes --]

I installed the attached further patch, which should fix this in a 
better way.

[-- Attachment #2: 0001-Another-fix-for-the-no-toolkit-build.patch --]
[-- Type: text/x-patch, Size: 1540 bytes --]

From adc6e855c19a7c9da6aa37c32710e67e4bff97b6 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Mon, 14 Mar 2022 13:14:23 -0700
Subject: [PATCH] Another fix for the no-toolkit build

This should be better in the long run.
* oldXMenu/Activate.c (XMenuActivate): Revert previous change,
eliminating the goto it introduced.
* oldXMenu/XMenuInt.h: Include <attribute.h>, for FALLTHROUGH.
---
 oldXMenu/Activate.c | 7 ++-----
 oldXMenu/XMenuInt.h | 2 ++
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/oldXMenu/Activate.c b/oldXMenu/Activate.c
index 410782e60a..e679c2ffed 100644
--- a/oldXMenu/Activate.c
+++ b/oldXMenu/Activate.c
@@ -615,8 +615,8 @@ XMenuActivate(
 						   event.xbutton.window
 						   );
 		if (event_xmp != NULL) continue;
-
-	queue:
+		FALLTHROUGH;
+	    default:
 		/*
 		 * This is a foreign event.
 		 * Queue it for later return to the X event queue.
@@ -629,9 +629,6 @@ XMenuActivate(
 		feq_tmp->event = event;
 		feq_tmp->next = feq;
 		feq = feq_tmp;
-		break;
-	    default:
-		goto queue;
 	    }
     }
     /*
diff --git a/oldXMenu/XMenuInt.h b/oldXMenu/XMenuInt.h
index 86b8e057cd..5d5365ad8f 100644
--- a/oldXMenu/XMenuInt.h
+++ b/oldXMenu/XMenuInt.h
@@ -37,6 +37,8 @@ #define _XMenuInternal_h_
 
 #include <config.h>
 
+#include <attribute.h>
+
 /* Avoid warnings about redefining NULL by including <stdio.h> first;
    the other file which wants to define it (<stddef.h> on Ultrix
    systems) can deal if NULL is already defined, but <stdio.h> can't.  */
-- 
2.35.1


  reply	other threads:[~2022-03-14 20:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-14  9:28 bug#54382: 28.0.92; --with-x-toolkit=no leads to "FALLTHROUGH undefined" in Activate.c Torsten Bronger
2022-03-14  9:52 ` Lars Ingebrigtsen
2022-03-14 20:17   ` Paul Eggert [this message]
2022-03-15  0:29     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-15  1:54       ` Paul Eggert
2022-03-15  2:05         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-14 13:40 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-14 13:49   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-14 14:45     ` Torsten Bronger
2022-03-15  0:30       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a957d8d-4988-d682-00c1-0550d578b6d0@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=54382-done@debbugs.gnu.org \
    --cc=bronger@physik.rwth-aachen.de \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).