From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#35624: log-view-diff regression Date: Fri, 10 May 2019 03:14:34 +0300 Message-ID: <7a87f334-1d60-9d39-959c-97dbad690fc3@yandex.ru> References: <87pnou2ak2.fsf@mail.linkov.net> <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> <874l64raeu.fsf@mail.linkov.net> <87imujju04.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="62774"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: 35624@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 10 02:15:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hOtBt-000GEV-Fo for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 May 2019 02:15:09 +0200 Original-Received: from localhost ([127.0.0.1]:34456 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOtBs-0006cZ-FS for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 May 2019 20:15:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOtBm-0006cR-SW for bug-gnu-emacs@gnu.org; Thu, 09 May 2019 20:15:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOtBm-000310-4R for bug-gnu-emacs@gnu.org; Thu, 09 May 2019 20:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51400) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hOtBm-00030t-15 for bug-gnu-emacs@gnu.org; Thu, 09 May 2019 20:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hOtBl-0005sA-Rv for bug-gnu-emacs@gnu.org; Thu, 09 May 2019 20:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 May 2019 00:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35624 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35624-submit@debbugs.gnu.org id=B35624.155744728822540 (code B ref 35624); Fri, 10 May 2019 00:15:01 +0000 Original-Received: (at 35624) by debbugs.gnu.org; 10 May 2019 00:14:48 +0000 Original-Received: from localhost ([127.0.0.1]:36711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOtBY-0005rT-0o for submit@debbugs.gnu.org; Thu, 09 May 2019 20:14:48 -0400 Original-Received: from mail-lf1-f68.google.com ([209.85.167.68]:46554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hOtBV-0005rF-5s for 35624@debbugs.gnu.org; Thu, 09 May 2019 20:14:47 -0400 Original-Received: by mail-lf1-f68.google.com with SMTP id k18so2816914lfj.13 for <35624@debbugs.gnu.org>; Thu, 09 May 2019 17:14:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=G7N1a48Rx/ZwyyAA+B8QoRGz+xH83/x/9Q9VGKK4Yl0=; b=Qpf7oSWxnHb1PFdELzZO/CoXR2NTxH+eebvhLdB9+1OUfF9eNSLZvRTa9Xp4XsiDCp mqqnuK6qCf/k694nbxT7E0hfLqY6wbiYHfjPhRAYlzTKBjXnLuJEugma+OMXJAIfC3/b wdj9FoW1/zXltPXQBtrtgSnx4QaFOoeM+UkioALnrXNcv30S2i9q8bxe2XBAMETAZBRN 5lfaXwAA4op3O5S1Rm2s9BoopdJbG1DSFG8mTFwyDfaC5X6UuAPe5RQOHt/gsaPHPYnV PonSF/SSnh1dKcmmgf49Qpw6A+DJnViKBRD3cSgCeAP3srksiVbpPcYHVmk5vpEVkoVe VaAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=G7N1a48Rx/ZwyyAA+B8QoRGz+xH83/x/9Q9VGKK4Yl0=; b=NECXWn3worViYu7WkB7P+6MgH3v8JVToCFIRGf+PXrtCKXKV5NVA6pxSocaZIS6Ala 1sZoo4Kp13XhHiC20X9PzAdFXQKKwzLuSDSzIKaiMAi8qEetaGtCE8pYzd1WyglnjukL 83f8bUHbM6U+vQzJk0Yrvg6ZQmysOCTRw7c74KSHPAKrSZOgz3sAKb9ImJuIZV2wbb2l 3f1qkjaztYg9zA8dcsqsYiLT9D7kSxWLIpDCtUokZW9Zf32xL2igzPDIltCRXC0ES50j 8V24I9VDQ080xEXCF5/dXwJZ5WRxAAHfgvHhja8jTdBQCBQ8SjjHRcDgymrA12ZBYHuQ zkzA== X-Gm-Message-State: APjAAAViPgjo2EQ3LkUMCQr5Yan6wrRtHncpL7RSECfDJBPeL1l390an bpqxunGxJJDgok9KM2Xcjth1SF3s X-Google-Smtp-Source: APXvYqyvfVMkvjwxjRwfuqXP0AWVj0/gsr+mLBmB07XW7uvmfiBJpX4FjmGTSKhxXkauc4XTJMreLw== X-Received: by 2002:a19:c50a:: with SMTP id w10mr4048984lfe.163.1557447278687; Thu, 09 May 2019 17:14:38 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id z12sm864327lfh.72.2019.05.09.17.14.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 May 2019 17:14:36 -0700 (PDT) In-Reply-To: <87imujju04.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159010 Archived-At: On 09.05.2019 22:41, Juri Linkov wrote: > Since it's wrong in any case, better to revert it altogether in emacs-26. I kind of think that the feature the last change added is more valuable than the regression (especially if the regression is only triggered when a commit message is expanded). > Actually there is the much needed function log-view-inside-comment-p > for expanded comments, and this patch correctly handles all cases: Great! The patch LGTM. Note that we could write a smaller change using that function, if the goal is to produce as-obvious-as-possible change for emacs-26.