From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#52286: 28.0.90; [PATCH] Be consistent in naming of separators in context menu Date: Sat, 4 Dec 2021 13:57:31 -0800 Message-ID: <7a7d6b5c-ff5e-3d55-bef4-8ce8e163abdb@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------4A51E646EB9F8560DABC9610" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26030"; mail-complaints-to="usenet@ciao.gmane.io" To: 52286@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 04 22:58:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtd2p-0006al-Ec for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Dec 2021 22:58:11 +0100 Original-Received: from localhost ([::1]:60730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mtd2n-0002Nj-Gh for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Dec 2021 16:58:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57942) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtd2g-0002Ld-RY for bug-gnu-emacs@gnu.org; Sat, 04 Dec 2021 16:58:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43997) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mtd2g-0000zS-KE for bug-gnu-emacs@gnu.org; Sat, 04 Dec 2021 16:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mtd2g-0003jK-Ja for bug-gnu-emacs@gnu.org; Sat, 04 Dec 2021 16:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Dec 2021 21:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52286 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.163865505914306 (code B ref -1); Sat, 04 Dec 2021 21:58:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Dec 2021 21:57:39 +0000 Original-Received: from localhost ([127.0.0.1]:55543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtd2J-0003if-00 for submit@debbugs.gnu.org; Sat, 04 Dec 2021 16:57:39 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:34034) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtd2H-0003iY-6E for submit@debbugs.gnu.org; Sat, 04 Dec 2021 16:57:37 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtd2G-0002Ha-UK for bug-gnu-emacs@gnu.org; Sat, 04 Dec 2021 16:57:36 -0500 Original-Received: from [2607:f8b0:4864:20::532] (port=38834 helo=mail-pg1-x532.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mtd2E-0000w1-LT for bug-gnu-emacs@gnu.org; Sat, 04 Dec 2021 16:57:36 -0500 Original-Received: by mail-pg1-x532.google.com with SMTP id s137so6625422pgs.5 for ; Sat, 04 Dec 2021 13:57:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:subject:to:message-id:date:mime-version:content-language; bh=B88urDiJoRDtag7p7LI3GhO1hfBcuHOom4GrP4r4Ors=; b=pmTLmbqNto7wDnJ2TLoivoPY7R+pkGwLnGfVlI3aNeNmkzUeqXSlKjHLakR9Q/2eDX Qvvjp+lri3WbDl+xbJvUKfjlbPMdRs4IeddEjO8AC4cqoXioIomqMmFDLSOKx5aXsXyl bGKt225dq12ktzoSzkc9GaPuYtilFKLJsB0hANJo0sK67bpLFE2PFVF2nyERvGzZvpfv uSpzIuimYLCFUZUhGxJtwUWRlqp7vuvXjdSBgX51K6QbTjb98ngij0rWAai/FjU+MRpe BVz1otB1K0NZOtABSCNMVnf+h9BFXhDLZBF4+Yb1FZIIl9O5XNsd4BC99vecCjhWywRt C9Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:subject:to:message-id:date:mime-version :content-language; bh=B88urDiJoRDtag7p7LI3GhO1hfBcuHOom4GrP4r4Ors=; b=aD3lwdaoyaehA26uSINX8hH9G6M59LZzx3EeWa7xiup3fUNjAH8rq6J7ty+aJV77rh eRPhkRHWqlgM5P3TWavJPboI33ReATq47DnCmaV20IJFnomtngbG/OT1MAESfnnYE7Og LXGMjMqucGe+jrtq1kQxFgsW6xNa4Mpi9KwTvxoM0KU2deBPBFAdUuwxfKsRgKKcypcd o6IEAWmkHncEO7qHVeCT/wF8EKJZ5s6ehQk1ovGmIbgDjxTb2o2lch+QLAI4nOsTJz/W MBMf862dW+wjNgSmINFIUSpoww3ZV4/QT11RKbtiA/d130wnJXsH3Zf4MGQ7Eee0b+iA h2mg== X-Gm-Message-State: AOAM533g0yxNn1mFEnGE8oo/dOUNqO9RL6tmuQKbxs37HoES3ARPuKiu e+fpEfROo/tZBe66ZMMFaYU927ub5AA= X-Google-Smtp-Source: ABdhPJzQDIP32P/RBbcwHBZaGn/p68v0NPX7+c9LD3BKOxZ52tu2D4L5FdR0z2Ez6r2qTlZeLobWMQ== X-Received: by 2002:a65:621a:: with SMTP id d26mr11168071pgv.410.1638655052804; Sat, 04 Dec 2021 13:57:32 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id na13sm6154623pjb.11.2021.12.04.13.57.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Dec 2021 13:57:32 -0800 (PST) X-Mozilla-News-Host: news://news.gmane.org:119 Content-Language: en-US X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::532 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::532; envelope-from=jporterbugs@gmail.com; helo=mail-pg1-x532.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221526 Archived-At: This is a multi-part message in MIME format. --------------4A51E646EB9F8560DABC9610 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit This is spun off from bug#52237[1]. There's a minor issue with `context-menu-mode' where some of the separators are named `FOO-separator' and others are named `separator-FOO'. Since these separators are partially useful for context menu functions to find the right place to insert their items, this inconsistency could be pretty confusing for authors of those functions (e.g. in third-party packages). This patch renames the separators to `FOO-separator' following the logic in the above-linked comment (in short, `FOO' is a noun adjunct modifying the actual object: a separator). To verify that I changed all the appropriate places and didn't miss anything, I ran the following command and manually looked over all the results to eliminate false positives: ag '(?