From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#65386: [PATCH] ; Refine some 'package-vc' docstrings Date: Sun, 20 Aug 2023 16:24:21 -0300 Message-ID: <7a0f6dcb-3e56-8009-3f54-bb7b9fb6fce3@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36969"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Philip Kaludercic , Eli Zaretskii , 65386@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 20 21:25:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXo31-0009N6-0X for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Aug 2023 21:25:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXo2o-00044d-N1; Sun, 20 Aug 2023 15:25:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXo2m-00043w-NU for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 15:25:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXo2m-0000AS-Fl for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 15:25:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qXo2o-0004iO-6k for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 15:25:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Aug 2023 19:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65386 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65386-submit@debbugs.gnu.org id=B65386.169255947318086 (code B ref 65386); Sun, 20 Aug 2023 19:25:02 +0000 Original-Received: (at 65386) by debbugs.gnu.org; 20 Aug 2023 19:24:33 +0000 Original-Received: from localhost ([127.0.0.1]:54885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXo2L-0004he-EK for submit@debbugs.gnu.org; Sun, 20 Aug 2023 15:24:33 -0400 Original-Received: from mail-ot1-x32b.google.com ([2607:f8b0:4864:20::32b]:62572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXo2J-0004hP-Jx for 65386@debbugs.gnu.org; Sun, 20 Aug 2023 15:24:32 -0400 Original-Received: by mail-ot1-x32b.google.com with SMTP id 46e09a7af769-6bc9c01e154so1999294a34.0 for <65386@debbugs.gnu.org>; Sun, 20 Aug 2023 12:24:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692559464; x=1693164264; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=z4q92EKIDYkT/V/GX7C9v0vCpdLpFqndaNs/LzwayHk=; b=dz1/p4mpA0yCmncT805LIum6PTBNygF+L3UVhK8TBYbZ3ZH8+1eHL7vKclNBLycx7f uC9QSW+LlHKQ55YWFUeIFtUC80fVtg4OKkhkfm/hjuhekMbJctzQSsrS09zH47LPyOkt EOUC+708jX5LtWg3pO4VgqYH4jVLyXP7WHLVfrjXhCV/28dg9P76c7nc9UPDRgADLM+h sg6hF3SDw2wjV9d5XZ4EbYIG12h6s/RwlFbjvBlAW56/XirO9Il/8Vi73fmyw2fKQUZR LpLrQB171Yc25FpCSfUwBG+W709cbG9oAD21xFSqoEVy1MvYe8rwtY1ckfXV+WX+NG+h Ftpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692559464; x=1693164264; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=z4q92EKIDYkT/V/GX7C9v0vCpdLpFqndaNs/LzwayHk=; b=JOlaMtoAIttjHN/vevsW1pvM1V3tLEX04038QXCeCT0uY3rEGkdXNSTsE/njZbUyAt Dn9vFU/CURG/5dvHwXEVzPTZa3kF9Us7SgEllwm+OUEIZsBN5I/Zi40aFxaSHCWgYFoi JrD03qGLP63on9FhoYSb+0pdArDTfOIfyKgf3XiMFBguwXAMZlDntCVuicLH3JMLM1VE /vidptEDMJQ0aFtHTJK7iIfaJTDdrtOGpkXC9EjYbKTTYXnJunqmQxSBWPpy9kyQHYOI QC93PP78PiayUxGUBiXqBqACsnaJj780l77w12qJkmz1bRBDenpQazqeXPzbmX/MvOgM ajYQ== X-Gm-Message-State: AOJu0Ywstsb4uai7rTQ9nKo7Xh+6nXdboH/tw9Ho0i+bEKvjE0sE/pyg uYHlMxIHCvoaRoxPGrs4OzM= X-Google-Smtp-Source: AGHT+IEHTc4XRylEEv7nIniULkYq9EKaPFS90ZpUhI3hLgqFQzzPrVfhwfShfPtthTmxezXoXwMApA== X-Received: by 2002:a05:6870:e40d:b0:1bf:4aed:b8db with SMTP id n13-20020a056870e40d00b001bf4aedb8dbmr3362411oag.26.1692559464101; Sun, 20 Aug 2023 12:24:24 -0700 (PDT) Original-Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id d15-20020a056871040f00b001b3652adccdsm3409048oag.21.2023.08.20.12.24.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Aug 2023 12:24:23 -0700 (PDT) Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268029 Archived-At: Eshel Yaron writes: > Philip Kaludercic writes: > >> Eshel Yaron writes: >> >>>> Also, would it make sense to determine this at compile-time?  On the >>>> other hand, if a VC backend is installed later on from ELPA, we would >>>> want the custom type to reflect this. >>> >>> Yes, I couldn't find a way to defer computing the set of candidates to >>> "customization type", I'm not sure if that even makes total sense.  I >>> think it's not that crucial since someone adding a VC backend and >>> immediately trying to customize these options seems to me like a very >>> minor edge case, and we had the same issue prior to my patch anyhow. >> >> Likely yes, but if we have two mostly equivalent solutions, I think that >> flexibility without having to restart Emacs is preferable to performance. >> > > Hmm I'm not sure I completely follow.  Which two solutions do you have > in mind?  I agree that it would be nice have the `:type` updated if the > user adds a relevant VC backend, but I don't think `defcustom` supports > something like that.  How do you propose to achieve that flexibility? I haven't watch this thread closely, but do note that creating dynamic choices is quite possible, if I understand correctly what you're looking for. If you can, take a look at the defcustom of completion-styles, in minibuffer.el.  Its type uses a choice with a specialized :convert-widget function to keep the choices up-to date.