From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 60001@debbugs.gnu.org, "Daniel Martín" <mardani29@yahoo.es>
Subject: bug#60001: [PATCH] Improve completion of treesit-check-indent command
Date: Sat, 7 Jan 2023 15:13:54 -0800 [thread overview]
Message-ID: <7FDC90A2-7616-434D-9737-4463F083C3F2@gmail.com> (raw)
In-Reply-To: <m1wn6wj3lf.fsf@yahoo.es>
Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Mon, 12 Dec 2022 11:53:00 +0100
>> From: Daniel Martín via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>> The treesit-check-indent command is not really related to Tree-sitter
>> and could be in a more general place than treesit.el. WDYT?
>
> I agree, but then we'd need a definition for it that doesn't need
> tree-sitter support. Is that easy to provide?
>
>> In any case, I have a patch to improve this command a bit by offering
>> more accurate completion for major modes, not Emacs commands. I have
>> also tried to improve its documentation a bit.
>
> How about a read-major-mode function in subr.el?
>
> But I think all these generalizations and improvements should go to
> master. On the release branch, I'd prefer to leave
> treesit-check-indent alone.
Has this patch been pushed to master? Should I close this report?
Yuan
next prev parent reply other threads:[~2023-01-07 23:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m1wn6wj3lf.fsf.ref@yahoo.es>
2022-12-12 10:53 ` bug#60001: [PATCH] Improve completion of treesit-check-indent command Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-12 14:00 ` Eli Zaretskii
2023-01-07 23:13 ` Yuan Fu [this message]
2023-01-08 11:53 ` Eli Zaretskii
2023-09-04 20:02 ` Stefan Kangas
2023-09-05 10:51 ` Eli Zaretskii
2023-09-05 20:40 ` Stefan Kangas
2023-09-06 6:53 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7FDC90A2-7616-434D-9737-4463F083C3F2@gmail.com \
--to=casouri@gmail.com \
--cc=60001@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=mardani29@yahoo.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).