From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Newsgroups: gmane.emacs.bugs Subject: bug#15138: revno: 114089 change causes cjk characters not shown correctly Date: Thu, 5 Sep 2013 18:34:19 +0200 Message-ID: <7F96315D-1DED-4D34-BA84-73BC9BAF0E77@swipnet.se> References: <87hadzidj0.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1378398920 14880 80.91.229.3 (5 Sep 2013 16:35:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 5 Sep 2013 16:35:20 +0000 (UTC) Cc: 15138-done@debbugs.gnu.org, darren.hoo@gmail.com To: Kenichi Handa Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 05 18:35:19 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VHcWc-0006Mg-LV for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Sep 2013 18:35:18 +0200 Original-Received: from localhost ([::1]:60994 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHcWc-0007fD-7K for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Sep 2013 12:35:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHcWT-0007T6-88 for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2013 12:35:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VHcWN-0004Bp-F2 for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2013 12:35:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33816) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VHcWN-0004Ak-B2 for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2013 12:35:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VHcWM-0004oP-Cn for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2013 12:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Sep 2013 16:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15138 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15138-done@debbugs.gnu.org id=D15138.137839886718454 (code D ref 15138); Thu, 05 Sep 2013 16:35:02 +0000 Original-Received: (at 15138-done) by debbugs.gnu.org; 5 Sep 2013 16:34:27 +0000 Original-Received: from localhost ([127.0.0.1]:42108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VHcVm-0004nZ-S7 for submit@debbugs.gnu.org; Thu, 05 Sep 2013 12:34:27 -0400 Original-Received: from mail01.bdtv.se ([176.10.222.34]:46746) by debbugs.gnu.org with smtp (Exim 4.80) (envelope-from ) id 1VHcVi-0004nP-OK for 15138-done@debbugs.gnu.org; Thu, 05 Sep 2013 12:34:24 -0400 Original-Received: (qmail 11133 invoked by uid 89); 5 Sep 2013 16:34:20 -0000 Original-Received: from h-46-59-42-57.na.cust.bahnhof.se (HELO coolsville.localdomain) (boel.djarv@bdtv.se@46.59.42.57) by mail01.bdtv.se with ESMTPA; 5 Sep 2013 16:34:20 -0000 Original-Received: from anon-51-195.vpn.ipredator.se (unknown [46.246.51.195]) by coolsville.localdomain (Postfix) with ESMTPSA id C1DDD1A026F; Thu, 5 Sep 2013 16:34:19 +0000 (UTC) In-Reply-To: <87hadzidj0.fsf@gnu.org> X-Mailer: Apple Mail (2.1508) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78005 Archived-At: Hello. 5 sep 2013 kl. 15:49 skrev Kenichi Handa : > In article <7FEF1248-81A6-4E06-8F08-29A02CE72E00@swipnet.se>, Jan = Dj=C3=A4rv writes: >=20 >> Good, closing. >=20 > I have another question about this change. >=20 > /* Fonts often have characters in other scripts, like symbol, = even if they > don't match script: symbol. So check if the character is = present > in the current face first. Only enable for NS for now, but = should > perhaps be general? */ > Lisp_Object font_object; > XSETFONT (font_object, face->font); > if (font_has_char (f, font_object, c)) return face->id; >=20 > With it, face->font may vary depending on the preceding > character. So if you have these lines: > abc=E2=80=A2 > =E3=81=82=E3=81=84=E3=81=86=E2=80=A2 > the two "=E2=80=A2"s will be displayed by different fonts. Isn't it > better to try the font selected for ASCII as this: >=20 > XSETFONT (font_object, face->ascii_face->font); I don't know, I never had that situation. I guess if the goal is to = show same glyphs, ascii_face->font is a better choice. But if it is to = have a consistent look with the surrounding text, it it not. Consider a buffer where only =E3=81=82=E3=81=84=E3=81=86=E2=80=A2 is = entered. I would assume the current font would be a better choice in = this case. Jan D.