From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#60197: 30.0.50; beginning-of-defun broken after new treesit impl Date: Tue, 20 Dec 2022 22:50:04 -0800 Message-ID: <7C88E19F-63AC-4551-AC06-D2B067990A5A@gmail.com> References: <87edsv7lc4.fsf@thornhill.no> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34921"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60197@debbugs.gnu.org To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 21 07:51:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7swl-0008sH-0s for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Dec 2022 07:51:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7swT-0007ky-HL; Wed, 21 Dec 2022 01:51:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7swR-0007kc-6f for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2022 01:51:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7swQ-0004Dd-Is for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2022 01:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p7swQ-0002s9-D2 for bug-gnu-emacs@gnu.org; Wed, 21 Dec 2022 01:51:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87edsv7lc4.fsf@thornhill.no> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Dec 2022 06:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60197 X-GNU-PR-Package: emacs Original-Received: via spool by 60197-submit@debbugs.gnu.org id=B60197.167160541411031 (code B ref 60197); Wed, 21 Dec 2022 06:51:02 +0000 Original-Received: (at 60197) by debbugs.gnu.org; 21 Dec 2022 06:50:14 +0000 Original-Received: from localhost ([127.0.0.1]:49838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7sve-0002rq-3P for submit@debbugs.gnu.org; Wed, 21 Dec 2022 01:50:14 -0500 Original-Received: from mail-pl1-f181.google.com ([209.85.214.181]:33413) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7svc-0002ri-Fd for 60197@debbugs.gnu.org; Wed, 21 Dec 2022 01:50:13 -0500 Original-Received: by mail-pl1-f181.google.com with SMTP id 17so14696095pll.0 for <60197@debbugs.gnu.org>; Tue, 20 Dec 2022 22:50:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=awE6Jh7RYtG087wk6fLC2RICqut+wwGbJ8Ky+Vbqgso=; b=KDsIk1nLytQJyh9ibAQ2/nu9PQv3hEtPnT7xcLMjhMSijHAwaoAIrmfAlOMy6nw41m OrLDTII2N4CT44Cl4tLAJN6i34xSje5vJ/Tye2Qqs7CzX2OT3/NHfe20Cq+wxHFHYdaJ SPM/qIZrT7k9boDejcIp90XtcKvbrKTV0jMzfjRvRzFlQlEncbJK/62ljdcK6yAxSQJj KboFysVxnkEVEMBdh/hdO6GI/dBRy3OW8P1VfjjYXoz7fM3nAHtiMBsaTEVW3kGS3g0P QE7QrO3LMxKvYoMXyQpG2zhARCzsDYmOx9K65P1+YKyZIiL8xPUjVpl7sE0Ul26rEIFC 29rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=awE6Jh7RYtG087wk6fLC2RICqut+wwGbJ8Ky+Vbqgso=; b=PAmXwue5DBwlB/ALs4PKM+cIji0pia85FSkLFmOt84SQ5UA9rS3aPtCoPpK4I6cHiM F3fG3irwuPAM/n9OD3VjvB26DdkNRgg9O1LKw/ieYkGIasBDo08JvhuA/Kv31vcZpNQy a9Z2SluCPzfrrJWQKJLWvRdYpWB8eQFYslvr26gDvZl/APYEKOwwOpA7QjP0r6zNZrIX P0ojv7Yh9E7LYurWqaQI0JjW2RD5uA6HH9NoDNNelIkP/tU0KHegoNZfGd/gnJmfkHCX K9inF+0koBAhUn1XevBMxIgP/J7akkSxMaSu83OwCjLyvIrQJ98QUOchQklsLzBThq8r GINA== X-Gm-Message-State: AFqh2krKbOptFm191DWSSaLKa2jnLQyzCZT6WSKitByms63aeKUKcs/w WsgHJPBdYAuRPTgOuR9NU/E= X-Google-Smtp-Source: AMrXdXuC0nNkeb4HSbAK30xHr20LVTLlmF3WMbXLYBB95PqMtakWhnzncQpTGPoQTE2NdQg6Sbjq9g== X-Received: by 2002:a17:902:6bca:b0:189:d8fb:152d with SMTP id m10-20020a1709026bca00b00189d8fb152dmr723219plt.25.1671605406360; Tue, 20 Dec 2022 22:50:06 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id b12-20020a170903228c00b00186c3afb49esm10556827plh.209.2022.12.20.22.50.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Dec 2022 22:50:05 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251569 Archived-At: Yuan Fu writes: > Theodor Thornhill writes: > >> Hi, Yuan! >> >> It seems 'prog-fill-reindent-defun' is broken after the latest = changes >> to treesit-beginning-of-defun. The culprit is that we now use remap >> instead of setting the beginning-of-defun-function. What is the >> reasoning behind that change? Can't we just rely on the variable >> beginning-of-defun-function? > > Not really, end-of-defun uses beginning/end-of-defun-function in a way > that=E2=80=99s incompatible with nested defuns[1]. So if we want to = support > navigation nested defuns reliably we need to remap the commands = instead. > In the future (ie emacs 30), we can extend the current > beginning/end-of-defun to support nested defuns, then we don=E2=80=99t = need to > remap the commands anymore. I see the problem now... Many other functions uses beginning/end-of-defun. I didn=E2=80=99t thought about that initially = :-( But I don=E2=80=99t want to make big changes to beg/end-of-deun, hmmm. Yuan