bug#56249: 29.0.50; Compilation buffer parsing "ERROR:" incorrectly

["Mattias Engdegård" <mattiase@acm.org>]

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]

5 juli 2022 kl. 18.50 skrev Lars Ingebrigtsen <larsi@gnus.org>:

> Feel free to add tests, by all means.

Sorry about the delay; here is what it might look like. It's all very hand-wavy and cut-and-paste because I don't really know what it's for or even what to call it. The message pattern I suggested was an expedience intended for individual Emacs customisation; I doubt it's of Emacs release quality.

Normally I try to track down the source code and exact location of the code that emits the message, to get a feeling for what the varying parts are -- for example in this case, can the word "ERROR" be "WARNING" or something else? Are there variants? Is the code stable? Is the leading whitespace always the same? And so on. But I didn't really intend to dive through all of Gradle and the Android tools; someone else probably knows much more about it.


[-- Attachment #2: gradle-android-compile-tests.diff --]
[-- Type: application/octet-stream, Size: 2216 bytes --]

diff --git a/etc/compilation.txt b/etc/compilation.txt
index 111b2a37dc..fc254dd3d7 100644
--- a/etc/compilation.txt
+++ b/etc/compilation.txt
@@ -193,6 +193,15 @@ symbol: gradle-kotlin
 e: /src/Test.kt: (34, 15): foo: bar
 w: /src/Test.kt: (34, 15): foo: bar
 
+* Gradle Android resource linking
+
+symbol: gradle-android
+
+Execution failed for task ':app:processDebugResources'.
+> A failure occurred while executing com.android.build.gradle.internal.res.LinkApplicationAndroidResourcesTask$TaskAction
+   > Android resource linking failed
+     ERROR:/Users/salutis/src/AndroidSchemeExperiment/app/build/intermediates/incremental/debug/mergeDebugResources/stripped.dir/layout/item.xml:3: AAPT: error: '16dpw' is incompatible with attribute padding (attr) dimension.
+
 
 * IAR Systems C Compiler
 
diff --git a/test/lisp/progmodes/compile-tests.el b/test/lisp/progmodes/compile-tests.el
index 774370be4c..36bdbe4c91 100644
--- a/test/lisp/progmodes/compile-tests.el
+++ b/test/lisp/progmodes/compile-tests.el
@@ -260,6 +260,9 @@ compile-tests--test-regexps-data
      "e: e:\\src\\Test.kt: (34, 15): foo: bar" 4 15 34 "e:\\src\\Test.kt" 2)
     (gradle-kotlin
      "w: e:\\src\\Test.kt: (11, 98): foo: bar" 4 98 11 "e:\\src\\Test.kt" 1)
+    (gradle-android
+     "     ERROR:/Users/salutis/src/AndroidSchemeExperiment/app/build/intermediates/incremental/debug/mergeDebugResources/stripped.dir/layout/item.xml:3: AAPT: error: '16dpw' is incompatible with attribute padding (attr) dimension."
+     1 nil 3 "/Users/salutis/src/AndroidSchemeExperiment/app/build/intermediates/incremental/debug/mergeDebugResources/stripped.dir/layout/item.xml" 2)
     ;; Guile
     (guile-file "In foo.scm:\n" 1 nil nil "foo.scm")
     (guile-line "  63:4 [call-with-prompt prompt0 ...]" 1 4 63 nil)
@@ -492,7 +495,7 @@ compile-test-error-regexps
           (compilation-num-warnings-found 0)
           (compilation-num-infos-found 0))
       (mapc #'compile--test-error-line compile-tests--test-regexps-data)
-      (should (eq compilation-num-errors-found 97))
+      (should (eq compilation-num-errors-found 98))
       (should (eq compilation-num-warnings-found 35))
       (should (eq compilation-num-infos-found 28)))))