From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#60321: 29.0.60; ruby-mode indentation of hash or array as first arg in multiline method call Date: Mon, 2 Sep 2024 22:01:05 +0300 Message-ID: <79c2bec9-ceea-4bca-834e-245a9f2c756a@yandex.ru> References: <1191195d-1528-dc2a-64e0-15426e4b5608@yandex.ru> <75342f40-d576-e1c6-3d63-692b80e78bfe@yandex.ru> <90f8ce9c-4a60-4af9-8ed7-eeddff557129@yandex.ru> <2345189c-0033-4357-841c-1a6c7bc51a3c@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14834"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 60321-done@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 02 21:02:39 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1slCJz-0003i1-Ju for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Sep 2024 21:02:39 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1slCJR-0006aK-4f; Mon, 02 Sep 2024 15:02:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slCJO-0006ZK-66 for bug-gnu-emacs@gnu.org; Mon, 02 Sep 2024 15:02:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1slCJN-00017F-64 for bug-gnu-emacs@gnu.org; Mon, 02 Sep 2024 15:02:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=I5HrfIr7bGXVgh9s+7loUI9YBw52v0eCyis/0SpA90E=; b=VRow1nCG5r0orBx3+Iyp8PqldLgfWt/8f9xAbd6FYBYGY/1DzUoKvHWVl324zBBweMzKRnczxbuetrxZ9cobgIBJpHxkyewgEv+cwhibuvqdjZ/Tj96kwsvMSq/PaJI50m9/9aEOphAttLqmXks4E0ZC5dmSvnSh5bAawZysnsL8oqj4eLDWerk+qKI+xUmf+3AVYs0D1s4QkBs7W3vv/x4MzUsl/c3t4RH/Y/00gkYWYcMGQAcdKTevyyEer6vxiykbH36tGOckshbhbw9OY2yutciQkfE462BIS1Oz/ZuQ4lcFm+7tPrDn0Ag8Jw+IXESw+fQUccj+htSWrvA88w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1slCKM-0001rz-Bx for bug-gnu-emacs@gnu.org; Mon, 02 Sep 2024 15:03:02 -0400 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Sep 2024 19:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 60321 X-GNU-PR-Package: emacs Mail-Followup-To: 60321@debbugs.gnu.org, dgutov@yandex.ru, dgutov@yandex.ru Original-Received: via spool by 60321-done@debbugs.gnu.org id=D60321.17253037687145 (code D ref 60321); Mon, 02 Sep 2024 19:03:02 +0000 Original-Received: (at 60321-done) by debbugs.gnu.org; 2 Sep 2024 19:02:48 +0000 Original-Received: from localhost ([127.0.0.1]:52404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slCK8-0001rB-B4 for submit@debbugs.gnu.org; Mon, 02 Sep 2024 15:02:48 -0400 Original-Received: from forward501d.mail.yandex.net ([178.154.239.209]:46756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slCK5-0001qo-Tz for 60321-done@debbugs.gnu.org; Mon, 02 Sep 2024 15:02:47 -0400 Original-Received: from mail-nwsmtp-smtp-production-main-19.klg.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-19.klg.yp-c.yandex.net [IPv6:2a02:6b8:c42:3143:0:640:c03:0]) by forward501d.mail.yandex.net (Yandex) with ESMTPS id E882F60CB1; Mon, 2 Sep 2024 22:01:11 +0300 (MSK) Original-Received: by mail-nwsmtp-smtp-production-main-19.klg.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id 91gGFN0TkiE0-IBXNJRe6; Mon, 02 Sep 2024 22:01:11 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1725303671; bh=I5HrfIr7bGXVgh9s+7loUI9YBw52v0eCyis/0SpA90E=; h=In-Reply-To:From:Subject:Message-ID:Cc:References:Date:To; b=nL+itK7/zEpDknEAO2wYyGq4eYOXOd7NrFRpWnLL62vdOoYJMParaCGn2fBqYcWqM iV2RCaY5SgkAhuiF3+J+mMn1+pGW0yyvZEyOW73jp4mcpZSN2M6Z641iDL1xm/jZYc 9QpUlU+FAUeRzuiPDVVX7uMQ7tgKEcVWR1Nx0LC8= Authentication-Results: mail-nwsmtp-smtp-production-main-19.klg.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: from phl-compute-03.internal (phl-compute-03.nyi.internal [10.202.2.43]) by mailfauth.nyi.internal (Postfix) with ESMTP id 50D4E120006A; Mon, 2 Sep 2024 15:01:09 -0400 (EDT) Original-Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Mon, 02 Sep 2024 15:01:09 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudehfedgudefvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddv jeenucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughguhhtohhvseihrghnuggvgi drrhhuqeenucggtffrrghtthgvrhhnpeeihfejueevteffffdvfeetffffkefhuedujeei heehiedulefghefgffefudffudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpegughhuthhovhdomhgvshhmthhprghuthhhphgvrhhsohhnrghl ihhthidqudeffeefleelheehvddqvdelgeejjeejjeeiqdgughhuthhovheppeihrghnug gvgidrrhhusehfrghsthhmrghilhdrtghomhdpnhgspghrtghpthhtohepvddpmhhouggv pehsmhhtphhouhhtpdhrtghpthhtoheprggrrhhonhhjvghnshgvnhesghhmrghilhdrtg homhdprhgtphhtthhopeeitdefvdduqdguohhnvgesuggvsggsuhhgshdrghhnuhdrohhr gh X-ME-Proxy: Feedback-ID: ib1d9465d:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 2 Sep 2024 15:01:08 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291120 Archived-At: On 02/09/2024 04:56, Aaron Jensen wrote: >> It seems to me that anything other than 0 spaces would look inconsistent >> with the first element (the hash), and its closing brace in particular. > Yeah, that's my sense as well, even if it looks awful, but you get what you get. > >>>> * Support for the new option in ruby-ts-mode (it's good to have parity). >>>> Could you take the attached patch for a spin? Seems to work here, but >>>> I'd like to have an extra confirmation. >>> I don't have the treesitter stuff installed at the moment, will try >>> this out shortly. >> Thanks in advance. > I installed it and gave it a run on a few things. I didn't observe any > issues with it. Great! I've pushed both patches to emacs-30 (6c15b7710d4 and 24f12bdd77e) and now marking the issue as done. Thanks again for the patch. To summarize for future readers: the default behavior doesn't change - at least not now - you need to customize the option for different indentation.