From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#48471: 28.0.50; Incorrect handling of `project-ignores' on macOS (BSD find?) if project root is a directory name Date: Tue, 18 May 2021 02:06:51 +0300 Message-ID: <79c2002a-e404-3837-f2d8-c760ed48cdc0@yandex.ru> References: <7f9e984c-bea9-f55f-526a-680a9bb3f66b@yandex.ru> <53E1AC7F-1D49-4845-8DF6-4CB24BC15E6A@gmail.com> <92AAB1AE-0D8C-4C2B-99E9-E790F4BE5330@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7811"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 Cc: 48471@debbugs.gnu.org To: Philipp Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 18 01:08:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1limLK-0001qG-Sm for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 May 2021 01:08:10 +0200 Original-Received: from localhost ([::1]:38842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1limLJ-00075x-SJ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 May 2021 19:08:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39282) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1limLD-00075l-1M for bug-gnu-emacs@gnu.org; Mon, 17 May 2021 19:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42481) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1limLC-0004Zx-Mf for bug-gnu-emacs@gnu.org; Mon, 17 May 2021 19:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1limLC-0006qY-GA for bug-gnu-emacs@gnu.org; Mon, 17 May 2021 19:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 May 2021 23:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48471 X-GNU-PR-Package: emacs Original-Received: via spool by 48471-submit@debbugs.gnu.org id=B48471.162129282426255 (code B ref 48471); Mon, 17 May 2021 23:08:02 +0000 Original-Received: (at 48471) by debbugs.gnu.org; 17 May 2021 23:07:04 +0000 Original-Received: from localhost ([127.0.0.1]:54027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1limKG-0006pP-5u for submit@debbugs.gnu.org; Mon, 17 May 2021 19:07:04 -0400 Original-Received: from mail-wr1-f54.google.com ([209.85.221.54]:43978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1limKB-0006oq-HD for 48471@debbugs.gnu.org; Mon, 17 May 2021 19:07:03 -0400 Original-Received: by mail-wr1-f54.google.com with SMTP id p7so4341456wru.10 for <48471@debbugs.gnu.org>; Mon, 17 May 2021 16:06:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0Z/iu5lub8MDOm/1/mJ9/16snRvaucU65Fa+EBCbcSQ=; b=fHvmwnUukabQpfE9qsH8lWfEbyrYoIEzMMUaVy9gwdzItfTWrOwfuKl6nCMvzkHFLK ifVj5OOiJUc9//q8KdVqLn+Md2PfZWBb4apOk+R50+kKJkLSgi9ULg4IGtqGJ+SzhGO6 P5TRyXC4rIaj/JmjwtHEFMGE0dxHvXARwz4qErhOPfhhVoFOkR1vH0Bx8E3wUDGqaVDw gK8wTFHn7KnIpzIJge8QAJM1Ygs06hDj93WkncmYO0gu+EJwdb8DzXfkuaPoK6eCyHZW WaEdFfoShrsPRf63dTwMUmFpbgZUoKC2Ox6v0/k4ElHtYtKOagWBVuAamTtT9MV1h0JR //1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0Z/iu5lub8MDOm/1/mJ9/16snRvaucU65Fa+EBCbcSQ=; b=LpyW/3Pjia5Cj1Z9tR7A36C/aejrqYhPn64dsYL6X1I4vRTgqpi5E5RZncNUCtcO5S e8CXhC77qsLY1eqmn0nZv39bhPjuWDc7DtorGVmoHJclYNp/gygRi1HbVqQgNfCTAexq emGEh7GigWsFX7vCSOINR3XJb4YCwdOnP6T+IagdRP9BsOyEpZH5p2ygGCJ95Wug3CN4 9NMUW0RiP7p++9nsDVdi//8tviXGfkNx08Hgs3PMnL06ouAPvzcfPEmbzoRS3s7NW7gA rvl5nJF5N1sisEoV9/zENVE91kwEEPDAHEpbvlahFx2hrp+69RTSPo4ch1UZxsJwKPk+ 3hhw== X-Gm-Message-State: AOAM533XmisDGMZayYhD5e/KCKe9CmWjuBCmBLHpGtAmiyCZt+IHy7LI UzGRnyoWHbWY5N0jce+Xkxz4iTX7FbY= X-Google-Smtp-Source: ABdhPJytgDYBrZYYO5a1hrNGd4gzWg4UuFTCVn1T8n28nM2TwP9wOeWaLlXAXn+ec3kOUTpvmQannA== X-Received: by 2002:a5d:670c:: with SMTP id o12mr2461776wru.223.1621292813673; Mon, 17 May 2021 16:06:53 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id m11sm18926850wri.44.2021.05.17.16.06.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 May 2021 16:06:52 -0700 (PDT) In-Reply-To: <92AAB1AE-0D8C-4C2B-99E9-E790F4BE5330@gmail.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206752 Archived-At: On 17.05.2021 23:02, Philipp wrote: > The attached patch fixes both unit tests for project.el on my macOS system. Thanks, now I think I understand the problem. And you're suggesting the alternative solution also proposed previously in the https://lists.gnu.org/archive/html/emacs-devel/2021-01/msg00156.html discussion. Please go ahead with the patch, though it would be better to use a version of it which fixes the same behavior in two other related functions as well. The previous patch for that approach is here: https://lists.gnu.org/archive/html/emacs-devel/2021-01/txtDduOxGoiGz.txt (From the message https://lists.gnu.org/archive/html/emacs-devel/2021-01/msg00345.html). Also, since it will fix the double-slash problem, we can undo the change from 331e40a8fd491ceb35c08a3345785dab61bc60d9, the one that made our comparisons lax (to match both single and double slashes).