From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Date: Sat, 4 Feb 2023 12:59:10 +0100 Message-ID: <792EC2CE-006B-42F1-81C2-453E71C2173C@gmail.com> References: <316aee65-50c6-9dad-5b8d-08d90675c5a5@secure.kjonigsen.net> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.14\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9575"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, 61104@debbugs.gnu.org, Theodor Thornhill , Eli Zaretskii To: jostein@kjonigsen.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 04 13:00:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pOHDW-0002LO-Az for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Feb 2023 13:00:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pOHDB-0000hf-TR; Sat, 04 Feb 2023 07:00:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOHD9-0000hK-Hp for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2023 07:00:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pOHD9-0007pT-5E for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2023 07:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pOHD8-0003fW-MZ for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2023 07:00:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <316aee65-50c6-9dad-5b8d-08d90675c5a5@secure.kjonigsen.net> Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Feb 2023 12:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61104 X-GNU-PR-Package: emacs Original-Received: via spool by 61104-submit@debbugs.gnu.org id=B61104.167551196314022 (code B ref 61104); Sat, 04 Feb 2023 12:00:02 +0000 Original-Received: (at 61104) by debbugs.gnu.org; 4 Feb 2023 11:59:23 +0000 Original-Received: from localhost ([127.0.0.1]:40796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOHCU-0003e4-Nn for submit@debbugs.gnu.org; Sat, 04 Feb 2023 06:59:23 -0500 Original-Received: from mail-ed1-f51.google.com ([209.85.208.51]:46927) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOHCQ-0003dn-NG for 61104@debbugs.gnu.org; Sat, 04 Feb 2023 06:59:21 -0500 Original-Received: by mail-ed1-f51.google.com with SMTP id cw4so7384416edb.13 for <61104@debbugs.gnu.org>; Sat, 04 Feb 2023 03:59:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=jAd4w1izv7cs1QeudlDsvlWhSafop+GAACEr0Kt2uf0=; b=LYe8VvonoXrt+Zvqxo7TnP9aq1jiyIqKabDHkA2ZBDeqz4TA4LYOkNdeb+82uQAJnV SD5Z27oCCeoqZbuHyAY5XfTSpxRaXLmI/YtlMLETSEL0UUrUmKyu9DMsMowOlxY1qFrP 2Zx407ZIgN1pG8c1/Pih8BfGGJGF42a17P2tnzaIHNvh1eARxVkE8/iBehxFRHo+HNzw 7n8PCygqgX2J3nkfFZ1+T/e54uAl61kXw343G9kJESC/NgRp92E1VMdA17QVct3UTMel KaVbXT7mxFUpQyWVYx0ysQZ1COf6j4ZB/sBxCgFZCqpRj0vQLDI+7O8T9jY/P5Ukx/EQ eRTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jAd4w1izv7cs1QeudlDsvlWhSafop+GAACEr0Kt2uf0=; b=TooqZlI4LrtEtjRU2rj32EKFnhlXYIT+FQhipARx9o2jV4jOZUVJkYu1J1XpgkVNXH ioq8HLhyFO3yDcljwD9du1BpoJb48XIaWEaScO64nGMrl5TwfckN74zSIMf8KEmklOUU CFRaihbVrBpTzdbfXBHSBB7eX9UmHO4QwB+fn+rUUfr5A/ejxCh1Kz+q1J4+KFlmsSvZ uB8JDtNjdAY4bG0VoIiZOZjVynxJD66UjeSAl0rqhSJDATUQvuKUx7ForCEJR28I1eYA GsUcrV/Mv25+dJgu302FiKEkLRyzsj5JWrVwRhX0kduyUcQzv7Rmq7RN15bq6LS5D4ZZ ryPQ== X-Gm-Message-State: AO0yUKVXhscDUqbFD8ixG0f1GpBqn9Oqpju7Xtna5ZeY36Tx2iR3cA17 lpHHm9FzARsVGTd021LUu1Y= X-Google-Smtp-Source: AK7set+VlguTzOSD7JIUctcgzx4sV+hi/VmvpAs6E7GBcJ57xlDge8xSdSS2nrG69BDASUAx7/UMSA== X-Received: by 2002:a50:9f48:0:b0:4aa:a0f8:d98 with SMTP id b66-20020a509f48000000b004aaa0f80d98mr1216530edf.0.1675511952623; Sat, 04 Feb 2023 03:59:12 -0800 (PST) Original-Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se. [188.150.171.209]) by smtp.gmail.com with ESMTPSA id v4-20020a056402348400b0049ef04ad502sm2399875edc.40.2023.02.04.03.59.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Feb 2023 03:59:12 -0800 (PST) X-Mailer: Apple Mail (2.3654.120.0.1.14) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254770 Archived-At: Jostein, thank you for contributing a new compilation-mode pattern! We generally want these regexps to be as tight as possible while still = doing their job. This is partly because the large and ever-growing = number of rules tend to interfere with one another, and over-broad = patterns have shown to be a source of performance problems in the past. I hope you don't mind helping us finishing the job: First of all, both regexps match arbitrary amounts of horizontal = whitespace at the beginning of a line, but neither message example you = supplied contains any such leading whitespace. This means that either = the set of test cases needs to be extended, or we could safely remove = this leading whitespace matcher. If leading whitespace indeed can occur, then when and how, exactly? = Spaces or tabs, and how many? Please give us examples from actual = compiler output. Similarly the patterns match arbitrary whitespace before the word = "error". This seems equally questionable -- would a single space do? If = not, please provide actual output demonstrating it that could be added = to the test suite, and tell us how it varies (tabs vs spaces, amount of = whitespace, etc). The following is a minor point that we'll fix but I thought you may want = to know: The use of [[:blank:]] and [[:alnum:]] is very likely more expensive = than required since they accept Unicode whitespace and letters which = obviously never will occur where matched so if it's all the same to you = we'll reduce them to ASCII patterns. Similarly, the inclusion of \r in patterns seems to be a = misunderstanding: the tail part, "[^\r\n]+$", does not make sense -- = normally, carriage returns aren't seen in buffers because line = terminator translation convert everything to a single \n, and if a stray = CR did occur then that pattern would never match anyway (why?).