From: Mauro Aranda <maurooaranda@gmail.com>
To: Po Lu <luangruo@yahoo.com>, 57113@debbugs.gnu.org
Subject: bug#57113: 29.0.50; Confusing icon customization interface
Date: Mon, 6 Nov 2023 08:12:06 -0300 [thread overview]
Message-ID: <78de61dd-e601-4f5e-a9ea-16daefd8c3ab@gmail.com> (raw)
In-Reply-To: <87h72kxq18.fsf@yahoo.com>
[-- Attachment #1: Type: text/plain, Size: 2111 bytes --]
Po Lu <luangruo@yahoo.com> writes:
> Do "M-x customize-icon RET outline-open RET".
>
> You will see the following interface:
>
> INS DEL List:
> Choice: Value Menu Colorful Emojis
> Repeat:
> INS DEL String: 🔽
> INS
> Plist:
> INS
> INS DEL List:
> Choice: Value Menu Monochrome Symbols
> Repeat:
> INS DEL String: ⯆
> INS
> Plist:
> INS
> INS DEL List:
> Choice: Value Menu Text Only
> Repeat:
> INS DEL String: close
> INS
> Plist:
> INS
> INS
> State : STANDARD.
>
> How to use this interface is not clear at all. What does the first
> level labeled "repeat" mean? Why does it have multiple items, when it
> is intended to represent a single icon? What does it mean if I click
> "INS"? And if I click "DEL"?
>
> Ignoring that, the individual items in the list are also badly
> organized. There is a menu of choices that seem to indicate the types
> of the items in the value list (why it is a list is also unclear.)
>
> Unfortunately, there is no help text in the menu explaining what the
> individual icons mean, or what to do with the text or plist fields field
> provided underneath. The fields also don't update in response to
> changes to the type, which doesn't make sense unless selecting "Images"
> will automagically transform an Emoji symbol into an image.
>
> The labels on the various fields should also be more informative than
> "Repeat", "String" and "Plist"; those only tell you what the fields are,
> and not what the fields do.
I tried to improve the tags for the custom-icon widget. See the
attached patch.
I'm willing to work on this, so any feedback is appreaciated. Thanks.
[-- Attachment #2: 0001-Improve-tags-in-custom-icon-widget.patch --]
[-- Type: text/x-patch, Size: 1921 bytes --]
From 168bb6380938b7e28116fdf3ec7429751b30484d Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Mon, 6 Nov 2023 08:04:41 -0300
Subject: [PATCH] Improve tags in custom-icon widget
* lisp/cus-edit.el (custom-icon-value-create): Give more informative
tags. (Bug#57113)
---
lisp/cus-edit.el | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el
index 4b8de6b9468..bebb2f6f681 100644
--- a/lisp/cus-edit.el
+++ b/lisp/cus-edit.el
@@ -5477,12 +5477,22 @@ custom-icon-value-create
(symbol (widget-get widget :value))
(tag (widget-get widget :tag))
(type '(repeat
- (list (choice (const :tag "Images" image)
+ :tag "Specifications by type"
+ (list :tag "Single specification"
+ (choice :tag "Type"
+ (const :tag "Images" image)
(const :tag "Colorful Emojis" emoji)
(const :tag "Monochrome Symbols" symbol)
(const :tag "Text Only" text))
- (repeat string)
- plist)))
+ (repeat :tag "Alternatives"
+ (string :tag "File or text"))
+ (plist :tag "Extra properties"
+ :key-type (choice
+ (const :tag "Face" :face)
+ (const :tag "Height" :height)
+ (const :tag "Width" :width)
+ (const :tag "Rotation" :rotation)
+ (symbol :tag "Key"))))))
(prefix (widget-get widget :custom-prefix))
(last (widget-get widget :custom-last))
(style (widget-get widget :custom-style))
--
2.34.1
next prev parent reply other threads:[~2023-11-06 11:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87h72kxq18.fsf.ref@yahoo.com>
2022-08-10 12:05 ` bug#57113: 29.0.50; Confusing icon customization interface Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-12 15:32 ` Lars Ingebrigtsen
2022-08-12 17:49 ` Eli Zaretskii
2022-08-13 1:57 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-13 12:01 ` Lars Ingebrigtsen
2022-08-13 12:14 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-13 12:23 ` Lars Ingebrigtsen
2022-08-13 12:30 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-13 12:35 ` Lars Ingebrigtsen
2022-08-13 12:48 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-15 5:45 ` Lars Ingebrigtsen
2022-08-15 6:51 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-15 6:53 ` Lars Ingebrigtsen
2022-08-15 7:31 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-06 11:12 ` Mauro Aranda [this message]
2023-11-06 13:00 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78de61dd-e601-4f5e-a9ea-16daefd8c3ab@gmail.com \
--to=maurooaranda@gmail.com \
--cc=57113@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).