unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 15899@debbugs.gnu.org
Subject: bug#15899: 24.3.50; regression: `region' overlay is lower priority than default
Date: Fri, 15 Nov 2013 09:14:37 -0800 (PST)	[thread overview]
Message-ID: <78b8713a-e96f-4b4d-990a-3af59ebdf942@default> (raw)
In-Reply-To: <<8338mxipix.fsf@gnu.org>>

> > This change should be reverted as soon as possible.
> 
> It needs not be reverted, I think.  We just need to make the
> priority of the region overlay higher than any other overlay.

1. I meant that the change to the behavior of the region not
appearing "on top of" other highlighting (except isearch) needs
to be reverted (undone).  IOW, bug #15899 is a regression.  It
is the behavior that needs to be fixed, regardless of how that
is done.

2. Region highlighting should *not* be higher priority than
all other overlays.  It should not be higher than isearch
highlighting, for instance.  There might be other exceptions
too; dunno.  See my previous mail.

3. It's not clear that the reported "bug" was in fact a bug,
rather than the intended Emacs behavior.  Or if it was, it is
not clear just what the bug was.  If it was thought to be a
bug that other highlighting was in some cases overruled
by region highlighting, then that was not, IMO, a bug.

4. If it was in fact a bug, it's not clear why the fix for it
needed to involve changing region highlighting to use an
overlay.  Not clear to me anyway.

My suggestion is to first revert the code change and then
discuss what the bug is that it was intended to fix.  If
there is really a bug that needs fixing, then let's please
try to find some other, non-shotgun fix for it.

There should be no need to change the longstanding behavior
of the Emacs region just because someone's highlighting does
not show through.





       reply	other threads:[~2013-11-15 17:14 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <<00aa91d2-10a2-4a78-bb95-042d1596a41c@default>
     [not found] ` <<8338mxipix.fsf@gnu.org>
2013-11-15 17:14   ` Drew Adams [this message]
2013-11-15 19:33     ` bug#15899: 24.3.50; regression: `region' overlay is lower priority than default Eli Zaretskii
     [not found] <<"<20137354-f982-4314-9c09-21a5fbc36557"@default>
     [not found] ` <<"<jwvsiux4vrn.fsf-monnier+emacsbugs"@gnu.org>
     [not found]   ` <<"<87mwl58yvc.fsf"@yandex.ru>
     [not found]     ` <<834n7dipnq.fsf@gnu.org>
     [not found]       ` <<"<83wqk8hgtf.fsf"@gnu.org>
     [not found]         ` <<7031ba1e-2f47-4dd0-908a-938c26016e12@default>
     [not found]           ` <<83k3g8gug7.fsf@gnu.org>
2013-11-16 17:47             ` Drew Adams
     [not found] <<78b8713a-e96f-4b4d-990a-3af59ebdf942@default>
     [not found] ` <<83zjp5h33w.fsf@gnu.org>
2013-11-15 21:21   ` Drew Adams
     [not found] <<20137354-f982-4314-9c09-21a5fbc36557@default>
     [not found] ` <<83ob5mi02j.fsf@gnu.org>
     [not found]   ` <<jwvsiux4vrn.fsf-monnier+emacsbugs@gnu.org>
     [not found]     ` <<83bo1liv80.fsf@gnu.org>
2013-11-15 15:55       ` Drew Adams
2013-11-15 16:43         ` Eli Zaretskii
2013-11-14 22:57 Drew Adams
2013-11-15  7:41 ` Eli Zaretskii
2013-11-15 13:54   ` Stefan Monnier
2013-11-15 14:40     ` Eli Zaretskii
2013-11-15 15:32       ` Dmitry Gutov
2013-11-15 16:40         ` Eli Zaretskii
2013-11-15 22:35           ` Dmitry Gutov
2013-11-16  8:49             ` Eli Zaretskii
2013-11-16  9:51               ` Jarek Czekalski
2013-11-16 10:42                 ` Eli Zaretskii
2013-11-16 14:43                   ` Jarek Czekalski
     [not found]                 ` <<83ppq0hbln.fsf@gnu.org>
2013-11-16 16:23                   ` Drew Adams
2013-11-16 16:52                     ` Eli Zaretskii
2013-11-16 22:01                     ` Stefan Monnier
2013-11-16 22:42                       ` Drew Adams
2013-11-16 10:25               ` Dmitry Gutov
2013-11-16 11:24                 ` Eli Zaretskii
2013-11-16 13:49                   ` Dmitry Gutov
2013-11-16 16:30                     ` Drew Adams
2013-11-16 16:20                 ` Drew Adams
     [not found]                 ` <<83ob5kh9nb.fsf@gnu.org>
2013-11-16 16:24                   ` Drew Adams
2013-11-16  1:25       ` Stefan Monnier
2013-11-16  9:06         ` Eli Zaretskii
2013-11-16 17:45           ` Stefan Monnier
2013-11-16 18:01             ` Drew Adams
2013-11-16 22:00               ` Stefan Monnier
2013-11-17 12:25             ` Daniel Colascione
2013-11-17 15:42               ` Stefan Monnier
2014-02-10  4:14         ` Lars Ingebrigtsen
2013-11-15 15:51     ` Drew Adams
2013-11-16  1:26       ` Stefan Monnier
2013-11-16  3:47         ` Drew Adams
2013-11-15 16:53 ` Barry OReilly
     [not found] <"<20137354-f982-4314-9c09-21a5fbc36557"@default>
     [not found] ` <"<jwvsiux4vrn.fsf-monnier+emacsbugs"@gnu.org>

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78b8713a-e96f-4b4d-990a-3af59ebdf942@default \
    --to=drew.adams@oracle.com \
    --cc=15899@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).