From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#24829: 24.5; `easy-mmode-define-navigation': rename `define-...', per convention Date: Sun, 30 Oct 2016 15:50:43 -0700 (PDT) Message-ID: <787c4f0e-4cd2-46b9-9e7a-1cc694e8b71c@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1477867901 3962 195.159.176.226 (30 Oct 2016 22:51:41 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 30 Oct 2016 22:51:41 +0000 (UTC) To: 24829@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 30 23:51:37 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0ywZ-0005Yl-DV for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Oct 2016 23:51:11 +0100 Original-Received: from localhost ([::1]:60427 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c0ywc-00017M-2V for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Oct 2016 18:51:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c0ywU-00017F-Ib for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2016 18:51:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c0ywQ-0001mP-IQ for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2016 18:51:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50316) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c0ywQ-0001mI-8b for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2016 18:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c0ywQ-00051O-2C for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2016 18:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Oct 2016 22:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 24829 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.147786786019290 (code B ref -1); Sun, 30 Oct 2016 22:51:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 Oct 2016 22:51:00 +0000 Original-Received: from localhost ([127.0.0.1]:37482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0ywO-000514-Dj for submit@debbugs.gnu.org; Sun, 30 Oct 2016 18:51:00 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0ywM-00050s-ID for submit@debbugs.gnu.org; Sun, 30 Oct 2016 18:50:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c0ywG-0001jX-Bo for submit@debbugs.gnu.org; Sun, 30 Oct 2016 18:50:53 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:52352) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c0ywG-0001jT-8c for submit@debbugs.gnu.org; Sun, 30 Oct 2016 18:50:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c0ywF-000176-6c for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2016 18:50:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c0ywB-0001hw-6f for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2016 18:50:51 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:35839) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c0ywB-0001ho-0e for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2016 18:50:47 -0400 Original-Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u9UMojLb030271 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 30 Oct 2016 22:50:45 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u9UMoj2c003992 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 30 Oct 2016 22:50:45 GMT Original-Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id u9UMoiu1023493 for ; Sun, 30 Oct 2016 22:50:45 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6753.5000 (x86)] X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125167 Archived-At: Macro `easy-mmode-define-navigation' apparently defines Emacs commands (functions). Per the Emacs Lisp coding conventions, its seems that the macro should be renamed. >From (elisp `Coding Conventions': Constructs that define a function or variable should be macros, not functions, and their names should start with `define-'. The macro ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ should receive the name to be defined as the first argument. That will help various tools find the definition automatically. Avoid constructing the names in the macro itself, since that would confuse these tools. In GNU Emacs 24.5.1 (i686-pc-mingw32) of 2015-04-11 on LEG570 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D3D/c/usr --host=3D3Di686-pc-mingw32'