From: Drew Adams <drew.adams@oracle.com>
To: 24829@debbugs.gnu.org
Subject: bug#24829: 24.5; `easy-mmode-define-navigation': rename `define-...', per convention
Date: Sun, 30 Oct 2016 15:50:43 -0700 (PDT) [thread overview]
Message-ID: <787c4f0e-4cd2-46b9-9e7a-1cc694e8b71c@default> (raw)
Macro `easy-mmode-define-navigation' apparently defines Emacs commands
(functions). Per the Emacs Lisp coding conventions, its seems that the
macro should be renamed.
From (elisp `Coding Conventions':
Constructs that define a function or variable should be macros, not
functions, and their names should start with `define-'. The macro
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
should receive the name to be defined as the first argument. That
will help various tools find the definition automatically. Avoid
constructing the names in the macro itself, since that would
confuse these tools.
In GNU Emacs 24.5.1 (i686-pc-mingw32)
of 2015-04-11 on LEG570
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
`configure --prefix=3D/c/usr --host=3Di686-pc-mingw32'
next reply other threads:[~2016-10-30 22:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-30 22:50 Drew Adams [this message]
2019-07-27 12:50 ` bug#24829: 24.5; `easy-mmode-define-navigation': rename `define-...', per convention Lars Ingebrigtsen
2020-08-12 0:46 ` Stefan Kangas
2020-08-12 10:51 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=787c4f0e-4cd2-46b9-9e7a-1cc694e8b71c@default \
--to=drew.adams@oracle.com \
--cc=24829@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).