From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#60961: 29.0.60; Compiling emacs-29 without treesitter outputs warnings Date: Fri, 20 Jan 2023 14:36:00 -0800 Message-ID: <7824DF9F-E027-4D2C-ACCF-028D34332AE6@gmail.com> References: <878rhx1os6.fsf@gmail.com> <831qnpnx9g.fsf@gnu.org> <87o7qtuxgh.fsf@thornhill.no> <83tu0lmgv6.fsf@gnu.org> <87h6wll10q.fsf@thornhill.no> <83r0vpme0t.fsf@gnu.org> <8A47E6B6-BE4F-44F4-9BC5-55B6051CDCD4@thornhill.no> <2025C712-7091-4971-B254-51844C0FA609@thornhill.no> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13718"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Robert Pluim , 60961@debbugs.gnu.org To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 20 23:37:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJ00m-0003IE-Js for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Jan 2023 23:37:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJ00N-0002ct-NI; Fri, 20 Jan 2023 17:37:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJ00M-0002ce-9i for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 17:37:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJ00M-0005gb-21 for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 17:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pJ00L-0003lr-Nk for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 17:37:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Jan 2023 22:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60961 X-GNU-PR-Package: emacs Original-Received: via spool by 60961-submit@debbugs.gnu.org id=B60961.167425418114431 (code B ref 60961); Fri, 20 Jan 2023 22:37:01 +0000 Original-Received: (at 60961) by debbugs.gnu.org; 20 Jan 2023 22:36:21 +0000 Original-Received: from localhost ([127.0.0.1]:47439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIzzg-0003kh-HL for submit@debbugs.gnu.org; Fri, 20 Jan 2023 17:36:20 -0500 Original-Received: from mail-pj1-f53.google.com ([209.85.216.53]:56056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIzze-0003kR-BJ for 60961@debbugs.gnu.org; Fri, 20 Jan 2023 17:36:18 -0500 Original-Received: by mail-pj1-f53.google.com with SMTP id dw9so6898104pjb.5 for <60961@debbugs.gnu.org>; Fri, 20 Jan 2023 14:36:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VsksJKGRvEuoi/j8y5PPs/U8jW6aStcCUSLwAWjvoJw=; b=gSYn47Q0QQB0AJ0+5TiqNLhDHNjniqCEz9RH9p108046PLBGGhJ61vziH83+8RXTKQ YTNMB0GixOwcBsaqRUdmFOdZNDWOZ4HGZ+8kxZ+tJ/d6yrLkcUlzkzZum5WjX4yVbZ7C f4EWhJGj/RFdEH/wG7TZhRxc+NgmrQ74fQUj50HMRyxktdmzqzjJgWWgwt+4vsydAGNw 2QXTKqX45hx0QTPsOxKPZDXGoe1OH5SFbstwXk0f9ETH5VAc3ogh6bxY8+lYxbdQUzCQ r8VwG94l/LWkQDqSsTpkjA689HeklvwUJDzNvqDdFI8pnvcoODFjggaIFvNzhErTWHBX ChLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VsksJKGRvEuoi/j8y5PPs/U8jW6aStcCUSLwAWjvoJw=; b=D+FVfIX/LRxwAgmVOZmT/EXdObVQpbFNPpUYQywcoBdkqh0hSqcnAS2SYNAnK3gO/x mr6H/6MmNeX1i7Npbr+fy8VQDDWcGWa+c8tLsiHpkDFLXc0SeVo17MebOGd9FDtpYK4L QnpJNpgEYH3O08WiZp/WGe72pypI3sO1MvOpenAFx45BHLj6Sl+D6+HWvVYPfbzF92pu usJl4gfcOdm+LEx+YwGqRHTvnCL5YlfKfJmlrg/Ol2GItlIX8ipCXYyBHfHQOemQSlVW +Nx0yUcwfUYWX9xqf97Q4gRpwdzoI1uxX6giVIgOc4eqaq6JtD3GSaELGsPBZNhrmqAM Qg0w== X-Gm-Message-State: AFqh2koAMwPzPIcZYwXeYlhAZTGNif99lRiUiBxaRorKnfQtb2veRhqO m8P9XwoT623DePmzbpjLCg8= X-Google-Smtp-Source: AMrXdXvuSbF/JZ4o+u0z/FlSOe43wCZ6z7AICHsNXzAXMcjdWEfCzJrtdaOTsweDN1ojcMAIzCMFBA== X-Received: by 2002:a17:903:2093:b0:194:67e5:3d07 with SMTP id d19-20020a170903209300b0019467e53d07mr14937765plc.53.1674254172480; Fri, 20 Jan 2023 14:36:12 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id ja15-20020a170902efcf00b0019493c84880sm10248682plb.188.2023.01.20.14.36.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Jan 2023 14:36:12 -0800 (PST) In-Reply-To: <2025C712-7091-4971-B254-51844C0FA609@thornhill.no> X-Mailer: Apple Mail (2.3731.300.101.1.3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253813 Archived-At: > On Jan 20, 2023, at 2:30 PM, Theodor Thornhill = wrote: >=20 >=20 >=20 > On 20 January 2023 23:11:44 CET, Yuan Fu wrote: >>=20 >>=20 >>> On Jan 20, 2023, at 8:07 AM, Theodor Thornhill = wrote: >>>=20 >>>=20 >>>=20 >>> On 20 January 2023 16:17:22 CET, Eli Zaretskii wrote: >>>>> From: Theodor Thornhill >>>>> Cc: rpluim@gmail.com, casouri@gmail.com, 60961@debbugs.gnu.org >>>>> Date: Fri, 20 Jan 2023 15:43:33 +0100 >>>>>=20 >>>>> Eli Zaretskii writes: >>>>>=20 >>>>>>> So I can either just make sure that no modes require across = modes, or >>>>>>> make that "lib" right now. What do you think? >>>>>>=20 >>>>>> I tend to the "lib" method. Mostly because several modes, = including >>>>>> some that are unrelated to C, want the code which was written for >>>>>> C/C++, and so it is possible that there's some general feature = here >>>>>> waiting for us to refactor the code -- in which case perhaps the = code >>>>>> should be in treesit.el? >>>>>>=20 >>>>>> IOW, how come JS, Rust, and Typescript all want comment-related = setup >>>>>> that was written for C? >>=20 >> Because they all have C-like syntax, so they have the same setup for = indenting and filling block comments, for example. >>=20 >>>>>> If this is just a coincidence, then perhaps >>>>>> duplicating the code is a better idea, but if there's some = underlying >>>>>> commonality, we should have common code in treesit.el, or maybe = in >>>>>> some c-ts-common.el? >>=20 >> c-ts-common.el sounds good to me. >>=20 >>>>>=20 >>>>> I can start by moving it into treesit.el, then we can maybe = extract >>>>> something out later. Sounds good? I can do it tonight, unless = any of >>>>> you object :) >>>>=20 >>>> SGTM, but let's hear from Yuan before you start working on this. >>>>=20 >>>> Thanks. >>>=20 >>> Thumbs up >>=20 >> I=E2=80=99d prefer c-ts-common.el over treesit.el, since they only = apply to C-like languages. There is no harm putting them in a separate = file, right? I wrote some commentary in c-ts-mode, which notes all the = shared functions and variables.=20 >>=20 >> Yuan >>=20 >=20 > Ok, should I do it or you? :) >=20 > Theo The honor is yours :-) Yuan=