From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode Date: Sun, 30 Jul 2023 15:09:51 +0300 Message-ID: <77c5df43-6a3f-b99b-ed33-2094376e16e7@gutov.dev> References: <87zg4od38w.fsf@gmail.com> <87ttuvorbw.fsf@epfl.ch> <87y1k7j4ov.fsf@gmail.com> <68d19873-5c5f-894a-080f-b2e1bacc449a@gutov.dev> <87cz0995eq.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11095"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Basil Contovounesios , 64275@debbugs.gnu.org To: Wilhelm Kirschbaum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 30 14:18:01 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qQ5N0-0002a5-9R for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Jul 2023 14:17:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qQ5GM-0000ox-Ob; Sun, 30 Jul 2023 08:11:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQ5GI-0000o8-CS for bug-gnu-emacs@gnu.org; Sun, 30 Jul 2023 08:11:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qQ5GI-0004sM-4d for bug-gnu-emacs@gnu.org; Sun, 30 Jul 2023 08:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qQ5GI-0002Ec-0W for bug-gnu-emacs@gnu.org; Sun, 30 Jul 2023 08:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jul 2023 12:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64275 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64275-submit@debbugs.gnu.org id=B64275.16907190088513 (code B ref 64275); Sun, 30 Jul 2023 12:11:01 +0000 Original-Received: (at 64275) by debbugs.gnu.org; 30 Jul 2023 12:10:08 +0000 Original-Received: from localhost ([127.0.0.1]:49476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQ5FO-0002DD-GE for submit@debbugs.gnu.org; Sun, 30 Jul 2023 08:10:08 -0400 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:60761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qQ5FJ-0002CY-3G for 64275@debbugs.gnu.org; Sun, 30 Jul 2023 08:10:05 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 96F2D5C00E6; Sun, 30 Jul 2023 08:09:55 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 30 Jul 2023 08:09:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1690718995; x=1690805395; bh=e4K57ZXPzmLcwYPkFI+PZGqz4CFEq24Fl98 K1gRrY6g=; b=d270cusUAchCl9G/r+0o5CHfxeKDl2HFMOdqqLcCeR3c1/RarwF r8wm29E/1pzEPNpDJZZXwlQ49mHGJ0zLuoidSPWtM+lY3U0n/igmQWe48BPzV4dY Bb8F4RqydGttM8KH67SOkNjLa94dUpk4bYce0pqQb/Q4bYBLbVVBLXitb7L9htJb K6Ovhb+wVQP7H2EwGyqGBYpY2syWWAjPqsTI59AKckFcpshn1Dwo7xEBIVvh3/t2 9XaZN2yZzM+7b2FtGZVnntxNy98ynfvoE3Gn+0+EQrOM06UpqtBOOu63K91XNqH5 EhlKgvts3REcKzdI0AMKHYKp71SFj5Y34NA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690718995; x=1690805395; bh=e4K57ZXPzmLcwYPkFI+PZGqz4CFEq24Fl98 K1gRrY6g=; b=qY5quYNhC/5aOeFDvpdq9zstAqhRdQfvSpeytoKjwTV8E/h1Vga EO8lUT7dQ16h1xMARZgMNmvi3qtFZY0xCsutrVbCxYF7sUAwG5dkQ321E8lzzPzI Ui//8AdqOANy3Fx0/ag8pj10srycuxp2UgukOCcQvTpcROmvIdurmIr0Ha5aoSOa b3kRCx0+1Gx2ytQaNJPqzagLKCEhDzl9aNjdXJ2CFS+wRJIcjvCpTD4GDlsWqVun qI35q8d0wrqniBMrlXlSCjTctWGpXp6iSbdTCTMUM3GqtMIIBgQv6uYj/Oza+HMD vKarv7ypqyDQ3GPRQU/MjBoN8/PJv2WDQAA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrjedugdegkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthekredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpefhffehleejffegffeugefhkeektdffgfehjedvgeejtedtudehueffgffgfeej heenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 30 Jul 2023 08:09:53 -0400 (EDT) Content-Language: en-US In-Reply-To: <87cz0995eq.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266366 Archived-At: On 30/07/2023 10:53, Wilhelm Kirschbaum wrote: >> With the new patch, it will continue highlight the sigil name ("r") in >> regexps, but no in other sigil types (s/c/w). >> > > Incorrect, just below there is a: > >           (sigil) @font-lock-string-face) > > without a match, so they will be highlighted, but just more generically > as we don't know which sigils the user might have assigned. Why not add elixir-ts-font-sigil-name-face in that matcher as well?