From: David Reitter <reitter@cmu.edu>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 3303@emacsbugs.donarmstrong.com,
Chong Yidong <cyd@stupidchicken.com>,
Adrian Robert <adrian.b.robert@gmail.com>
Subject: bug#3303: delete-frame raises old (invisible) frame
Date: Tue, 26 May 2009 16:15:34 -0400 [thread overview]
Message-ID: <77EF744F-5194-4E1F-AE4D-DD4D81BB88F8@cmu.edu> (raw)
In-Reply-To: <jwvskirr74o.fsf-monnier+emacsbugreports@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]
On May 26, 2009, at 3:37 PM, Stefan Monnier wrote:
>
>>>> drawRect: do not set visibility/iconified flags because drawRect
>>>> may be
>>>> called by NSView even if the frame is hidden.
>>> Do you happen to know why/when NSView might be called even for a
>>> frame
>>> that's not visible?
>> Unfortunately not, but invisibility does not guarantee absence of
>> drawRect
>> messages unless this is promised somewhere in the NS API.
>> I do think that my patch here is right, though, as other ports set
>> visibility in more obvious places.
>
> Yes, the patch looks OK, but I'd still like to know why drawRect gets
> called in such cases, as well as why the visibility settings were
> modified in that routine.
In this vein, is it possible to get the development history of the NS
port merged with the other Emacs history?
I mean, everything begins (ends) with the merge, with all code there
appearing to have been authored by 'arobert'. In this particular case
I would have wanted to know when these lines of code were added (e.g.,
pre-22?), and what the comments were.
I could probably try to find this in Emacs.app, but I'm wondering if
we can have this history (perhaps in a separate branch) in the Bzr/Git
repositories.
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 2438 bytes --]
next prev parent reply other threads:[~2009-05-26 20:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-22 3:57 bug#3303: delete-frame raises old (invisible) frame David Reitter
2009-05-25 15:17 ` Stefan Monnier
2009-05-26 18:20 ` David Reitter
2009-05-26 19:37 ` Stefan Monnier
2009-05-26 20:15 ` David Reitter [this message]
2009-05-26 21:30 ` Stefan Monnier
2009-05-27 4:51 ` Adrian Robert
2009-05-27 14:36 ` Stefan Monnier
2009-06-01 9:37 ` Adrian Robert
2009-05-27 15:28 ` David Reitter
-- strict thread matches above, loose matches on Subject: below --
2009-05-16 19:28 Chong Yidong
2009-05-17 2:55 ` David Reitter
2009-05-16 1:09 David Reitter
2009-05-17 19:06 ` Stefan Monnier
2009-05-17 19:12 ` David Reitter
2009-05-17 20:43 ` Stefan Monnier
2009-05-17 22:27 ` Lennart Borgman
2009-05-18 3:26 ` Stefan Monnier
2009-05-18 1:16 ` Adrian Robert
2009-05-18 3:33 ` Stefan Monnier
2009-05-18 8:05 ` Adrian Robert
2009-05-18 15:08 ` David Reitter
2009-05-18 20:12 ` Stefan Monnier
2009-05-18 23:00 ` David Reitter
2009-05-19 2:46 ` Stefan Monnier
2009-05-19 2:56 ` David Reitter
2009-05-19 3:09 ` Stefan Monnier
2009-05-19 3:15 ` David Reitter
2009-05-19 8:20 ` YAMAMOTO Mitsuharu
2009-05-19 14:30 ` Stefan Monnier
2009-05-20 2:07 ` David Reitter
2009-05-19 0:58 ` YAMAMOTO Mitsuharu
2009-05-18 8:19 ` YAMAMOTO Mitsuharu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77EF744F-5194-4E1F-AE4D-DD4D81BB88F8@cmu.edu \
--to=reitter@cmu.edu \
--cc=3303@emacsbugs.donarmstrong.com \
--cc=adrian.b.robert@gmail.com \
--cc=cyd@stupidchicken.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).