bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' [PATCH]

["Drew Adams" <drew.adams@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 1779 bytes --]

Martin wrote:

> IIUC your patch works regardless of the value of
> `frame-auto-hide-function'.  The problem of your patch is that in
>    (if (one-window-p) (delete-frame) (delete-window))
> the window for showing the buffer may have been _reused_ in which case
> deleting is certainly the wrong solution.

I do not understand how/why that window would or should be reused.

Especially between the time it becomes displayed and the end of the calling
function.  The window is only for the user interaction of confirming (or not)
the operation on the marked files.

The existing code seems to reflect this aim in that it uses
`save-window-excursion'.  What is still missing is (a) deletion of the window or
frame (if `one-window-p') and (b) burial of the buffer.  And this should happen
always, regardless of what the user does, including `C-g'.

If the buffer is not shown in a separate frame then the `save-window-excursion'
alone seems to remove/hide the window - great.  And that is why more people are
not complaining about this regression, IMO.

But if the buffer is shown in a separate frame (e.g. due to
`special-buffer-regexps') then `save-window-excursion' is simply not sufficient.
The frame remains displayed after the user interaction, regardless of what the
user does during the interaction (including `C-g').

Attached is a patch against the latest source code.  AFAIK it DTRT.  Can anyone
point to a reasonable situation where it does not DTRT - IOW, where what it does
is inappropriate?  If not, can this please be installed for Emacs 24.1, to
eliminate this regression?  Thx.

Here is a change-log entry for the patch:

2012-05-26  Drew Adams  <drew.adams@oracle.com>

	* dired.el (dired-mark-pop-up):
	Delete the marked-files window/frame and bury its buffer.

[-- Attachment #2: dired-2012-05-26.patch --]
[-- Type: application/octet-stream, Size: 2556 bytes --]

diff -c dired.el dired-patched-2012-05-26.el
*** dired.el	Sat May 26 09:48:52 2012
--- dired-patched-2012-05-26.el	Sat May 26 10:43:26 2012
***************
*** 2988,3009 ****
  in the case of one marked file, to distinguish that from using
  just the current file."
    (or bufname (setq bufname  " *Marked Files*"))
!   (if (or (eq dired-no-confirm t)
! 	  (memq op-symbol dired-no-confirm)
! 	  ;; If FILES defaulted to the current line's file.
! 	  (= (length files) 1))
!       (apply function args)
!     (with-current-buffer (get-buffer-create bufname)
!       (erase-buffer)
!       ;; Handle (t FILE) just like (FILE), here.
!       ;; That value is used (only in some cases), to mean
!       ;; just one file that was marked, rather than the current line file.
!       (dired-format-columns-of-files (if (eq (car files) t) (cdr files) files))
!       (remove-text-properties (point-min) (point-max)
! 			      '(mouse-face nil help-echo nil)))
!     (save-window-excursion
!       (dired-pop-to-buffer bufname)
!       (apply function args))))
  
  (defun dired-format-columns-of-files (files)
    (let ((beg (point)))
--- 2988,3016 ----
  in the case of one marked file, to distinguish that from using
  just the current file."
    (or bufname (setq bufname  " *Marked Files*"))
!   (let (result)
!     (if (or (eq dired-no-confirm t)
!             (memq op-symbol dired-no-confirm)
!             ;; If FILES defaulted to the current line's file.
!             (= (length files) 1))
!         (setq result  (apply function args))
!       (with-current-buffer (get-buffer-create bufname)
!         (erase-buffer)
!         ;; Handle (t FILE) just like (FILE), here.
!         ;; That value is used (only in some cases), to mean
!         ;; just one file that was marked, rather than the current line file.
!         (dired-format-columns-of-files (if (eq (car files) t) (cdr files) files))
!         (remove-text-properties (point-min) (point-max)
!                                 '(mouse-face nil help-echo nil)))
!       (unwind-protect
!            (save-window-excursion
!              (dired-pop-to-buffer bufname)
!              (setq result  (apply function args)))
!         (ignore-errors
!           (select-window (get-buffer-window bufname 0))
!           (if (one-window-p) (delete-frame) (delete-window)))
!         (bury-buffer bufname)))
!     result))
  
  (defun dired-format-columns-of-files (files)
    (let ((beg (point)))

Diff finished.  Sat May 26 10:48:28 2012