From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Wolfgang Scherer Newsgroups: gmane.emacs.bugs Subject: bug#37189: 25.4.1: vc-hg-ignore implementation is missing Date: Sat, 22 Feb 2020 23:00:57 +0100 Message-ID: <777563ca-b2c1-ab01-e1d5-6dc9c8f52415@gmx.de> References: <1ba53ae2-42a4-3ab3-d4f2-2ceae565d198@gmx.de> <838slmk90j.fsf@gnu.org> <83h806gp2w.fsf@gnu.org> <8336bmg1o9.fsf@gnu.org> <2354821b-5c1e-f9e3-3a64-4ff978ded33b@gmx.de> <83sgjkdev5.fsf@gnu.org> <3fb73dbc-bf31-233b-4afc-2147c4ffd5b7@gmx.de> <5622487d-a21f-49cf-5420-21f87415af4f@gmx.de> <83wo8ubfbo.fsf@gnu.org> <83zhdpqbas.fsf@gnu.org> <2c8419ae-723d-c7ae-a60e-59d1b1cbc2c1@gmx.de> <83o8u3r6wg.fsf@gnu.org> <6f3ba261-e1f9-cf19-cc22-ec8c24cf3298@gmx.de> <83blq2qzqp.fsf@gnu.org> <83ftfdplo8.fsf@gnu.org> <9929b44f-37da-23c8-16cc-c6ca89602149@yandex.ru> <2f84ddff-3275-6eb1-01ae-ff1d28b6e8da@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="18687"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 Cc: 37189@debbugs.gnu.org To: Dmitry Gutov , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 22 23:02:35 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j5cr5-0004jj-Lv for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Feb 2020 23:02:35 +0100 Original-Received: from localhost ([::1]:47396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5cr4-00059J-Hp for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Feb 2020 17:02:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48897) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5cqa-000593-DK for bug-gnu-emacs@gnu.org; Sat, 22 Feb 2020 17:02:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j5cqZ-0004FR-9k for bug-gnu-emacs@gnu.org; Sat, 22 Feb 2020 17:02:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44208) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j5cqY-0004Ex-GB for bug-gnu-emacs@gnu.org; Sat, 22 Feb 2020 17:02:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j5cqY-0004Tz-Da for bug-gnu-emacs@gnu.org; Sat, 22 Feb 2020 17:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Wolfgang Scherer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Feb 2020 22:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37189 X-GNU-PR-Package: emacs Original-Received: via spool by 37189-submit@debbugs.gnu.org id=B37189.158240886717146 (code B ref 37189); Sat, 22 Feb 2020 22:02:02 +0000 Original-Received: (at 37189) by debbugs.gnu.org; 22 Feb 2020 22:01:07 +0000 Original-Received: from localhost ([127.0.0.1]:50181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5cpf-0004SU-K6 for submit@debbugs.gnu.org; Sat, 22 Feb 2020 17:01:07 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:35103) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5cpd-0004Rp-LT for 37189@debbugs.gnu.org; Sat, 22 Feb 2020 17:01:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1582408859; bh=4RzKxZEsEedOXcRqBptxpXUC6QPWCSD2F54FKoiYi/A=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=kMUmmOxtKPBMZMj9W3EQHyjnvkQ9yJd9catLtfusCuwk22NVuHIdOlqS1qnlFLSTL aaf1uCZ6ny+LbCL3+KWA10o3PaKN+ZZLEmmfYnfHg++UuUNkbaDHtAvsNuiPrQ5OZm Jy9IO12BsobbxRVV06flrMQczhXGa2zyehMoYXfg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from sheckley.simul.de ([87.160.210.52]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M2O6e-1j9Tuf03GY-003vt2; Sat, 22 Feb 2020 23:00:59 +0100 Original-Received: from [127.0.0.1] (sheckley.simul.de [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sheckley.simul.de (Postfix) with ESMTPSA id 7634319431F2; Sat, 22 Feb 2020 23:00:57 +0100 (CET) Openpgp: preference=signencrypt Autocrypt: addr=Wolfgang.Scherer@gmx.de; prefer-encrypt=mutual; keydata= xsDiBEb46IgRBACMHOAb1KNo1Ylk+ebri+4R+bG4tyKlqBlrpv8D9/ZwRdXSGt+0DyCHoaAd 7KW7noHapLe87DunABOjKG4nqTGv+dRiWuUBlp3I4aYRFDVa3Da+XnIYkMHKqhK59VEHQCdp Km42nuLS7TS+n99at9YwzTG6VBdOlBKTlRFngOjVLwCg1RGXJ6X3EjS1FKCQeXziURVpWlkD /2zY6Ayhxi62TS84VjikXrrmjXykAAaAmMVEyKKYb9L5pGlqiZz9g/K9xw1EUoZTYuaufquD v4rAGR58K/3V4CYfJLEeshMWiaXHvMmlxMznlG16/um4MvmR8B3r+cx0nOPK1JBdD2qrkNnF Mw8FB+zouLFB4Gt2IUC5IlOmZ8OQA/4qdU53CItzWsCr9Nux4L0qUlRweSmCnV8xGQ2wP5XI MawIQxxREvSrsYDG8cNnYETMg4iQFfIktwAoxCJvuFAwIB6ZxHGF4FcEZm64CXc2u7CmFLqt rVhXhIfMz9oEYC+HhGczGamn9ofbGTFd2hJEtPcQgWNR4f7+aKknmi2+OM0fV29sZmdhbmcg U2NoZXJlciA8d3NAc3ctYW10LndzPsJhBBMRAgAhBQJYmz3YAhsjBQsJCAcCBhUICQoLAgQW AgMBAh4BAheAAAoJEIUCr3Gr112VZZoAoLTBSTp1qGuNhLdXY04iaWCMYmHCAJ4kHPtQ6nTw kEq9qCHgVgXDaY7wjs7ATQRG+OiIEAQAhi0wjcxvA4tychg2NQuwBIf9LX/46l+74+QbewCn a4a+mw/9s5KY In-Reply-To: Content-Language: de-DE X-Provags-ID: V03:K1:ARmoD0oJ9g5nLJzmGuaUPd8+hLew5OJm2GpDq+AgC4trtbaDjlT kQvEfSOBuorpnnXUsQfHJ4c+dMid/1DE/NvDGRCaSf8WDadeiX/C5kKMJz5xgzJ1PPqXylm RPmlfaV407Jyfxhxf3P0opDem1wZV+0qyxgfJhqf3UD6/w6FmO/QhaY4oiG1D3SCDSDO/QK Lhvc0MqXj5XiXbNowUQuA== X-UI-Out-Filterresults: notjunk:1;V03:K0:KvTg36LnblI=:nNC/bjvUw1odxpuJNDPl6v jL6E3GIFc+0WdgzBRkGom8hBkZlf+Mb00O1H2X32fRtof/UH4tYvVmm7zE2kzaPSORDIZR0fQ w4KfLbLQkJnNGSzCpaB18h1236TleVPB15sDLAa4Puw9nBgbR1y4DnP0vIQucmd/qdNdYNh/L h41ONgTEpBFfAp/zDG3Ap+SVwBNcjBP01OQ4fao8RPNSdP37gE1x2QYh5sQC1kvvbJNsEoxCt BdafW6fK9UFK9KDFEQrCpgdcGE27WhJvs0JMNNG6deMLqPXdKwD/0jx8YoVsrGWppAW76DjvB zUHrrTUjsL6taQMgkdjqeL5RitM9vRcPvpSzPndXpQ3ZZESmzLklf29R3fnP6OthFv7TEnNvl 7NK+MZfYrRnfXYEZca/t8rU+/x0+HLXedVOoKVz7jP2f9fNfIDyilR4Rll2jFob7rbWCZWg2r ahwyr/DXYNvNCybO7OBmuFis0FDu/5Y5/pTKk03VOI7W4Mzzci2zk3vZrIMpl0kMUErm481dT F6YzUHdTXnRtMTruEmuKP3AP3hNNzQQMo2VEgjmNNiaYkC0jYkcltNea0h/Om2+xE079cbwap 2HyU6VoTODhhKJy3/OMxc1gMk05WN8gZyKVUXu/ckX3iUW+zDAOZrg9oH646EA4tSQ1K6SSDT eA6T46mrwoXmRrIiDI8hIKss3nmwgohhDbETd7IKz2zm/VrseUModk1Lr521B1uDpkpmGSDko PP9Y64RDHFvw3fRAse6rfW8U5EKR81rFPXkM/ldlNovQYhsDIx9r4dYTlzazrYYV9k3Fu8Xr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176404 Archived-At: Am 22.02.20 um 20:30 schrieb Dmitry Gutov: > On 22.02.2020 0:22, Wolfgang Scherer wrote: >> Both use cases are important for casual users of a VC. Before this >> research, I did not know anything about SVN, SRC, Bzr, Mtn. Ignore file >> support in 'vc' as a distilled experience cache does come in handy, >> even for experienced users. Especially, if escaping/anchoring is >> implemented. > > Escaping/anchoring can be added in the next step of the "series of ad-ho= c patches". I'm not saying to implement it now, I am just describing use cases, which = are not limited to Emacs 27. >> RCS, SCCS do not have ignore files, so they should error out. SRC has >> ignore files similar to CVS and SVN. > > They will fail anyway because they implement neither 'find-ignore-file' = nor the 'ignore' backend actions. This is in reference to the condition-case around find-ignore-file, which = is not necessary. It is OK to error out in that case. > >> Do not forget that CVS and SVN >> have functions vc-cvs-ignore and vc-svn-ignore, which are called >> *instead*=C2=A0 of vc-default-ignore. I.e. The changes to vc-default-ig= nore >> do not affect those VCs. For the invocation of find-ignore-file in >> vc-ignore, see below. > > I think the patch is compatible with those. At least with the SVN one (v= c-cvs-ignore might need a little work). > > Have you tried this patch with SVN? Is there a particular scenario where= it fails? No, it should not. CVS is now also patched, so it will no longer fail. > >>> Roughly and handwavy, we can take this case to mean "use default-direc= tory". >> Unfortunately not. If the file or pattern to be ignored is in a >> subdirectory of default-directory, the DIRECTORY argument must reflect >> this for CVS, SVN, SRC. > > vc-svn-ignore looks like it can handle either calling convention. As does vc-cvs-ignore. So, for right now, it is OK. > >> I apologize for introducing ewoc into vc-dir-mode. Meanwhile I have >> discovered vc-deduce-fileset, which does all the hard work for >> preparing a fileset in vc-dir-mode, dired-mode and other >> modes. vc-deduce-fileset delivers a backend and absolute file names, >> not relative file names. > > Please submit a patch fixing that whenever you have the time. I don't think it should be done before Emacs 28. > >> I think introducing relative file names in >> function APIs is the wrong way to go. However, as a preliminary >> solution, it does suffice. > > I think it's just fine if the function is supposed to receive an *ignore= pattern*, and not a simple file name. Again, it is probably not the time right now to discuss these matters. What will be the time frame for starting Emacs 28 topics?