From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Clemens Newsgroups: gmane.emacs.bugs Subject: bug#45780: 28.0.50; [PATCH] Face used for affixation function annotations Date: Wed, 13 Jan 2021 19:06:38 +0100 Message-ID: <7763f3e7-475c-9adb-ce62-7801faf47a90@posteo.net> References: <9b1409af-58b9-3a62-4162-343fd25293ca@posteo.net> <87ft378gjk.fsf@mail.linkov.net> <8735z6xx11.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24265"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: 45780@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 13 19:10:00 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzkak-00069k-KE for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 Jan 2021 19:09:58 +0100 Original-Received: from localhost ([::1]:40446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzkaj-0003cR-Ig for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 Jan 2021 13:09:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52276) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzkXu-0001L2-HV for bug-gnu-emacs@gnu.org; Wed, 13 Jan 2021 13:07:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53217) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzkXu-00042w-8g for bug-gnu-emacs@gnu.org; Wed, 13 Jan 2021 13:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kzkXu-0000TP-3H for bug-gnu-emacs@gnu.org; Wed, 13 Jan 2021 13:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Clemens Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Jan 2021 18:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45780 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45780-submit@debbugs.gnu.org id=B45780.16105612101797 (code B ref 45780); Wed, 13 Jan 2021 18:07:02 +0000 Original-Received: (at 45780) by debbugs.gnu.org; 13 Jan 2021 18:06:50 +0000 Original-Received: from localhost ([127.0.0.1]:36530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzkXi-0000Su-Au for submit@debbugs.gnu.org; Wed, 13 Jan 2021 13:06:50 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:41601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzkXf-0000Sc-RX for 45780@debbugs.gnu.org; Wed, 13 Jan 2021 13:06:48 -0500 Original-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 8F17C2400FF for <45780@debbugs.gnu.org>; Wed, 13 Jan 2021 19:06:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1610561201; bh=TSysYnFAdIOKWKp/bvUIi3PQQgP+ngxtGUuk8YUX4cs=; h=Subject:To:Cc:From:Date:From; b=mQ0PZ99edzUCxKbm5RdyBCA5jMM9Fvol+xOt/2USmnWlwKxyVcHuFGFM1RPb6e/sm P1jaPdMUzanpBmHqpqPO9MmZcrpmlZ0XIuOsG2g8y9T+LFpXepTEL/YADkHrrzX+Mt F5WgtBKo2pqAlsT9/XVelv//8hgCPkL8uejUhQzOrfv5/aafTF8IjGClKooeukRyzl zJGI0QpzG7PN3RQoRg3+G+Z1i69fuHRaaAqMt247tD57g7R7E2eHoJYclcPT8Nyw2a EhjTby4wrXV96vBox0gZCRFEd/4/BXve9dAjNo6SEmUx/9zVA39jvsu/BWhhR/Ohxs taD5VN1YExSkQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4DGFkm6W3cz9rxR; Wed, 13 Jan 2021 19:06:40 +0100 (CET) In-Reply-To: <8735z6xx11.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197906 Archived-At: > 1. when only annotation suffix string is provided, then the face > completion-annotations is added; > > 2. when both prefix and suffix are provided, then the client decides > what face to add. Also it's possible to provide an empty prefix > string to be able to specify a custom face for the suffix string. > > So when the client wants to override the default annotation face, > this is already easy to do using something like (this is not a patch > to commit, but just demonstration of current abilities): I would prefer the more automatic behaviour I proposed as having completion-annotations face is nice when the client has not thought about it but when the client has provided a string with a face it is likely the client wants exactly that face and not a combination with completion-annotations face. Basing the decision on a provided prefix seems a bit arbitrary and one would need to figure this out by looking at the code.