From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#64347: 30.0.50; Some customize faces shown as edited with -Q Date: Sat, 15 Jul 2023 17:11:21 -0300 Message-ID: <77337d8b-9bbb-2642-0488-5899d05b76a8@gmail.com> References: <87jzvmd17f.fsf@gmx.net> <83cz1etpdm.fsf@gnu.org> <2b6de9de-f33f-0547-eaa0-1f9d24f70115@gmail.com> <28fa0831-bb28-b7c1-1535-3a950f6b2545@gmail.com> <83y1jqdeqm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------07YscNQpkPDQYQMnJnuRdeyS" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33815"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: stephen.berman@gmx.net, 64347@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 15 22:12:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKlcy-0008cl-RJ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jul 2023 22:12:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKlcZ-00056C-CO; Sat, 15 Jul 2023 16:12:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKlcY-000560-KO for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 16:12:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKlcY-0006ci-D8 for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 16:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKlcY-0002dx-8I for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 16:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jul 2023 20:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64347 X-GNU-PR-Package: emacs Original-Received: via spool by 64347-submit@debbugs.gnu.org id=B64347.168945189210106 (code B ref 64347); Sat, 15 Jul 2023 20:12:02 +0000 Original-Received: (at 64347) by debbugs.gnu.org; 15 Jul 2023 20:11:32 +0000 Original-Received: from localhost ([127.0.0.1]:46159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKlc4-0002cu-62 for submit@debbugs.gnu.org; Sat, 15 Jul 2023 16:11:32 -0400 Original-Received: from mail-ot1-x329.google.com ([2607:f8b0:4864:20::329]:49192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKlc2-0002cc-L4 for 64347@debbugs.gnu.org; Sat, 15 Jul 2023 16:11:31 -0400 Original-Received: by mail-ot1-x329.google.com with SMTP id 46e09a7af769-6b9bf0252f3so1330868a34.2 for <64347@debbugs.gnu.org>; Sat, 15 Jul 2023 13:11:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689451885; x=1692043885; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=5QcNve0PIwICWUs/BQK2Kj7nOXUH/b+csVMVmh4Zqgg=; b=SxZZT+xiBIkQn9kNwcxI44GeYbPsdPC/VkiJu3j2/5ttzqf6ZlvBZAaNNKsTbBm5uL /bgpE5peZGHRbniSFvjKF0WpYm/DwN3tFkm6PEYPKzc/0qBYbsC57AUSk8JimUFcrmrq htTBUJBiOV6Sj9UBkOEZxjbLcCyMAQPPKp8E2L+mWHEA8D81SSZ+UA1ioHQ3bFTjNlru LlyaIyUqMar4+UXavyG131sfIfFHp+ykCt9W6WIrax8iKq2xw4aCwcYNB3khDPp13EwT OT/bCtm3C3uDn9PsahF5RygNpK5BDgRpTQF1ZxxaM7Rr713xW3YCL2KGE8JpYMwgWgbQ P0dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689451885; x=1692043885; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=5QcNve0PIwICWUs/BQK2Kj7nOXUH/b+csVMVmh4Zqgg=; b=UxycU1xS6tC+12xIYuP9kqUVYACxYd5rfPNfphT/7BSOIpN5EcaVELiEZmHVr9XGAM XiU2WNqF2LYCnV4wGZ6ZcFIwBHtamsIby2Bxb4snm/DaEgn0DilsDUi8yg/ybc9J/Ceq pHCHTPZ/EOwRaK0HuJaCyRoYDUZjl09e9yHrtZgkdUn+zpyFYTi2a3vic0KSjbGfes+Q J6wLVrNhh1uSZG9u2Ghp9qLEYfZu8OpfWrDjvGn4+zOWPVFi2FRteqy6xNVZE7BVglqZ 6bpgVUFPiIeKciLdMEhgqHQyhB8SR7PtnFT77gQPsOQHp/8mooEjwclVTbp0NBPer3ft SnrQ== X-Gm-Message-State: ABy/qLYkoWZd0syWY5BmQDdTaobPSp4+xU2q8GGEv5nqszFGU1XDYagO TUD7qgviOtuUCEXtBuqZZ1uPOA5OIAkQZt+9 X-Google-Smtp-Source: APBJJlFupmsxgoNiahTrAh6+MnHx7O6yJ3Jt+nySEWOLLrCQuhxx6QqdgkOQbOPItROceEyNhtq+WA== X-Received: by 2002:a9d:4b04:0:b0:6b9:1ee7:5289 with SMTP id q4-20020a9d4b04000000b006b91ee75289mr7143869otf.10.1689451885007; Sat, 15 Jul 2023 13:11:25 -0700 (PDT) Original-Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id s19-20020a056830149300b006b9be9b41e7sm1681553otq.68.2023.07.15.13.11.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Jul 2023 13:11:24 -0700 (PDT) Content-Language: en-US In-Reply-To: <83y1jqdeqm.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265246 Archived-At: This is a multi-part message in MIME format. --------------07YscNQpkPDQYQMnJnuRdeyS Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Eli Zaretskii writes: >> Date: Fri, 30 Jun 2023 11:05:33 -0300 >> From: Mauro Aranda >> Cc: Stephen Berman , Eli Zaretskii >> >> To sum it up, I think there are bugs in custom-face-attributes. One is >> most surely a typo, and the other ones are oversights in the filters for >> the :underline and :box properties.  Fixing those, we are left with one >> bug, I think, that will be reproducible with Emacs -Q and evaluating: >> >> (defface test >>    '((((supports :underline (:style wave))) >>       :underline (:color "Red1" :style wave)) >>      (t >>       :inherit warning)) >>    "...") >> >> (defface test-2 >>    '((((supports :underline (:style wave))) >>       :underline (:style wave :color "Red1")) >>      (t >>       :inherit warning)) >>    "...") >> >> M-x customize-face RET test >> will show STANDARD state >> >> while >> M-x customize-face RET test-2 >> will show EDITED state > > Thanks. > > Can you show a patch for the two bugs you've succeeded to identify? > > Did you make any progress with the one bug that's left after the other > two are fixed? Here's a patch for the typo. Concerning the other bugs I discovered, I think that while the filters could be tweaked, a better fix would be to teach face-spec-match-p about matching plists correctly and not just by equality. --------------07YscNQpkPDQYQMnJnuRdeyS Content-Type: text/x-patch; charset=UTF-8; name="0001-Fix-typo-in-pre-filter-for-underline-property.patch" Content-Disposition: attachment; filename="0001-Fix-typo-in-pre-filter-for-underline-property.patch" Content-Transfer-Encoding: base64 RnJvbSA0MDliNTlmMjFmZWM1NDJlMTY3NDBiZmE2MmRhZjA5ZGY0Y2RjZWNiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IFNhdCwgMTUgSnVsIDIwMjMgMTc6MDU6MjMgLTAzMDAKU3ViamVjdDog W1BBVENIXSBGaXggdHlwbyBpbiBwcmUtZmlsdGVyIGZvciB1bmRlcmxpbmUgcHJvcGVydHkK CiogbGlzcC9jdXMtZmFjZS5lbCAoY3VzdG9tLWZhY2UtYXR0cmlidXRlcyk6IEZpeCB0eXBv IChCdWcjNjQzNDcpCi0tLQogbGlzcC9jdXMtZmFjZS5lbCB8IDIgKy0KIDEgZmlsZSBjaGFu Z2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3Av Y3VzLWZhY2UuZWwgYi9saXNwL2N1cy1mYWNlLmVsCmluZGV4IGVjODliNGY3ZmY2Li5hM2Ey NzI2M2E3YyAxMDA2NDQKLS0tIGEvbGlzcC9jdXMtZmFjZS5lbAorKysgYi9saXNwL2N1cy1m YWNlLmVsCkBAIC0xNTgsNyArMTU4LDcgQEAgY3VzdG9tLWZhY2UtYXR0cmlidXRlcwogCQkg ICAgKG9yIChhbmQgKGNvbnNwIHJlYWwtdmFsdWUpIChwbGlzdC1nZXQgcmVhbC12YWx1ZSA6 c3R5bGUpKQogCQkgICAgICAgICdsaW5lKSkKICAgICAgICAgICAgICAgICAgICAocG9zaXRp b24gKGFuZCAoY29uc3AgcmVhbC12YWx1ZSkKLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAocGxpc3QtZ2V0IHJlYWwtdmFsdWUgOnN0eWxlKSkpKQorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIChwbGlzdC1nZXQgcmVhbC12YWx1ZSA6cG9zaXRpb24p KSkpCiAJICAgICAgIChsaXN0IDpjb2xvciBjb2xvciA6c3R5bGUgc3R5bGUgOnBvc2l0aW9u IHBvc2l0aW9uKSkpKQogICAgICA7OyBmaWx0ZXIgdG8gbWFrZSBjdXN0b21pemVkLXZhbHVl IHN1aXRhYmxlIGZvciBzdG9yaW5nCiAgICAgICwobGFtYmRhIChjdXMtdmFsdWUpCi0tIAoy LjM0LjEKCg== --------------07YscNQpkPDQYQMnJnuRdeyS--