From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62776: 30.0.50; 'project-find-file' ignoring 'file-name-history' Date: Wed, 19 Apr 2023 18:49:39 +0300 Message-ID: <7717d45c-b88c-5956-1018-dd86d44cd25f@gutov.dev> References: <97545727-7123-ca74-3d2e-4ac5c6d8f25a@gutov.dev> <1310e385-f151-2a96-d7b9-cd21c082adc3@gutov.dev> <360f88a8-8dd9-5fd3-51ef-4b670aad2272@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35387"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 To: Daniel Mendler , Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= , 62776@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 19 17:50:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ppA4V-0008zK-PQ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Apr 2023 17:50:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ppA4L-0001Lk-0N; Wed, 19 Apr 2023 11:50:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppA4I-0001K3-K4 for bug-gnu-emacs@gnu.org; Wed, 19 Apr 2023 11:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ppA4H-0000sH-Vk for bug-gnu-emacs@gnu.org; Wed, 19 Apr 2023 11:50:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ppA4H-0008L8-Qv for bug-gnu-emacs@gnu.org; Wed, 19 Apr 2023 11:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Apr 2023 15:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62776 X-GNU-PR-Package: emacs Original-Received: via spool by 62776-submit@debbugs.gnu.org id=B62776.168191938932032 (code B ref 62776); Wed, 19 Apr 2023 15:50:01 +0000 Original-Received: (at 62776) by debbugs.gnu.org; 19 Apr 2023 15:49:49 +0000 Original-Received: from localhost ([127.0.0.1]:35590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppA45-0008Ka-4f for submit@debbugs.gnu.org; Wed, 19 Apr 2023 11:49:49 -0400 Original-Received: from new3-smtp.messagingengine.com ([66.111.4.229]:33149) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppA44-0008KL-4X for 62776@debbugs.gnu.org; Wed, 19 Apr 2023 11:49:48 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id C037E5823D6; Wed, 19 Apr 2023 11:49:42 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 19 Apr 2023 11:49:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1681919382; x=1681922982; bh=ro+z8Kn4/fx94oJ7kXyvVJi0eSpx+NbZyJs +HSbEOuM=; b=EX5xghe9ARAoML5w8Lui9mBtGbjojxlSqMxZQp/JVKW8j7CMxIn ckMT04VyeFVMcj4KskOKYmLDOIKtrNiIYoza0JtcwkhkDNRk5pzX7Xb8LIxlUKjn 8c0j/7PvMa4wFuzkPOTTGHDdbTdC0QFpU2b/I06WVJukJFUo2IGmY2cXRx5CDKVZ eKrUb7+OA0NRf0IhJHMWuuUXPHyDM2NdIw+EkdQiKmqhlxLUUIsipFR2NmYsJ9UX T7Gdlk18aOhWk5e5jq4OGzvwk79P9WzjosJyICrxN2rM8S1V/Ks8WjYToP5c2Q0Q ZCndU/2nKZHS2MnYed+BtY12FR/w/PIESxQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1681919382; x= 1681922982; bh=ro+z8Kn4/fx94oJ7kXyvVJi0eSpx+NbZyJs+HSbEOuM=; b=U dj/ShD+ZXlnxm2NiLM9vTvz+LTltr1S+uznHlY/66wAFifUbEu6BjpbPuSyfU4HG S1DJnU2mWiElDT7n5W1IhRbyvV/6KkmFSCwaifnXBxZ4GdIaUThAs8oYNG5lRMW3 1l6JQUO5ukdRlpxQ/XqRcql0X9XMmhPwbwxhDq56QtQrJ7YjfMkS4pS3UvIeaBES cmT6uRFJ9pmnJCvsl7MM3BCZZH/1kQBV1pvzGx0c+sfCDX8+HNCipBXPzM0aEo6G BcZk6rUzwj/rrYa0JzjZVtvEjfKP61TlDyh+v0W8UbMFBdqBRH21lL76WTrLHe3y GpVU3I40ddrOItxRIWMlQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedttddgleegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtje ertddtfeejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhu thhovhdruggvvheqnecuggftrfgrthhtvghrnhepgeehtdehudejieetuedttdejkeehje etueekheffuddtjeeuvdefveeuveeiuddunecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 19 Apr 2023 11:49:40 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260276 Archived-At: On 19/04/2023 18:46, Daniel Mendler wrote: >> IIUC the issue is that is has (added) special handling for file name >> completion, and predicates that on the name of the history variable. It >> can/should be combined with an extra check which makes sure that the >> completion table uses '/' as field separators. Maybe using the >> `completion-boundaries` thingy. Or just straight calling >> `completion-boundaries` on the history elements to extract the first >> segment instead of hardcoding '/'. > Vertico already handles completion boundaries. This is how the base > string `vertico--base` is computed. But as already mentioned, this is > unfortunately not the only issue. The issue is also that > `project-find-file` removes the base directory. The entries in the > history hash would need the same treatment. But they do: the dynamically bound value of file-name-history at the moment when completing-read is called contain only the relative file names (with base directory removed). That was the recent change in project.el we are referring to.