unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Konstantin Kharlamov <hi-angel@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 41684-done@debbugs.gnu.org
Subject: bug#41684: [PATCH] Highlight typed variables in python
Date: Sat, 13 Jun 2020 11:57:44 +0300	[thread overview]
Message-ID: <7711d0a2c41e4cb2c4d41527e608eed273221228.camel@yandex.ru> (raw)
In-Reply-To: <83ftaz4dvd.fsf@gnu.org>

On Sat, 2020-06-13 at 10:35 +0300, Eli Zaretskii wrote:
> > From: Konstantin Kharlamov <Hi-Angel@yandex.ru>
> > Date: Wed,  3 Jun 2020 14:51:03 +0300
> > 
> > * progmodes/python.el (python-font-lock-keywords-maximum-
> > decoration):
> > recognize typed variables like "foo: int = 1" as well.
> > ---
> 
> Thanks, I installed this on the master branch.

Thanks!

> For the future, please note a couple of minor stylistic nits:
> 
>   . it is better to submit patches in "git format-patch" format, as
>     that makes it easier to apply the patch

Hmm, okay… The patch was sent with git-send-email command, is it
different from git-format-patch? I used to see projects that in our
days still use (or have used) email for patches recommend specifically
sending patches with git-send-email, so it is a bit unusual
requirement, but I'll try to remember.

>   . the description in the log message should start with a capital
>     letter after the function's name

Okay, thanks. I'll try to remember, although it is unusual too, because
AFAIK from grammar standpoint a sentence continuation after a colon ":"
symbol should be lower-case.

>   . if a comment or a code line exceeds 80 columns, break them into
>     several lines






  reply	other threads:[~2020-06-13  8:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03 11:51 bug#41684: [PATCH] Highlight typed variables in python Konstantin Kharlamov
2020-06-09 23:12 ` Konstantin Kharlamov
2020-06-13  7:35 ` Eli Zaretskii
2020-06-13  8:57   ` Konstantin Kharlamov [this message]
2020-06-13  9:15     ` Eli Zaretskii
2020-06-13  9:21       ` Konstantin Kharlamov
2020-06-13 10:44     ` Basil L. Contovounesios
2020-06-13 20:01 ` Andrii Kolomoiets
2020-06-13 20:40   ` Konstantin Kharlamov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7711d0a2c41e4cb2c4d41527e608eed273221228.camel@yandex.ru \
    --to=hi-angel@yandex.ru \
    --cc=41684-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).