unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#65359: [PATCH] eglot: add "lexical" LSP server
@ 2023-08-18  1:38 Mou Tong
  2023-08-18  6:00 ` Eli Zaretskii
  0 siblings, 1 reply; 8+ messages in thread
From: Mou Tong @ 2023-08-18  1:38 UTC (permalink / raw)
  To: 65359


[-- Attachment #1.1: Type: text/plain, Size: 948 bytes --]

There is a new LSP server for elixir: [lexical].

Although it said there had problems to use it with eglot, but I didn't
meet the [problem] it said in the instruction.

And I had used it for serveral projects and it worked fine, I put this
in my config and I don't know if there is a better way:

```emacs-lisp
(with-eval-after-load 'eglot
  (setf (alist-get '(elixir-mode elixir-ts-mode heex-ts-mode)
                   eglot-server-programs
                   nil nil #'equal)
        (eglot-alternatives
         `(("start_lexical.sh")
           ,(if (and (fboundp 'w32-shell-dos-semantics)
                     (w32-shell-dos-semantics))
                '("language_server.bat")
              '("language_server.sh"))))))
```

So I send a patch like this.

[lexical]: https://github.com/lexical-lsp/lexical

[problem]: https://github.com/lexical-lsp/lexical/blob/main/pages/installation.md#vanilla-emacs-with-eglot


[-- Attachment #1.2: Type: text/html, Size: 2829 bytes --]

[-- Attachment #2: 0001-Add-lexical-LSP-server-to-Eglot.patch --]
[-- Type: application/octet-stream, Size: 1639 bytes --]

From f4789e6215291ca2be95f443e0d2a1b122a44b0d Mon Sep 17 00:00:00 2001
From: dalu <mou.tong@outlook.com>
Date: Thu, 17 Aug 2023 18:34:42 +0800
Subject: [PATCH] Add "lexical" LSP server to Eglot

---
 lisp/progmodes/eglot.el | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index 113ff08e94e..be7ed54c71d 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -219,10 +219,12 @@ eglot-server-programs
                                  . ("dart" "language-server"
                                     "--client-id" "emacs.eglot-dart"))
                                 ((elixir-mode elixir-ts-mode heex-ts-mode)
-                                 . ,(if (and (fboundp 'w32-shell-dos-semantics)
-                                             (w32-shell-dos-semantics))
-                                        '("language_server.bat")
-                                      '("language_server.sh")))
+                                 . ,(eglot-alternatives
+                                     `(("start_lexical.sh")
+                                       ,(if (and (fboundp 'w32-shell-dos-semantics)
+                                                 (w32-shell-dos-semantics))
+                                            '("language_server.bat")
+                                          '("language_server.sh")))))
                                 (ada-mode . ("ada_language_server"))
                                 (scala-mode . ,(eglot-alternatives
                                                 '("metals" "metals-emacs")))
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* bug#65359: [PATCH] eglot: add "lexical" LSP server
  2023-08-18  1:38 bug#65359: [PATCH] eglot: add "lexical" LSP server Mou Tong
@ 2023-08-18  6:00 ` Eli Zaretskii
  2023-08-18  6:19   ` Mou Tong
  0 siblings, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2023-08-18  6:00 UTC (permalink / raw)
  To: Mou Tong; +Cc: 65359

> From: Mou Tong <mou.tong@outlook.com>
> Date: Fri, 18 Aug 2023 01:38:39 +0000
> 
> There is a new LSP server for elixir: [lexical].
> 
> Although it said there had problems to use it with eglot, but I didn't
> meet the [problem] it said in the instruction.
> 
> And I had used it for serveral projects and it worked fine, I put this
> in my config and I don't know if there is a better way:
> 
> ```emacs-lisp
> (with-eval-after-load 'eglot
>  (setf (alist-get '(elixir-mode elixir-ts-mode heex-ts-mode)
>                   eglot-server-programs
>                   nil nil #'equal)
>        (eglot-alternatives
>         `(("start_lexical.sh")
>           ,(if (and (fboundp 'w32-shell-dos-semantics)
>                     (w32-shell-dos-semantics))
>                '("language_server.bat")
>              '("language_server.sh"))))))
> ```
> 
> So I send a patch like this. 
> 
> [lexical]: https://github.com/lexical-lsp/lexical
> 
> [problem]:
> https://github.com/lexical-lsp/lexical/blob/main/pages/installation.md#vanilla-emacs-with-eglot
> 
> 
> From f4789e6215291ca2be95f443e0d2a1b122a44b0d Mon Sep 17 00:00:00 2001
> From: dalu <mou.tong@outlook.com>
> Date: Thu, 17 Aug 2023 18:34:42 +0800
> Subject: [PATCH] Add "lexical" LSP server to Eglot
> 
> ---
>  lisp/progmodes/eglot.el | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> index 113ff08e94e..be7ed54c71d 100644
> --- a/lisp/progmodes/eglot.el
> +++ b/lisp/progmodes/eglot.el
> @@ -219,10 +219,12 @@ eglot-server-programs
>                                   . ("dart" "language-server"
>                                      "--client-id" "emacs.eglot-dart"))
>                                  ((elixir-mode elixir-ts-mode heex-ts-mode)
> -                                 . ,(if (and (fboundp 'w32-shell-dos-semantics)
> -                                             (w32-shell-dos-semantics))
> -                                        '("language_server.bat")
> -                                      '("language_server.sh")))
> +                                 . ,(eglot-alternatives
> +                                     `(("start_lexical.sh")
> +                                       ,(if (and (fboundp 'w32-shell-dos-semantics)
> +                                                 (w32-shell-dos-semantics))
> +                                            '("language_server.bat")
> +                                          '("language_server.sh")))))
>                                  (ada-mode . ("ada_language_server"))
>                                  (scala-mode . ,(eglot-alternatives
>                                                  '("metals" "metals-emacs")))

Thanks, but the fact the command is a shell script again needs the
w32-shell-dos-semantics dance, like language_server.sh did.





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#65359: [PATCH] eglot: add "lexical" LSP server
  2023-08-18  6:00 ` Eli Zaretskii
@ 2023-08-18  6:19   ` Mou Tong
  2023-08-18  6:39     ` Eli Zaretskii
  0 siblings, 1 reply; 8+ messages in thread
From: Mou Tong @ 2023-08-18  6:19 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 65359@debbugs.gnu.org

Eli Zaretskii <eliz@gnu.org> writes:

> Thanks, but the fact the command is a shell script again needs the
> w32-shell-dos-semantics dance, like language_server.sh did.

I'm afraid lexical doesn't support Windows for now.

Currently lexical only provides `start_lexical.sh`, but I guess it
will support Windows soon since I had seen such a sentence in this
[PR] (it got merged in last week):

> All of our files can be ported to windows fairly easily

Should we wait until it supports Windows?

[PR]: https://github.com/lexical-lsp/lexical/pull/314






^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#65359: [PATCH] eglot: add "lexical" LSP server
  2023-08-18  6:19   ` Mou Tong
@ 2023-08-18  6:39     ` Eli Zaretskii
  2023-08-18  7:08       ` Mou Tong
  0 siblings, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2023-08-18  6:39 UTC (permalink / raw)
  To: Mou Tong; +Cc: 65359

> From: Mou Tong <mou.tong@outlook.com>
> CC: "65359@debbugs.gnu.org" <65359@debbugs.gnu.org>
> Date: Fri, 18 Aug 2023 06:19:10 +0000
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Thanks, but the fact the command is a shell script again needs the
> > w32-shell-dos-semantics dance, like language_server.sh did.
> 
> I'm afraid lexical doesn't support Windows for now.

Then we should make this entry be in effect only on systems that
aren't Windows.

> Should we wait until it supports Windows?

I don't mind installing this now, but only if it doesn't break Elixir
support on Windows, which would mean this new entry should be hidden
when Emacs runs on Windows.

I also don't mind waiting...





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#65359: [PATCH] eglot: add "lexical" LSP server
  2023-08-18  6:39     ` Eli Zaretskii
@ 2023-08-18  7:08       ` Mou Tong
  2023-08-19  8:38         ` Eli Zaretskii
  0 siblings, 1 reply; 8+ messages in thread
From: Mou Tong @ 2023-08-18  7:08 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 65359@debbugs.gnu.org

[-- Attachment #1: Type: text/plain, Size: 575 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> Then we should make this entry be in effect only on systems that
> aren't Windows.
>
> I don't mind installing this now, but only if it doesn't break Elixir
> support on Windows, which would mean this new entry should be hidden
> when Emacs runs on Windows.

Oh, I see, here is the new patch, I'm using the `eglot-alternatives`
in the else so we don't see lexical on Windows.

> I also don't mind waiting...

Actually I'd like it got merged so I needn't to keep the hack in my
configuration. (Forgive me laziness...)


[-- Attachment #2: 0001-Add-lexical-LSP-server-to-Eglot.patch --]
[-- Type: application/octet-stream, Size: 1185 bytes --]

From 18161aea6287ffd177834fdac156f6037c410856 Mon Sep 17 00:00:00 2001
From: dalu <mou.tong@outlook.com>
Date: Thu, 17 Aug 2023 18:34:42 +0800
Subject: [PATCH] Add "lexical" LSP server to Eglot

lexical does not support Windows currently
---
 lisp/progmodes/eglot.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index 113ff08e94e..65daa0941d5 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -222,7 +222,8 @@ eglot-server-programs
                                  . ,(if (and (fboundp 'w32-shell-dos-semantics)
                                              (w32-shell-dos-semantics))
                                         '("language_server.bat")
-                                      '("language_server.sh")))
+                                      (eglot-alternatives
+                                       '("language_server.sh" "start_lexical.sh"))))
                                 (ada-mode . ("ada_language_server"))
                                 (scala-mode . ,(eglot-alternatives
                                                 '("metals" "metals-emacs")))
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* bug#65359: [PATCH] eglot: add "lexical" LSP server
  2023-08-18  7:08       ` Mou Tong
@ 2023-08-19  8:38         ` Eli Zaretskii
  2023-08-19 10:51           ` João Távora
  0 siblings, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2023-08-19  8:38 UTC (permalink / raw)
  To: Mou Tong, João Távora; +Cc: 65359

> From: Mou Tong <mou.tong@outlook.com>
> CC: "65359@debbugs.gnu.org" <65359@debbugs.gnu.org>
> Date: Fri, 18 Aug 2023 07:08:42 +0000
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Then we should make this entry be in effect only on systems that
> > aren't Windows.
> >
> > I don't mind installing this now, but only if it doesn't break Elixir
> > support on Windows, which would mean this new entry should be hidden
> > when Emacs runs on Windows.
> 
> Oh, I see, here is the new patch, I'm using the `eglot-alternatives`
> in the else so we don't see lexical on Windows.
> 
> > I also don't mind waiting...
> 
> Actually I'd like it got merged so I needn't to keep the hack in my
> configuration. (Forgive me laziness...)

João, is the below OK with you?  It's for the master branch.

> From 18161aea6287ffd177834fdac156f6037c410856 Mon Sep 17 00:00:00 2001
> From: dalu <mou.tong@outlook.com>
> Date: Thu, 17 Aug 2023 18:34:42 +0800
> Subject: [PATCH] Add "lexical" LSP server to Eglot
> 
> lexical does not support Windows currently
> ---
>  lisp/progmodes/eglot.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> index 113ff08e94e..65daa0941d5 100644
> --- a/lisp/progmodes/eglot.el
> +++ b/lisp/progmodes/eglot.el
> @@ -222,7 +222,8 @@ eglot-server-programs
>                                   . ,(if (and (fboundp 'w32-shell-dos-semantics)
>                                               (w32-shell-dos-semantics))
>                                          '("language_server.bat")
> -                                      '("language_server.sh")))
> +                                      (eglot-alternatives
> +                                       '("language_server.sh" "start_lexical.sh"))))
>                                  (ada-mode . ("ada_language_server"))
>                                  (scala-mode . ,(eglot-alternatives
>                                                  '("metals" "metals-emacs")))
> -- 
> 2.41.0
> 





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#65359: [PATCH] eglot: add "lexical" LSP server
  2023-08-19  8:38         ` Eli Zaretskii
@ 2023-08-19 10:51           ` João Távora
  2023-08-19 14:11             ` Eli Zaretskii
  0 siblings, 1 reply; 8+ messages in thread
From: João Távora @ 2023-08-19 10:51 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 65359, Mou Tong

On Sat, Aug 19, 2023 at 9:38 AM Eli Zaretskii <eliz@gnu.org> wrote:

> > Actually I'd like it got merged so I needn't to keep the hack in my
> > configuration. (Forgive me laziness...)
>
> João, is the below OK with you?  It's for the master branch.

Yes, it's fine.  Thanks.

João





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#65359: [PATCH] eglot: add "lexical" LSP server
  2023-08-19 10:51           ` João Távora
@ 2023-08-19 14:11             ` Eli Zaretskii
  0 siblings, 0 replies; 8+ messages in thread
From: Eli Zaretskii @ 2023-08-19 14:11 UTC (permalink / raw)
  To: João Távora; +Cc: 65359-done, mou.tong

> From: João Távora <joaotavora@gmail.com>
> Date: Sat, 19 Aug 2023 11:51:48 +0100
> Cc: Mou Tong <mou.tong@outlook.com>, 65359@debbugs.gnu.org
> 
> On Sat, Aug 19, 2023 at 9:38 AM Eli Zaretskii <eliz@gnu.org> wrote:
> 
> > > Actually I'd like it got merged so I needn't to keep the hack in my
> > > configuration. (Forgive me laziness...)
> >
> > João, is the below OK with you?  It's for the master branch.
> 
> Yes, it's fine.  Thanks.

Thanks, installed on master, and closing the bug.





^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2023-08-19 14:11 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-18  1:38 bug#65359: [PATCH] eglot: add "lexical" LSP server Mou Tong
2023-08-18  6:00 ` Eli Zaretskii
2023-08-18  6:19   ` Mou Tong
2023-08-18  6:39     ` Eli Zaretskii
2023-08-18  7:08       ` Mou Tong
2023-08-19  8:38         ` Eli Zaretskii
2023-08-19 10:51           ` João Távora
2023-08-19 14:11             ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).