From: Glenn Morris <rgm@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 8613@debbugs.gnu.org
Subject: bug#8613: "mode:" for minor-mode breaks set-visited-file-name
Date: Mon, 09 May 2011 19:41:16 -0400 [thread overview]
Message-ID: <76pqnrjvc3.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <we4o5bxudd.fsf@fencepost.gnu.org>
Do you have a preference for a solution?
Here's the hack-one-local-variable-eval-safep version:
*** lisp/files.el 2011-04-24 00:24:30 +0000
--- lisp/files.el 2011-05-09 23:22:07 +0000
***************
*** 3327,3332 ****
--- 3327,3336 ----
;; Certain functions can be allowed with safe arguments
;; or can specify verification functions to try.
(and (symbolp (car exp))
+ ;; Allow (minor)-modes calls with no arguments.
+ ;; This obsoletes the use of "mode:" for such things. (Bug#8613)
+ (or (and (null (cdr exp))
+ (string-match "-mode\\'" (symbol-name (car exp))))
(let ((prop (get (car exp) 'safe-local-eval-function)))
(cond ((eq prop t)
(let ((ok t))
***************
*** 3341,3347 ****
(dolist (function prop)
(if (funcall function exp)
(setq ok t)))
! ok)))))))
(defun hack-one-local-variable (var val)
"Set local variable VAR with value VAL.
--- 3345,3351 ----
(dolist (function prop)
(if (funcall function exp)
(setq ok t)))
! ok))))))))
(defun hack-one-local-variable (var val)
"Set local variable VAR with value VAL.
next prev parent reply other threads:[~2011-05-09 23:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 23:00 bug#8613: "mode:" for minor-mode breaks set-visited-file-name Glenn Morris
2011-05-04 0:38 ` Stefan Monnier
2011-05-04 2:08 ` Glenn Morris
2011-05-04 12:52 ` Stefan Monnier
2011-05-05 2:20 ` Glenn Morris
2011-05-05 12:40 ` Stefan Monnier
2011-05-09 22:05 ` Glenn Morris
2011-05-09 22:44 ` Stefan Monnier
2011-05-09 23:41 ` Glenn Morris [this message]
2011-05-10 1:09 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76pqnrjvc3.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=8613@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).